applied dry on fetchCsvData

Author: nknittin16436

src/UtilityFunctions/FetchCsvData.ts

@@ -1,58 +1,21 @@
 import { parse, ParseResult } from 'papaparse';
-import { Author, Book, Magazine } from './dtos';
 
 
-export const parseCsvFromBookUrl = async (url: string) => {
-    const parseFile = (url: string): Promise<Book[]> => {
+export const parseCsvFromUrl = async <T>(url: string): Promise<T[]> => {
+    const parseFile = (url: string): Promise<T[]> => {
         return new Promise(resolve => {
             parse(url, {
                 download: true,
                 header: true,
                 dynamicTyping: true,
                 skipEmptyLines: true,
-                complete: function (results: ParseResult<Book>) {
+                complete: function (results: ParseResult<T>) {
                     console.log(results.data);
                     resolve(results.data);
                 }
             });
         });
     };
-    let parsedData: Book[] = await parseFile(url);
+    let parsedData: T[] = await parseFile(url);
     return parsedData;
 }
-export const parseCsvFromMagazineUrl = async (url: string) => {
-    const parseFile = (url: string): Promise<Magazine[]> => {
-        return new Promise(resolve => {
-            parse(url, {
-                download: true,
-                header: true,
-                dynamicTyping: true,
-                skipEmptyLines: true,
-                complete: function (results: ParseResult<Magazine>) {
-                    console.log(results.data);
-                    resolve(results.data);
-                }
-            });
-        });
-    };
-    let parsedData: Magazine[] = await parseFile(url);
-    return parsedData;
-}
-export const parseCsvFromAuthorUrl = async (url: string) => {
-    const parseFile = (url: string): Promise<Author[]> => {
-        return new Promise(resolve => {
-            parse(url, {
-                download: true,
-                header: true,
-                dynamicTyping: true,
-                skipEmptyLines: true,
-                complete: function (results: ParseResult<Author>) {
-                    console.log(results.data);
-                    resolve(results.data);
-                }
-            });
-        });
-    };
-    let parsedData: Author[] = await parseFile(url);
-    return parsedData;
-}

src/components/DisplayTables/AuthorsTable.tsx

@@ -1,7 +1,7 @@
 import React, { useEffect, useState } from 'react'
 import { Table } from 'antd';
 import type { ColumnsType, TableProps } from 'antd/es/table';
-import { parseCsvFromAuthorUrl } from '../../UtilityFunctions/FetchCsvData';
+import { parseCsvFromUrl } from '../../UtilityFunctions/FetchCsvData';
 import { Author } from '../../UtilityFunctions/dtos';
 
 interface DataType {
@@ -32,9 +32,9 @@ const AuthorTable = () => {
         console.log('params', pagination, filters, sorter, extra);
     };
     const fetchMagazines = async () => {
-        const parsedMagazines: Author[] = await parseCsvFromAuthorUrl(AUTHORS_CSV_URL);
-        console.log(parsedMagazines)
-        setMagazines(parsedMagazines);
+        const parsedAuthors: Author[] = await parseCsvFromUrl<Author>(AUTHORS_CSV_URL);
+        console.log(parsedAuthors)
+        setMagazines(parsedAuthors);
     }
 
     useEffect(() => {

src/components/DisplayTables/BooksTable.tsx

@@ -1,7 +1,7 @@
 import React, { useEffect, useState } from 'react'
 import { Table } from 'antd';
 import type { ColumnsType, TableProps } from 'antd/es/table';
-import { parseCsvFromBookUrl } from '../../UtilityFunctions/FetchCsvData';
+import { parseCsvFromUrl } from '../../UtilityFunctions/FetchCsvData';
 import { Book } from '../../UtilityFunctions/dtos';
 
 interface DataType {
@@ -18,7 +18,7 @@ const columns: ColumnsType<DataType> = [
     {
         title: 'Isbn',
         dataIndex: 'isbn',
-        width:200
+        width: 200
     },
     {
         title: 'Authors',
@@ -39,7 +39,7 @@ const BooksTable = () => {
         console.log('params', pagination, filters, sorter, extra);
     };
     const fetchBooks = async () => {
-        const parsedBooks: Book[] = await parseCsvFromBookUrl(BOOKS_CSV_URL);
+        const parsedBooks: Book[] = await parseCsvFromUrl<Book>(BOOKS_CSV_URL);
         console.log(parsedBooks)
         setBooks(parsedBooks);
     }

src/components/DisplayTables/MagazineTable.tsx

@@ -1,7 +1,7 @@
 import React, { useEffect, useState } from 'react'
 import { Table } from 'antd';
 import type { ColumnsType, TableProps } from 'antd/es/table';
-import { parseCsvFromMagazineUrl } from '../../UtilityFunctions/FetchCsvData';
+import { parseCsvFromUrl } from '../../UtilityFunctions/FetchCsvData';
 import { Magazine } from '../../UtilityFunctions/dtos';
 
 interface DataType {
@@ -40,7 +40,7 @@ const MagazineTable = () => {
         console.log('params', pagination, filters, sorter, extra);
     };
     const fetchMagazines = async () => {
-        const parsedMagazines: Magazine[] = await parseCsvFromMagazineUrl(MagazineS_CSV_URL);
+        const parsedMagazines: Magazine[] = await parseCsvFromUrl<Magazine>(MagazineS_CSV_URL);
         console.log(parsedMagazines)
         setMagazines(parsedMagazines);
     }