Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: espressif/arduino-esp32
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: nicolaser15/arduino-esp32
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: nicolaser15-patch-1
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jul 30, 2020

  1. Update Parsing.cpp 

    When uploading TLS cert files the end of file "-----END CERTIFICATE-----" (or any kind of file with the sequence "CRLF--") is taken as posible end boundary. Then it is compared to the start boundary string. As it is expected, comparison turns to be false, and the whole end boundary string is put to _currentUpload->buf through _uploadWriteByte(). Here you have the problem: if you read boundary.length() bytes from HTTP request and you have some of the actual end boundary bytes in it, when you put all those bytes into _currentUpload->buf you are making a mistake. You will miss the actual end boundary string because some of those bytes were put in _currentUpload->buf.
    @nicolaser15
    nicolaser15 authored Jul 30, 2020
    Configuration menu
    Copy the full SHA
    439923e View commit details
    Browse the repository at this point in the history

  2. Update Parsing.cpp

    @nicolaser15
    nicolaser15 authored Jul 30, 2020
    Configuration menu
    Copy the full SHA
    7294ff1 View commit details
    Browse the repository at this point in the history
Loading