Refactor BugTestCase

- Always load the mappings from the same namespace
- Change type of Mappings property on TestCase to string[]

Author: hazzik

src/NHibernate.Test.VisualBasic/Issues/IssueTestCase.vb

@@ -2,17 +2,4 @@
 
 Public Class IssueTestCase
     Inherits BugTestCase
-
-    Protected Overrides ReadOnly Property MappingsAssembly As String
-        Get
-            Return "NHibernate.Test.VisualBasic"
-        End Get
-    End Property
-
-    Protected Overrides ReadOnly Property Mappings As IList
-        Get
-            Return New String() {"Issues." + BugNumber + ".Mappings.hbm.xml"}
-        End Get
-    End Property
-
 End Class

src/NHibernate.Test/Ado/BatcherFixture.cs

@@ -13,7 +13,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Ado.VerySimple.hbm.xml", "Ado.AlmostSimple.hbm.xml" }; }
 		}

src/NHibernate.Test/Ado/GenericBatchingBatcherFixture.cs

@@ -15,7 +15,7 @@ public class GenericBatchingBatcherFixture : TestCase
 	{
 		protected override string MappingsAssembly => "NHibernate.Test";
 
-		protected override IList Mappings => new[] {"Ado.VerySimple.hbm.xml"};
+		protected override string[] Mappings => new[] {"Ado.VerySimple.hbm.xml"};
 
 		protected override void Configure(Configuration configuration)
 		{

src/NHibernate.Test/Any/AnyTypeTest.cs

@@ -11,7 +11,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] {"Any.Person.hbm.xml"}; }
 		}

src/NHibernate.Test/Async/Ado/BatcherFixture.cs

@@ -25,7 +25,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Ado.VerySimple.hbm.xml", "Ado.AlmostSimple.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Ado/GenericBatchingBatcherFixture.cs

@@ -28,7 +28,7 @@ public class GenericBatchingBatcherFixtureAsync : TestCase
 	{
 		protected override string MappingsAssembly => "NHibernate.Test";
 
-		protected override IList Mappings => new[] {"Ado.VerySimple.hbm.xml"};
+		protected override string[] Mappings => new[] {"Ado.VerySimple.hbm.xml"};
 
 		protected override void Configure(Configuration configuration)
 		{

src/NHibernate.Test/Async/Any/AnyTypeTest.cs

@@ -22,7 +22,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] {"Any.Person.hbm.xml"}; }
 		}

src/NHibernate.Test/Async/BulkManipulation/NativeSQLBulkOperations.cs

@@ -23,7 +23,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] { "BulkManipulation.Vehicle.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/BulkManipulation/NativeSQLBulkOperationsWithCache.cs

@@ -27,7 +27,7 @@ public class NativeSQLBulkOperationsWithCacheAsync : TestCase
 	{
 		protected override string MappingsAssembly => "NHibernate.Test";
 
-		protected override IList Mappings => new[] { "BulkManipulation.Vehicle.hbm.xml" };
+		protected override string[] Mappings => new[] { "BulkManipulation.Vehicle.hbm.xml" };
 
 		protected override void Configure(Configuration configuration)
 		{

src/NHibernate.Test/Async/CacheTest/BatchableCacheFixture.cs

@@ -29,7 +29,7 @@ namespace NHibernate.Test.CacheTest
 	[TestFixture]
 	public class BatchableCacheFixtureAsync : TestCase
 	{
-		protected override IList Mappings => new[]
+		protected override string[] Mappings => new[]
 		{
 			"CacheTest.ReadOnly.hbm.xml",
 			"CacheTest.ReadWrite.hbm.xml"

src/NHibernate.Test/Async/CacheTest/BatchableCacheSubclassFixture.cs

@@ -24,7 +24,7 @@ namespace NHibernate.Test.CacheTest
 	[TestFixture]
 	public class BatchableCacheSubclassFixtureAsync : TestCase
 	{
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get
 			{

src/NHibernate.Test/Async/CacheTest/GetQueryCacheFixture.cs

@@ -24,7 +24,7 @@ namespace NHibernate.Test.CacheTest
 	[TestFixture]
 	public class GetQueryCacheFixtureAsync : TestCase
 	{
-		protected override IList Mappings => new[] { "Simple.hbm.xml" };
+		protected override string[] Mappings => new[] { "Simple.hbm.xml" };
 
 		protected override void Configure(Configuration configuration)
 		{

src/NHibernate.Test/Async/CacheTest/QueryCacheFixture.cs

@@ -20,7 +20,7 @@ namespace NHibernate.Test.CacheTest
 	[TestFixture]
 	public class QueryCacheFixtureAsync : TestCase
 	{
-		protected override IList Mappings => new[] { "Simple.hbm.xml" };
+		protected override string[] Mappings => new[] { "Simple.hbm.xml" };
 
 		protected override void Configure(Configuration configuration)
 		{

src/NHibernate.Test/Async/Cascade/Circle/CascadeMergeToChildBeforeParentTest.cs

@@ -44,7 +44,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Cascade.Circle.CascadeMergeToChildBeforeParent.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Cascade/Circle/MultiPathCircleCascadeTest.cs

@@ -51,7 +51,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Cascade.Circle.MultiPathCircleCascade.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Cascade/MultiPathCascadeTest.cs

@@ -28,7 +28,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Cascade.MultiPathCascade.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Cascade/RefreshFixture.cs

@@ -26,7 +26,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Cascade.Job.hbm.xml", "Cascade.JobBatch.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Classic/LifecycleFixture.cs

@@ -23,7 +23,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Classic.EntityWithLifecycle.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Classic/ValidatableFixture.cs

@@ -23,7 +23,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] { "Classic.Video.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/CollectionFilterTest/CollectionFilterQueriesTest.cs

@@ -21,7 +21,7 @@ namespace NHibernate.Test.CollectionFilterTest
 	[TestFixture]
 	public class CollectionFilterQueriesTestAsync : TestCase
 	{
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get
 			{

src/NHibernate.Test/Async/CollectionTest/IdBagFixture.cs

@@ -19,7 +19,7 @@ namespace NHibernate.Test.CollectionTest
 	[TestFixture]
 	public class IdBagFixtureAsync : TestCase
 	{
-		protected override System.Collections.IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] { "CollectionTest.IdBagFixture.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/CollectionTest/NullableValueTypeElementMapFixture.cs

@@ -18,7 +18,7 @@ namespace NHibernate.Test.CollectionTest
 	[TestFixture]
 	public class NullableValueTypeElementMapFixtureAsync : TestCase
 	{
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] {"CollectionTest.NullableValueTypeElementMapFixture.hbm.xml"}; }
 		}

src/NHibernate.Test/Async/Component/Basic/ComponentTest.cs

@@ -30,7 +30,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}		
 
-		protected override System.Collections.IList Mappings
+		protected override string[] Mappings
 		{
 			get { return Array.Empty<string>(); }
 		}

src/NHibernate.Test/Async/CompositeId/ClassWithCompositeIdFixture.cs

@@ -32,7 +32,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] {"CompositeId.ClassWithCompositeId.hbm.xml"}; }
 		}

src/NHibernate.Test/Async/CompositeId/CompositeIdFixture.cs

@@ -24,7 +24,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get
 			{

src/NHibernate.Test/Async/Criteria/CriteriaQueryTest.cs

@@ -30,7 +30,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get
 			{

src/NHibernate.Test/Async/Criteria/DetachedCriteriaSerializable.cs

@@ -28,7 +28,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] { "Criteria.Enrolment.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Criteria/Lambda/FunctionsIntegrationFixture.cs

@@ -21,7 +21,7 @@ public class FunctionsIntegrationFixtureAsync : TestCase
 	{
 		protected override string MappingsAssembly => "NHibernate.Test";
 
-		protected override IList Mappings => new[] { "Criteria.Lambda.Mappings.hbm.xml" };
+		protected override string[] Mappings => new[] { "Criteria.Lambda.Mappings.hbm.xml" };
 
 		protected override void OnTearDown()
 		{

src/NHibernate.Test/Async/Criteria/Lambda/IntegrationFixture.cs

@@ -26,7 +26,7 @@ public class IntegrationFixtureAsync : TestCase
 	{
 		protected override string MappingsAssembly { get { return "NHibernate.Test"; } }
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Criteria.Lambda.Mappings.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Criteria/Lambda/ProjectIntegrationFixture.cs

@@ -25,7 +25,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Criteria.Lambda.Mappings.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Criteria/Lambda/SimpleIntegrationFixture.cs

@@ -22,7 +22,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Criteria.Lambda.Mappings.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Criteria/Lambda/SubQueryIntegrationFixture.cs

@@ -24,7 +24,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "Criteria.Lambda.Mappings.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/Criteria/ProjectionsTest.cs

@@ -29,7 +29,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get
 			{

src/NHibernate.Test/Async/Deletetransient/DeleteTransientEntityTest.cs

@@ -22,7 +22,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] {"Deletetransient.Person.hbm.xml"}; }
 		}

src/NHibernate.Test/Async/DriverTest/NullReferenceFixture.cs

@@ -21,7 +21,7 @@ namespace NHibernate.Test.DriverTest
 	[TestFixture]
 	public class NullReferenceFixtureAsync : TestCase
 	{
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] {"Simple.hbm.xml"}; }
 		}

src/NHibernate.Test/Async/DriverTest/OdbcDriverFixture.cs

@@ -23,7 +23,7 @@ public class OdbcDriverFixtureAsync : TestCase
 	{
 		protected override string MappingsAssembly => "NHibernate.Test";
 
-		protected override IList Mappings => new[] { "DriverTest.MultiTypeEntity.hbm.xml" };
+		protected override string[] Mappings => new[] { "DriverTest.MultiTypeEntity.hbm.xml" };
 
 		protected override bool AppliesTo(Dialect.Dialect dialect)
 		{

src/NHibernate.Test/Async/DriverTest/Sql2008DateTime2Test.cs

@@ -31,7 +31,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "DriverTest.EntityForMs2008.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/DriverTest/SqlClientDriverFixture.cs

@@ -27,7 +27,7 @@ public class SqlClientDriverFixtureAsync : TestCase
 	{
 		protected override string MappingsAssembly => "NHibernate.Test";
 
-		protected override IList Mappings => new[] { "DriverTest.MultiTypeEntity.hbm.xml" };
+		protected override string[] Mappings => new[] { "DriverTest.MultiTypeEntity.hbm.xml" };
 
 		protected override bool AppliesTo(Dialect.Dialect dialect)
 		{

src/NHibernate.Test/Async/DriverTest/SqlServerCeDriverFixture.cs

@@ -28,7 +28,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "DriverTest.SqlServerCeEntity.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/DynamicEntity/Interceptor/InterceptorDynamicEntity.cs

@@ -25,7 +25,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] {"DynamicEntity.Interceptor.Customer.hbm.xml"}; }
 		}

src/NHibernate.Test/Async/DynamicEntity/Tuplizer/TuplizerDynamicEntity.cs

@@ -26,7 +26,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new string[] {"DynamicEntity.Tuplizer.Customer.hbm.xml"}; }
 		}

src/NHibernate.Test/Async/DynamicProxyTests/InterfaceProxySerializationTests/ProxyFixture.cs

@@ -22,7 +22,7 @@ namespace NHibernate.Test.DynamicProxyTests.InterfaceProxySerializationTests
 	[TestFixture]
 	public class ProxyFixtureAsync : TestCase
 	{
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] { "DynamicProxyTests.InterfaceProxySerializationTests.ProxyImpl.hbm.xml" }; }
 		}

src/NHibernate.Test/Async/EntityModeTest/Map/Basic/DynamicClassFixture.cs

@@ -26,7 +26,7 @@ protected override string MappingsAssembly
 			get { return "NHibernate.Test"; }
 		}
 
-		protected override IList Mappings
+		protected override string[] Mappings
 		{
 			get { return new[] {"EntityModeTest.Map.Basic.ProductLine.hbm.xml"}; }
 		}