Fix CodeFactor issues

Author: bahusoid

src/NHibernate.Test/Async/MultiTenancy/DatabaseStrategyNoDbSpecificFixture.cs

@@ -16,7 +16,6 @@
 using System.Runtime.Serialization.Formatters.Binary;
 using NHibernate.Cfg;
 using NHibernate.Cfg.MappingSchema;
-using NHibernate.Connection;
 using NHibernate.Dialect;
 using NHibernate.Driver;
 using NHibernate.Engine;

src/NHibernate.Test/MultiTenancy/DatabaseStrategyNoDbSpecificFixture.cs

@@ -6,7 +6,6 @@
 using System.Runtime.Serialization.Formatters.Binary;
 using NHibernate.Cfg;
 using NHibernate.Cfg.MappingSchema;
-using NHibernate.Connection;
 using NHibernate.Dialect;
 using NHibernate.Driver;
 using NHibernate.Engine;
@@ -346,51 +345,4 @@ protected override void OnSetUp()
 
 		#endregion Test Setup
 	}
-
-	[Serializable]
-	class Entity
-	{
-		public virtual Guid Id { get; set; }
-		public virtual string Name { get; set; }
-	}
-	
-	public class MockConnectionProvider : IMultiTenantConnectionProvider
-	{
-		private readonly IConnectionAccess _connectionAccess;
-
-		public MockConnectionProvider(string tenantIdentifier, IConnectionAccess connectionAccess)
-		{
-			_connectionAccess = connectionAccess;
-			TenantIdentifier = tenantIdentifier;
-		}
-
-		public string TenantIdentifier { get; }
-		public IConnectionAccess GetConnectionAccess()
-		{
-			return _connectionAccess;
-		}
-	}
-
-	[Serializable]
-	public class TestTenantConnectionProvider : AbstractMultiTenantConnectionProvider
-	{
-		public TestTenantConnectionProvider(ISessionFactoryImplementor sfi, string tenantId, bool isSqlServerDialect)
-		{
-			TenantIdentifier = tenantId;
-			SessionFactory = sfi;
-			TenantConnectionString = sfi.ConnectionProvider.GetConnectionString();
-			if (isSqlServerDialect)
-			{
-				var stringBuilder = new SqlConnectionStringBuilder(sfi.ConnectionProvider.GetConnectionString());
-				stringBuilder.ApplicationName = tenantId;
-				TenantConnectionString = stringBuilder.ToString();
-			}
-		}
-
-		protected override string TenantConnectionString { get; }
-
-		public override string TenantIdentifier { get; }
-
-		protected override ISessionFactoryImplementor SessionFactory { get; }
-	}
 }

src/NHibernate.Test/MultiTenancy/Entity.cs

@@ -0,0 +1,11 @@
+using System;
+
+namespace NHibernate.Test.MultiTenancy
+{
+	[Serializable]
+	class Entity
+	{
+		public virtual Guid Id { get; set; }
+		public virtual string Name { get; set; }
+	}
+}

src/NHibernate.Test/MultiTenancy/MockConnectionProvider.cs

@@ -0,0 +1,22 @@
+using NHibernate.Connection;
+using NHibernate.MultiTenancy;
+
+namespace NHibernate.Test.MultiTenancy
+{
+	public class MockConnectionProvider : IMultiTenantConnectionProvider
+	{
+		private readonly IConnectionAccess _connectionAccess;
+
+		public MockConnectionProvider(string tenantIdentifier, IConnectionAccess connectionAccess)
+		{
+			_connectionAccess = connectionAccess;
+			TenantIdentifier = tenantIdentifier;
+		}
+
+		public string TenantIdentifier { get; }
+		public IConnectionAccess GetConnectionAccess()
+		{
+			return _connectionAccess;
+		}
+	}
+}

src/NHibernate.Test/MultiTenancy/TestTenantConnectionProvider.cs

@@ -0,0 +1,31 @@
+using System;
+using System.Data.SqlClient;
+using NHibernate.Connection;
+using NHibernate.Engine;
+using NHibernate.MultiTenancy;
+
+namespace NHibernate.Test.MultiTenancy
+{
+	[Serializable]
+	public class TestTenantConnectionProvider : AbstractMultiTenantConnectionProvider
+	{
+		public TestTenantConnectionProvider(ISessionFactoryImplementor sfi, string tenantId, bool isSqlServerDialect)
+		{
+			TenantIdentifier = tenantId;
+			SessionFactory = sfi;
+			TenantConnectionString = sfi.ConnectionProvider.GetConnectionString();
+			if (isSqlServerDialect)
+			{
+				var stringBuilder = new SqlConnectionStringBuilder(sfi.ConnectionProvider.GetConnectionString());
+				stringBuilder.ApplicationName = tenantId;
+				TenantConnectionString = stringBuilder.ToString();
+			}
+		}
+
+		protected override string TenantConnectionString { get; }
+
+		public override string TenantIdentifier { get; }
+
+		protected override ISessionFactoryImplementor SessionFactory { get; }
+	}
+}

src/NHibernate/AdoNet/ConnectionManager.cs

@@ -84,7 +84,6 @@ public ConnectionManager(
 #pragma warning disable 618
 			: this(session, suppliedConnection, connectionReleaseMode, interceptor, shouldAutoJoinTransaction)
 #pragma warning restore 618
-
 		{
 			_connectionAccess = connectionAccess ?? throw new ArgumentNullException(nameof(connectionAccess));
 		}

src/NHibernate/Cache/CacheKey.cs

@@ -90,7 +90,7 @@ private int GenerateHashCode()
 
 			if (_tenantIdentifier != null)
 			{
-				hashCode = 37 * hashCode + _tenantIdentifier.GetHashCode();
+				hashCode = (37 * hashCode) + _tenantIdentifier.GetHashCode();
 			}
 
 			return hashCode;

src/NHibernate/Cache/QueryKey.cs

@@ -258,7 +258,7 @@ public int ComputeHashCode()
 				result = 37 * result + _sqlQueryString.GetHashCode();
 				if (_tenantIdentifier != null)
 				{
-					result = 37 * result + _tenantIdentifier.GetHashCode();
+					result = (37 * result) + _tenantIdentifier.GetHashCode();
 				}
 				return result;
 			}