Test cases GH1413 (ISession.IsDirty() unexpected behavior)

Author: bahusoid

src/NHibernate.Test/NHSpecificTest/GH1413/Entities.cs

@@ -0,0 +1,19 @@
+using System;
+using System.Collections.Generic;
+
+namespace NHibernate.Test.NHSpecificTest.GH1413
+{
+	public class EntityChild
+	{
+		public virtual Guid Id { get; set; }
+		public virtual string Name { get; set; }
+	}
+
+	public class EntityParent
+	{
+		public virtual Guid Id { get; set; }
+		public virtual string Name { get; set; }
+		public virtual EntityChild Child { get; set; }
+		public virtual IList<EntityChild> Children { get; set; } = new List<EntityChild>();
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH1413/FixtureByCode.cs

@@ -0,0 +1,114 @@
+using System;
+using System.Linq;
+using NHibernate.Cfg.MappingSchema;
+using NHibernate.Mapping.ByCode;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.GH1413
+{
+	[TestFixture]
+	public class ByCodeFixture : TestCaseMappingByCode
+	{
+		private Guid ParentId;
+
+		protected override HbmMapping GetMappings()
+		{
+			var mapper = new ModelMapper();
+			mapper.Class<EntityParent>(rc =>
+			{
+				rc.Id(x => x.Id, m => m.Generator(Generators.GuidComb));
+				rc.Property(x => x.Name);
+				rc.ManyToOne(ep => ep.Child);
+				rc.Bag(x => x.Children, m =>
+				{
+					m.Cascade(Mapping.ByCode.Cascade.All);
+					m.Inverse(true);
+				}, a => a.OneToMany()
+				);
+			});
+
+			mapper.Class<EntityChild>(rc =>
+			{
+				rc.Id(x => x.Id, m => m.Generator(Generators.GuidComb));
+				rc.Property(x => x.Name);
+			});
+
+			return mapper.CompileMappingForAllExplicitlyAddedEntities();
+		}
+
+		protected override void OnSetUp()
+		{
+			using (ISession session = OpenSession())
+			using (ITransaction transaction = session.BeginTransaction())
+			{
+				var child = new EntityChild { Name = "InitialChild" };
+				var parent = new EntityParent
+				{
+					Name = "InitialParent",
+					Child = child
+				};
+				session.Save(child);
+				session.Save(parent);
+				
+				session.Flush();
+				transaction.Commit();
+				ParentId = parent.Id;
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			using (ISession session = OpenSession())
+			using (ITransaction transaction = session.BeginTransaction())
+			{
+				session.Delete("from System.Object");
+
+				session.Flush();
+				transaction.Commit();
+			}
+		}
+
+		[Test]
+		public void SessionIsDirtyShouldNotFailForNewManyToOneObject()
+		{
+			using (ISession session = OpenSession())
+			using (session.BeginTransaction())
+			{
+				EntityParent parent = GetParent(session);
+
+				//parent.Child entity is not cascaded, I want to save it explictilty later
+				parent.Child = new EntityChild { Name = "NewManyToOneChild" };
+
+				bool isDirty = false;
+				Assert.That(() => isDirty = session.IsDirty(), Throws.Nothing, () => "ISession.IsDirty() call should not fail for transient  many-to-one object referenced in session.");
+				Assert.That(isDirty, "ISession.IsDirty() call should return true.");
+			}
+		}
+
+		[Test]
+		public void SessionIsDirtyShouldNotTriggerCascadeSaving()
+		{
+			using (ISession session = OpenSession())
+			using (session.BeginTransaction())
+			{
+				var parent = GetParent(session);
+				var entityChild = new EntityChild
+				{
+					Name = "NewListElem"
+				};
+				
+				//parent.Children is cascaded
+				parent.Children.Add(entityChild);
+
+				var isDirty = session.IsDirty();
+				Assert.That(entityChild.Id, Is.EqualTo(Guid.Empty), "Transient objects should not be saved by ISession.IsDirty() call (expected empty Guid Id)");
+				Assert.That(isDirty, "ISession.IsDirty() call should return true.");
+			}
+		}
+
+		private EntityParent GetParent(ISession session)
+		{
+			return session.Get<EntityParent>(ParentId);
+		}
+	}
+}