NH-3619 - Set default flush mode to Auto

Author: hazzik

src/NHibernate.Test/App.config

@@ -52,13 +52,9 @@
 			<property name="show_sql">false</property>
 			<property name="command_timeout">444</property>
 
-			<property name="default_flush_mode">Commit</property>
-			
-		</session-factory>
+	</session-factory>
 	</hibernate-configuration>
 
-
-
 	<log4net debug="false">
 
 		<!-- Appenders -->

src/NHibernate.Test/CfgTest/DefaultFlushModeFixture.cs

@@ -1,6 +1,8 @@
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 using System.Text;
+using System.Xml;
 using NHibernate.Cfg;
 using NUnit.Framework;
 
@@ -12,13 +14,19 @@ public class DefaultFlushModeFixture
 		[Test]
 		public void CanSetDefaultFlushModeThroughXmlConfiguration()
 		{
-			var cfg = new Configuration().Configure();
+			const string c = @"<hibernate-configuration xmlns=""urn:nhibernate-configuration-2.2"">
+		<session-factory name=""NHibernate.Test"">
+			<property name=""default_flush_mode"">Commit</property>
+		</session-factory>
+	</hibernate-configuration>";
+
+			var cfg = new Configuration().Configure(new XmlTextReader(new StringReader(c)));
 
 			using (var sessionFactory = cfg.BuildSessionFactory())
 			{
 				using (var session = sessionFactory.OpenSession())
 				{
-					Assert.AreEqual(session.FlushMode, FlushMode.Commit);
+					Assert.AreEqual(FlushMode.Commit, session.FlushMode);
 				}
 			}
 		}
@@ -33,7 +41,7 @@ public void CanSetDefaultFlushModeThroughStandardConfiguration()
 			{
 				using (var session = sessionFactory.OpenSession())
 				{
-					Assert.AreEqual(session.FlushMode, FlushMode.Always);
+					Assert.AreEqual(FlushMode.Always, session.FlushMode);
 				}
 			}
 
@@ -43,7 +51,7 @@ public void CanSetDefaultFlushModeThroughStandardConfiguration()
 			{
 				using (var session = sessionFactory.OpenSession())
 				{
-					Assert.AreEqual(session.FlushMode, FlushMode.Commit);
+					Assert.AreEqual(FlushMode.Commit, session.FlushMode);
 				}
 			}
 		}
@@ -62,7 +70,7 @@ public void CanSetDefaultFlushModeThroughLoquaciousConfiguration()
 			{
 				using (var session = sessionFactory.OpenSession())
 				{
-					Assert.AreEqual(session.FlushMode, FlushMode.Always);
+					Assert.AreEqual(FlushMode.Always, session.FlushMode);
 				}
 			}
 
@@ -74,7 +82,7 @@ public void CanSetDefaultFlushModeThroughLoquaciousConfiguration()
 			{
 				using (var session = sessionFactory.OpenSession())
 				{
-					Assert.AreEqual(session.FlushMode, FlushMode.Commit);
+					Assert.AreEqual(FlushMode.Commit, session.FlushMode);
 				}
 			}
 		}

src/NHibernate/Cfg/SettingsFactory.cs

@@ -260,7 +260,7 @@ public Settings BuildSettings(IDictionary<string, string> properties)
 			}
 
 			//NH-3619
-			FlushMode defaultFlushMode = (FlushMode) Enum.Parse(typeof(FlushMode), PropertiesHelper.GetString(Environment.DefaultFlushMode, properties, FlushMode.Unspecified.ToString()), false);
+			FlushMode defaultFlushMode = (FlushMode) Enum.Parse(typeof(FlushMode), PropertiesHelper.GetString(Environment.DefaultFlushMode, properties, FlushMode.Auto.ToString()), false);
 			log.Info("Default flush mode: " + defaultFlushMode);
 			settings.DefaultFlushMode = defaultFlushMode;