Adding error in the log about not using auto prop

SVN: trunk@4924

Author: ayende

src/NHibernate.Test/LazyProperty/LazyPropertyFixture.cs

@@ -1,13 +1,17 @@
 using System.Collections;
+using log4net.Core;
 using NHibernate.ByteCode.Castle;
 using NHibernate.Cfg;
+using NHibernate.Tuple.Entity;
 using NUnit.Framework;
 
 namespace NHibernate.Test.LazyProperty
 {
 	[TestFixture]
 	public class LazyPropertyFixture : TestCase
 	{
+		private string log;
+
 		protected override string MappingsAssembly
 		{
 			get { return "NHibernate.Test"; }
@@ -24,6 +28,15 @@ protected override void Configure(NHibernate.Cfg.Configuration configuration)
 									  typeof(ProxyFactoryFactory).AssemblyQualifiedName);
 		}
 
+		protected override void BuildSessionFactory()
+		{
+			using (var logSpy = new LogSpy(typeof(EntityMetamodel)))
+			{
+				base.BuildSessionFactory();
+				log = logSpy.GetWholeLog();
+			}
+		}
+
 		protected override void OnSetUp()
 		{
 			using (var s = OpenSession())
@@ -69,6 +82,12 @@ public void PropertyLoadedNotInitialized()
 			}
 		}
 
+		[Test]
+		public void ShouldGenerateErrorForNonAutoPropLazyProp()
+		{
+			Assert.IsTrue(log.Contains("Lazy property NHibernate.Test.LazyProperty.Book.ALotOfText is not an auto property, which may result in uninitialized property access"));
+		}
+
 		[Test]
 		public void PropertyLoadedNotInitializedWhenUsingGet()
 		{

src/NHibernate/Tuple/Entity/EntityMetamodel.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Runtime.CompilerServices;
 using Iesi.Collections.Generic;
 using log4net;
 using NHibernate.Engine;
@@ -229,6 +230,18 @@ public EntityMetamodel(PersistentClass persistentClass, ISessionFactoryImplement
 				else
 				{
 					log.Info("lazy property fetching available for: " + name);
+					foreach (var prop in persistentClass.PropertyClosureIterator)
+					{
+						if (prop.IsLazy == false)
+							continue;
+
+						var getter = prop.GetGetter(persistentClass.MappedClass);
+						if(getter.Method == null || 
+							getter.Method.IsDefined(typeof(CompilerGeneratedAttribute), false) == false)
+						{
+							log.ErrorFormat("Lazy property {0}.{1} is not an auto property, which may result in uninitialized property access", persistentClass.EntityName, prop.Name);	
+						}
+					}
 				}
 			}