bugfix: the value of the Location response header set by the ngx.header.HEADER API might get overwritten by nginx's header filter to the fully qualified form (with the scheme and host parts).

Author: agentzh

src/ngx_http_lua_headers_out.c

@@ -38,6 +38,8 @@ static ngx_int_t ngx_http_clear_last_modified_header(ngx_http_request_t *r,
     ngx_http_lua_header_val_t *hv, ngx_str_t *value);
 static ngx_int_t ngx_http_clear_content_length_header(ngx_http_request_t *r,
     ngx_http_lua_header_val_t *hv, ngx_str_t *value);
+static ngx_int_t ngx_http_set_location_header(ngx_http_request_t *r,
+    ngx_http_lua_header_val_t *hv, ngx_str_t *value);
 
 
 static ngx_http_lua_set_header_t  ngx_http_lua_set_handlers[] = {
@@ -58,7 +60,7 @@ static ngx_http_lua_set_header_t  ngx_http_lua_set_handlers[] = {
 
     { ngx_string("Location"),
                  offsetof(ngx_http_headers_out_t, location),
-                 ngx_http_set_builtin_header },
+                 ngx_http_set_location_header },
 
     { ngx_string("Refresh"),
                  offsetof(ngx_http_headers_out_t, refresh),
@@ -237,6 +239,32 @@ ngx_http_set_header_helper(ngx_http_request_t *r, ngx_http_lua_header_val_t *hv,
 }
 
 
+static ngx_int_t
+ngx_http_set_location_header(ngx_http_request_t *r,
+    ngx_http_lua_header_val_t *hv, ngx_str_t *value)
+{
+    ngx_int_t         rc;
+    ngx_table_elt_t  *h;
+
+    rc = ngx_http_set_builtin_header(r, hv, value);
+    if (rc != NGX_OK) {
+        return rc;
+    }
+
+    /*
+     * we do not set r->headers_out.location here to avoid the handling
+     * the local redirects without a host name by ngx_http_header_filter()
+     */
+
+    h = r->headers_out.location;
+    if (h && h->value.len && h->value.data[0] == '/') {
+        r->headers_out.location = NULL;
+    }
+
+    return NGX_OK;
+}
+
+
 static ngx_int_t
 ngx_http_set_builtin_header(ngx_http_request_t *r,
     ngx_http_lua_header_val_t *hv, ngx_str_t *value)

t/016-resp-header.t

@@ -9,7 +9,7 @@ use Test::Nginx::Socket::Lua;
 
 repeat_each(2);
 
-plan tests => repeat_each() * (blocks() * 3 + 24);
+plan tests => repeat_each() * (blocks() * 3 + 26);
 
 #no_diff();
 no_long_string();
@@ -1346,3 +1346,41 @@ hi
 --- error_log
 my Transfer-Encoding: nil
 
+
+
+=== TEST 65: set Location (no host)
+--- config
+    location = /t {
+        content_by_lua '
+            ngx.header.location = "/foo/bar"
+            return ngx.exit(301)
+        ';
+    }
+--- request
+GET /t
+--- response_headers
+Location: /foo/bar
+--- response_body_like: 301 Moved Permanently
+--- error_code: 301
+--- no_error_log
+[error]
+
+
+
+=== TEST 66: set Location (with host)
+--- config
+    location = /t {
+        content_by_lua '
+            ngx.header.location = "http://test.com/foo/bar"
+            return ngx.exit(301)
+        ';
+    }
+--- request
+GET /t
+--- response_headers
+Location: http://test.com/foo/bar
+--- response_body_like: 301 Moved Permanently
+--- error_code: 301
+--- no_error_log
+[error]
+