Skip to content

Commit f224cab

Browse files
committed
Impoprove unittest
1 parent 9b0d0a7 commit f224cab

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

unittest-core.py

+10-10
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,15 @@ def _common_plugin_tests(self, plugin):
8888

8989
# Check stats
9090
self.assertIsInstance(plugin_instance.get_raw(), (dict, list))
91-
if isinstance(plugin_instance.get_raw(), dict):
91+
if isinstance(plugin_instance.get_raw(), dict) and plugin_instance.get_raw() != {}:
9292
res = False
9393
for f in plugin_instance.fields_description:
9494
if f not in plugin_instance.get_raw():
9595
print(f"WARNING: {f} field not found in {plugin} plugin stats")
9696
else:
9797
res = True
9898
self.assertTrue(res)
99-
elif isinstance(plugin_instance.get_raw(), list):
99+
elif isinstance(plugin_instance.get_raw(), list) and len(plugin_instance.get_raw()) > 0:
100100
res = False
101101
for i in plugin_instance.get_raw():
102102
for f in i:
@@ -592,10 +592,10 @@ def test_099_output_bars(self):
592592
bar.percent = 110
593593
self.assertEqual(bar.get(), '|||||||||||||||||||||||||||||||||||||||||||| >100%')
594594

595-
# def test_100_system_plugin_method(self):
596-
# """Test system plugin methods"""
597-
# print('INFO: [TEST_100] Test system plugin methods')
598-
# self._common_plugin_tests('system')
595+
def test_100_system_plugin_method(self):
596+
"""Test system plugin methods"""
597+
print('INFO: [TEST_100] Test system plugin methods')
598+
self._common_plugin_tests('system')
599599

600600
def test_101_cpu_plugin_method(self):
601601
"""Test cpu plugin methods"""
@@ -623,10 +623,10 @@ def test_105_network_plugin_method(self):
623623
print('INFO: [TEST_105] Test network plugin methods')
624624
self._common_plugin_tests('network')
625625

626-
# def test_106_diskio_plugin_method(self):
627-
# """Test diskio plugin methods"""
628-
# print('INFO: [TEST_106] Test diskio plugin methods')
629-
# self._common_plugin_tests('diskio')
626+
def test_106_diskio_plugin_method(self):
627+
"""Test diskio plugin methods"""
628+
print('INFO: [TEST_106] Test diskio plugin methods')
629+
self._common_plugin_tests('diskio')
630630

631631
def test_107_fs_plugin_method(self):
632632
"""Test fs plugin methods"""

0 commit comments

Comments
 (0)