Extended VC++ Dep check to include version and also check after updates

Change-Id: Ia8c4185de5f594a7dee6e941a7087e58a8688b68

Author: mzinner

gui/extension/src/WebviewProviders/WelcomeWebviewProvider.ts

@@ -408,7 +408,7 @@ const getWelcomeWebviewContent = (rootPath: Uri, showVCRuntimePrompt: boolean):
                             nextBtn.value = "Next >";
                             currentPage = vcRuntimePage + 1;
                         } else {
-                            const errorMessage = "VC++ runtime library installation not detected.";
+                            const errorMessage = "VC++ runtime library installation not detected or it is too old.";
                             document.getElementById("checkError").innerHTML = errorMessage;
 
                             showPage(vcRuntimePage);
@@ -454,7 +454,7 @@ const getWelcomeWebviewContent = (rootPath: Uri, showVCRuntimePrompt: boolean):
  *
  * @returns true, if the VC++ runtimes are installed, otherwise false
  */
-const checkVcRuntime = (): Promise<boolean> => {
+export const checkVcRuntime = (): Promise<boolean> => {
     return new Promise((resolve, reject) => {
         if (platform() === "win32") {
             // cSpell:ignore HKLM Runtimes promisified
@@ -467,8 +467,20 @@ const checkVcRuntime = (): Promise<boolean> => {
                 for (const key in items) {
                     const item = items[key];
                     if (item.exists) {
-                        cRuntimeInstalled = true;
-                        break;
+                        if ("Version" in item.values) {
+                            const versionStr = item.values.Version.value.toString();
+                            if (versionStr.length > 6) {
+                                try {
+                                    const version = parseFloat(versionStr.substring(1, 6));
+                                    if (version >= 14.38) {
+                                        cRuntimeInstalled = true;
+                                        break;
+                                    }
+                                } catch {
+                                    // Ignore
+                                }
+                            }
+                        }
                     }
                 }
 

gui/extension/src/extension.ts

@@ -41,7 +41,7 @@ import {
 
 import { ExtensionHost } from "./ExtensionHost.js";
 import { webSession } from "../../frontend/src/supplement/WebSession.js";
-import { setupInitialWelcomeWebview } from "./WebviewProviders/WelcomeWebviewProvider.js";
+import { checkVcRuntime, setupInitialWelcomeWebview } from "./WebviewProviders/WelcomeWebviewProvider.js";
 import { waitFor } from "../../frontend/src/utilities/helpers.js";
 import { MessageScheduler } from "../../frontend/src/communication/MessageScheduler.js";
 
@@ -288,9 +288,10 @@ export const activate = (context: ExtensionContext): void => {
     const lastRunVersion = context.globalState.get("MySQLShellLastRunVersion");
     if (!lastRunVersion || lastRunVersion === "" || lastRunVersion !== currentVersion) {
         void context.globalState.update("MySQLShellLastRunVersion", currentVersion);
+        const osName = platform();
 
         // Reset extended attributes on macOS
-        if (platform() === "darwin") {
+        if (osName === "darwin") {
             const shellDir = join(context.extensionPath, "shell");
             if (existsSync(shellDir)) {
                 // cSpell:ignore xattr
@@ -301,6 +302,29 @@ export const activate = (context: ExtensionContext): void => {
                 // cSpell:ignore xattr
                 void childProcess.execSync(`xattr -rc ${routerDir}`);
             }
+        } else if (osName === "win32") {
+            const promptForVcUpdate = () => {
+                // cSpell:ignore redist msvc
+                void window.showErrorMessage(
+                    "The Microsoft Visual C++ Redistributable needs to be updated and VS Code needs to be " +
+                    "restarted. Do you want to open the Microsoft download page?",
+                    "Open Download Page", "Cancel").then((answer) => {
+                        if (answer !== "Cancel") {
+                            void env.openExternal(Uri.parse(
+                                "https://learn.microsoft.com/en-us/cpp/windows/" +
+                                "latest-supported-vc-redist?view=msvc-170"));
+                        }
+                    });
+            };
+
+            checkVcRuntime().then((result: boolean) => {
+                if (!result) {
+                    promptForVcUpdate();
+                }
+            }).catch((reason) => {
+                printChannelOutput(String(reason), true);
+                promptForVcUpdate();
+            });
         }
     }