You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BUG#36181365: Fix terminology in replication test utilities
This changes terminology in filenames of replication test utilities:
- Change terminology by applying the following replacements in all
filenames for test utilities that need it, and in places their
names occur in test files:
master->source
slave->replica
slave_io->receiver
slave_sql->applier
mts->mta
spco->rpco
- Structure the test directories as follows:
mysql-test/include
Generic, reusable test utilities. Like today.
mysql-test/include/rpl
Moved all replication-related, reusable test utilities here, and
removed the rpl_ prefix from the filename, for those that had it.
Previously these were in mysql-test/include.
mysql-test/include/rpl/impl
Helper files used by files in mysql-test/rpl, which are internal
to them and not usable by test cases.
mysql-test/include/rpl/debug
Replication-related, reusable debugging tools. These are only
for temporary use in debugging sessions, and we should never
push tests that use them.
mysql-test/include/rpl/deprecated
Old tools that have better alternatives nowadays. Don't use them.
We only don't remove them because they are used by tests (and
those tests work OK so no need to refactor them either).
mysql-test/common
Fragments of test cases that are shared between multiple tests,
but not generally reusable. Typically, if a .inc file executes
specific SQL statements, it probably belongs here rather than
in mysql-test/include. This has two subdirectories:
mysql-test/common/binlog
Test fragments that use one server.
Previously these were in mysql-test/extra/binlog_tests. (And
some were erroneously in mysql-test/include or
mysql-test/suite/binlog/include.)
mysql-test/common/rpl
Test fragments that use multiple servers.
Previously these were in mysql-test/extra/rpl_tests. (And
some were erroneously in mysql-test/include or
mysql-test/suite/rpl/include.)
- Rename include/only_* to include/have_*
This makes the files follow existing convention.
- For the files to init/deinit replication:
include/master-slave.inc->include/rpl/init_source_replica.inc
include/rpl_end.inc->include/rpl/deinit.inc
- For the files used to sync nodes:
sync_slave_sql_with_master.inc->sync_to_replica.inc
sync_slave_io_with_master.inc->sync_to_replica_received.inc
sync_slave_io.inc->sync_received_with_saved.inc
sync_slave_sql.inc->sync_with_saved.inc
sync_slave_sql_with_io.inc->sync_with_recieved.inc
save_master_pos.inc->save_server_position.inc
save_io_thread_pos.inc->save_received_position.inc
rpl_get_end_of_relay_log.inc->save_relay_log_file_position.inc
save_binlog_position.inc->save_binlog_file_position.inc
- Clarify these names:
get_relay_log_pos.inc->convert_binlog_position_to_relay_log_position.inc
purge_first_log.inc->purge_first_binlog.inc
wait_for_slave_param.inc->wait_for_replica_status.inc
- Rename these assertion utilities:
include/check_slave_is_running.inc->include/rpl/assert_replica_running.inc
include/check_slave_no_error.inc->include/rpl/assert_replica_no_error.inc
include/check_slave_param.inc->include/rpl/assert_replica_status.inc
- Add mysql-test/include/readme.md.
- Other minor changes.
Change-Id: Ice3e43d0673e4654b820165da1f997c9ec78f66e
0 commit comments