Bug#37471922: Auto-fix clang-tidy warnings [64/n] [noclose]

Generate fixes for a number of warnings that clang-tidy can fix automatically.
This commit fixes the warning 'modernize-loop-convert'.

Change example:
 - for (int i = 0; i < m_noOfSectionNames; i++) {
 -   const char *s = m_sectionNames[i];
 + for (auto s : m_sectionNames) {

Change-Id: I6582ea5235080425d85b40dc50df82d52d8fcc1c

Author: MRajcic

client/mysql_config_editor.cc

@@ -1244,9 +1244,9 @@ bool generate_login_key() {
 
   verbose_msg("Generating a new key.\n");
   /* Get a sequence of random non-printable ASCII */
-  for (uint i = 0; i < LOGIN_KEY_LEN; i++) {
+  for (char &i : my_key) {
     bool failed;
-    my_key[i] = (char)((int)(my_rnd_ssl(&failed) * 100000) % 32);
+    i = (char)((int)(my_rnd_ssl(&failed) * 100000) % 32);
     if (failed) return true;
   }
   return false;

client/mysqldump.cc

@@ -1774,8 +1774,8 @@ static bool do_ignore_error() {
 
   if (last_errno == 0) goto done;
 
-  for (uint *it = ignore_error.begin(); it != ignore_error.end(); ++it) {
-    if (last_errno == *it) {
+  for (unsigned int &it : ignore_error) {
+    if (last_errno == it) {
       found = true;
       break;
     }

client/mysqltest.cc

@@ -1526,8 +1526,8 @@ static void free_used_memory() {
     my_free((*q));
   }
 
-  for (size_t i = 0; i < 10; i++) {
-    if (var_reg[i].alloced_len) my_free(var_reg[i].str_val);
+  for (auto &i : var_reg) {
+    if (i.alloced_len) my_free(i.str_val);
   }
 
   delete q_lines;
@@ -2569,8 +2569,7 @@ static void set_property(st_command *command, enum_prop property, bool value) {
 void revert_properties() {
   if (!once_property) return;
 
-  for (std::size_t i = 0; i < P_MAX; i++) {
-    Property &prop = prop_list[i];
+  for (auto &prop : prop_list) {
     if (prop.set) {
       *prop.var = prop.old;
       prop.set = false;
@@ -6224,9 +6223,8 @@ static void do_error(struct st_command *command) {
         die("The sqlstate must be exactly %d chars long.", SQLSTATE_LENGTH);
 
       // Check the validity of an SQLSTATE string.
-      for (std::size_t i = 0; i < error.length(); i++) {
-        if (!my_isdigit(charset_info, error[i]) &&
-            !my_isupper(charset_info, error[i]))
+      for (char i : error) {
+        if (!my_isdigit(charset_info, i) && !my_isupper(charset_info, i))
           die("The sqlstate may only consist of digits[0-9] and _uppercase_ "
               "letters.");
       }

client/mysqltest/expected_errors.cc

@@ -39,8 +39,8 @@ std::string Expected_errors::error_list() {
 
 std::vector<unsigned int> Expected_errors::errors() {
   std::vector<unsigned int> errors;
-  for (std::size_t i = 0; i < m_errors.size(); i++) {
-    errors.push_back(m_errors.at(i)->error_code());
+  for (auto &m_error : m_errors) {
+    errors.push_back(m_error->error_code());
   }
   return errors;
 }

client/mysqltest/expected_warnings.cc

@@ -26,9 +26,9 @@
 void Expected_warnings::add_warning(std::uint32_t warning_code,
                                     const char *warning_name,
                                     bool once_property) {
-  for (std::size_t i = 0; i < m_warnings.size(); i++) {
+  for (auto &m_warning : m_warnings) {
     // Warning already exist, don't add it.
-    if (m_warnings.at(i)->warning_code() == warning_code) return;
+    if (m_warning->warning_code() == warning_code) return;
   }
 
   // Add a new warning to the existing list.

components/pfs_component/pfs_example_continent.cc

@@ -41,8 +41,7 @@ Continent_record continent_records_array[CONTINENT_MAX_ROWS] = {{"", 0, false}};
 
 int continent_delete_all_rows() {
   native_mutex_lock(&LOCK_continent_records_array);
-  for (int i = 0; i < CONTINENT_MAX_ROWS; i++)
-    continent_records_array[i].m_exist = false;
+  for (auto &i : continent_records_array) i.m_exist = false;
   continent_rows_in_table = 0;
   continent_next_available_index = 0;
   native_mutex_unlock(&LOCK_continent_records_array);

components/pfs_component/pfs_example_country.cc

@@ -421,8 +421,7 @@ int country_delete_row_values(PSI_table_handle *handle) {
 
 int country_delete_all_rows() {
   native_mutex_lock(&LOCK_country_records_array);
-  for (int i = 0; i < COUNTRY_MAX_ROWS; i++)
-    country_records_array[i].m_exist = false;
+  for (auto &i : country_records_array) i.m_exist = false;
   country_rows_in_table = 0;
   country_next_available_index = 0;
   native_mutex_unlock(&LOCK_country_records_array);

components/test/test_audit_api_message.cc

@@ -186,8 +186,8 @@ static mysql_service_status_t init() {
 
 static mysql_service_status_t deinit() {
   int was_present = 0;
-  for (size_t i = 0; i < no_udfs; ++i)
-    mysql_service_udf_registration->udf_unregister(udf_names[i], &was_present);
+  for (auto udf_name : udf_names)
+    mysql_service_udf_registration->udf_unregister(udf_name, &was_present);
 
   return false;
 }

components/test/test_event_tracking_consumer.cc

@@ -259,9 +259,7 @@ class Event_tracking_counters {
  public:
   /** Constructor */
   Event_tracking_counters() {
-    for (unsigned int i = 0; i < static_cast<unsigned int>(Event_types::LAST);
-         ++i)
-      event_counters_[i] = 0;
+    for (auto &event_counter : event_counters_) event_counter = 0;
   }
 
   /** Destructor */
@@ -311,9 +309,7 @@ class Event_tracking_counters {
   }
 
   void reset_all() {
-    for (unsigned int index = 0;
-         index < static_cast<unsigned int>(Event_types::LAST); ++index)
-      event_counters_[index] = 0;
+    for (auto &event_counter : event_counters_) event_counter = 0;
   }
 
  private:

libmysql/authentication_kerberos/gssapi_utility.cc

@@ -38,13 +38,13 @@ static void gssapi_errmsg(OM_uint32 major, OM_uint32 minor, char *buf,
   char *end = t_message + size - 1;
   int types[] = {GSS_C_GSS_CODE, GSS_C_MECH_CODE};
 
-  for (int i = 0; i < 2; i++) {
+  for (int type : types) {
     message_context = 0;
-    status_code = types[i] == GSS_C_GSS_CODE ? major : minor;
+    status_code = type == GSS_C_GSS_CODE ? major : minor;
 
     if (!status_code) continue;
     do {
-      maj_status = gss_display_status(&min_status, status_code, types[i],
+      maj_status = gss_display_status(&min_status, status_code, type,
                                       GSS_C_NO_OID, &message_context, &status);
       if (maj_status) break;