Bug #29557747: DEBUG-ASSERT WHILE RESTARTING SERVER POST INSTALL COMPONENT

RB#22585

The server was trying to binlog "special tables" creation, i.e. the
tables that plugins create that are not exactly tables but rather just
a way for DD to get a grip about tables existing in plugins, but not yet
in DD.
No need to be doing this since this is part of the initialization of all
plugins/components.
Fixed by turning off binlog for that operation.
Test case added.

Author: gkodinov

Diff for: mysql-test/suite/perfschema/r/table_component_binlog.result

@@ -0,0 +1,14 @@
+#
+# Bug #29557747: DEBUG-ASSERT WHILE RESTARTING SERVER POST INSTALL
+#  COMPONENT
+#
+INSTALL COMPONENT "file://component_pfs_example_component_population";
+include/assert.inc [Nothing was written to the binlog by adding a PFS table]
+# Must not crash
+# restart
+SELECT "it's alive";
+it's alive
+it's alive
+UNINSTALL COMPONENT "file://component_pfs_example_component_population";
+include/assert.inc [Nothing was written to the binlog by removing a PFS table]
+# End of 8.0 tests

Diff for: mysql-test/suite/perfschema/t/table_component_binlog-master.opt

@@ -0,0 +1,3 @@
+$PFS_EXAMPLE_COMPONENT_POPULATION_OPT
+--gtid_mode=ON
+--enforce_gtid_consistency=true

Diff for: mysql-test/suite/perfschema/t/table_component_binlog.test

@@ -0,0 +1,28 @@
+--source include/have_binlog_format_row.inc
+
+--echo #
+--echo # Bug #29557747: DEBUG-ASSERT WHILE RESTARTING SERVER POST INSTALL
+--echo #  COMPONENT
+--echo #
+
+--let $before=query_get_value('SHOW MASTER STATUS', Position, 1)
+INSTALL COMPONENT "file://component_pfs_example_component_population";
+--let $after=query_get_value('SHOW MASTER STATUS', Position, 1)
+
+--let $assert_text = Nothing was written to the binlog by adding a PFS table
+--let $assert_cond = $before = $after
+--source include/assert.inc
+
+--echo # Must not crash
+--source include/restart_mysqld.inc
+SELECT "it's alive";
+
+--let $beforeu=query_get_value('SHOW MASTER STATUS', Position, 1)
+UNINSTALL COMPONENT "file://component_pfs_example_component_population";
+--let $afteru=query_get_value('SHOW MASTER STATUS', Position, 1)
+
+--let $assert_text = Nothing was written to the binlog by removing a PFS table
+--let $assert_cond = $beforeu = $afteru
+--source include/assert.inc
+
+--echo # End of 8.0 tests

Diff for: sql/dd/impl/dictionary_impl.cc

@@ -561,7 +561,8 @@ bool create_native_table(THD *thd, const Plugin_table *pt) {
   /*
     1. Mark that we are executing a special DDL during
     plugin initialization. This will enable DDL to not be
-    committed. The called of this API would commit the transaction.
+    committed or binlogged. The called of this API would commit
+    the transaction.
 
     2. Remove metadata of native table if already exists. This could
     happen if server was crashed and restarted.
@@ -578,16 +579,19 @@ bool create_native_table(THD *thd, const Plugin_table *pt) {
   thd->mark_plugin_fake_ddl(true);
   ulong master_access = thd->security_context()->master_access();
   thd->security_context()->set_master_access(~(ulong)0);
+  {
+    Disable_binlog_guard guard(thd);
+
+    // Drop the table and related dynamic statistics too.
+    if (table_def) {
+      error =
+          client->drop(table_def) || client->remove_table_dynamic_statistics(
+                                         pt->get_schema_name(), pt->get_name());
+    }
 
-  // Drop the table and related dynamic statistics too.
-  if (table_def) {
-    error =
-        client->drop(table_def) || client->remove_table_dynamic_statistics(
-                                       pt->get_schema_name(), pt->get_name());
+    if (!error) error = dd::execute_query(thd, pt->get_ddl());
   }
 
-  if (!error) error = dd::execute_query(thd, pt->get_ddl());
-
   thd->security_context()->set_master_access(master_access);
   thd->mark_plugin_fake_ddl(false);