Bug #26271244

ASSERT FAILS WHEN SHOW CREATE TABLE CALLED ON A FILE CREATED FOR FULLTEXT INDEX

Author: jensevenb

mysql-test/include/commit.inc

@@ -823,7 +823,7 @@ create table t2 (a int);
 if (`SELECT $PS_PROTOCOL = 0`)
 {
   --replace_regex /(call p_verify_status_increment.*)11(.*6)/\1<commit_count>\2/
-  call p_verify_status_increment(11, 4, 6, 0);
+  call p_verify_status_increment(12, 4, 6, 0);
 }
 if (`SELECT $PS_PROTOCOL > 0`)
 {
@@ -883,7 +883,7 @@ create table t3 select a from t2;
 if (`SELECT $PS_PROTOCOL = 0`)
 {
  --replace_regex /12/<commit_count>/
-  call p_verify_status_increment(12, 4, 4, 4);
+  call p_verify_status_increment(13, 4, 4, 4);
 }
 if (`SELECT $PS_PROTOCOL > 0`)
 {
@@ -907,7 +907,7 @@ if ($have_debug)
 alter table t3 rename t4;
 call p_verify_status_increment(20, 4, 3, 0);
 rename table t4 to t3;
-call p_verify_status_increment(23, 4, 5, 0);
+call p_verify_status_increment(24, 4, 5, 0);
 truncate table t3;
 
 if (!$have_debug)
@@ -923,7 +923,7 @@ if ($have_debug)
 }
 
 create view v1 as select * from t2;
-call p_verify_status_increment(7, 4, 3, 0);
+call p_verify_status_increment(8, 4, 3, 0);
 check table t1;
 call p_verify_status_increment(2, 0, 2, 0);
 --echo # Sic: after this bug is fixed, CHECK leaves no pending transaction

mysql-test/r/commit_1innodb.result

@@ -799,7 +799,7 @@ SUCCESS
 # 28. Read-write statement: DO
 #
 create table t2 (a int);
-call p_verify_status_increment(<commit_count>, 4, 6, 0);
+call p_verify_status_increment(12, 4, 6, 0);
 SUCCESS
 
 # One extra transaction to load table 't2' into data-dictionary cache.
@@ -843,7 +843,7 @@ call p_verify_status_increment(0, 0, 0, 0);
 SUCCESS
 
 create table t3 select a from t2;
-call p_verify_status_increment(<commit_count>, 4, 4, 4);
+call p_verify_status_increment(13, 4, 4, 4);
 SUCCESS
 
 alter table t3 add column (b int);
@@ -855,15 +855,15 @@ call p_verify_status_increment(20, 4, 3, 0);
 SUCCESS
 
 rename table t4 to t3;
-call p_verify_status_increment(23, 4, 5, 0);
+call p_verify_status_increment(24, 4, 5, 0);
 SUCCESS
 
 truncate table t3;
 call p_verify_status_increment(X, 4, 4, 0);
 SUCCESS
 
 create view v1 as select * from t2;
-call p_verify_status_increment(7, 4, 3, 0);
+call p_verify_status_increment(8, 4, 3, 0);
 SUCCESS
 
 check table t1;

mysql-test/r/create.result

@@ -939,7 +939,7 @@ create table t2 select sql_big_result f1,count(f2) from t1 group by f1;
 show status like 'handler_read%';
 Variable_name	Value
 Handler_read_first	1
-Handler_read_key	23
+Handler_read_key	24
 Handler_read_last	0
 Handler_read_next	0
 Handler_read_prev	0

mysql-test/r/fulltext.result

@@ -738,3 +738,23 @@ explain format=json SELECT 1 FROM q
 WHERE (SELECT MATCH(b) AGAINST ('*') FROM z);
 ERROR HY000: Incorrect arguments to MATCH
 DROP TABLE z, q;
+#
+# Bug#26271244: ASSERT FAILS WHEN SHOW CREATE TABLE CALLED ON A FILE
+# CREATED FOR FULLTEXT INDEX
+#
+# Create Innodb table with full text index
+CREATE TABLE t1(id INT, c CHAR(100) , FULLTEXT KEY `msg_idx` (`c`))
+ENGINE INNODB;
+# Find name of first FTS index "table"
+# SHOW CREATE TABLE on an FTS index table should give error
+# (not crash). Query log and error message suppressed as the name of
+# FTS index table is not stable.
+Got one of the listed errors
+# Msg_type Error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+# Msg_type Error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+Got one of the listed errors
+Got one of the listed errors
+Got one of the listed errors
+Got one of the listed errors
+Got one of the listed errors
+DROP TABLE t1;

mysql-test/r/group_min_max.result

@@ -2515,7 +2515,7 @@ FLUSH STATUS;
 CREATE TABLE t2 SELECT max(b), a FROM t1 GROUP BY a;
 SHOW STATUS LIKE 'handler_read__e%';
 Variable_name	Value
-Handler_read_key	23
+Handler_read_key	24
 Handler_read_next	2
 FLUSH STATUS;
 SELECT * FROM (SELECT max(b), a FROM t1 GROUP BY a) b;

mysql-test/t/fulltext.test

@@ -660,3 +660,71 @@ WHERE (SELECT MATCH(b) AGAINST ('*') FROM z);
 eval explain format=json $query;
 
 DROP TABLE z, q;
+
+--echo #
+--echo # Bug#26271244: ASSERT FAILS WHEN SHOW CREATE TABLE CALLED ON A FILE
+--echo # CREATED FOR FULLTEXT INDEX
+--echo #
+
+let DATADIR= `SELECT @@datadir`;
+
+--echo # Create Innodb table with full text index
+CREATE TABLE t1(id INT, c CHAR(100) , FULLTEXT KEY `msg_idx` (`c`))
+ENGINE INNODB;
+--echo # Find name of first FTS index "table"
+let INCFILE= $MYSQL_TMP_DIR/tmp.inc;
+--perl
+  my $FTS_FILE= "";
+  opendir(DD, "$ENV{'DATADIR'}/test") || die "Could not open $ENV{'DATADIR'}: $!";
+  while ($_= readdir(DD)) {
+    if (/(fts_\S+_index_1)\.ibd/) {
+      $FTS_FILE= $1;
+      last;
+    }
+  }
+  close(DD);
+  open(INC, ">$ENV{'INCFILE'}") || die "Could not open $ENV{'INCFILE'}: $!";
+  print INC "let FTS_FILE= $FTS_FILE;\n";
+  close(INC);
+EOF
+--source $INCFILE
+
+--echo # SHOW CREATE TABLE on an FTS index table should give error
+--echo # (not crash). Query log and error message suppressed as the name of
+--echo # FTS index table is not stable.
+--disable_query_log
+
+--error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+--eval SHOW CREATE TABLE $FTS_FILE
+
+--disable_result_log
+--echo # Msg_type Error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+--eval OPTIMIZE TABLE $FTS_FILE
+
+--echo # Msg_type Error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+--eval REPAIR TABLE $FTS_FILE
+
+--error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+--eval ALTER TABLE $FTS_FILE DROP id
+
+--enable_result_log
+
+--error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+--eval LOCK TABLE $FTS_FILE AS mytable WRITE
+--eval UNLOCK TABLES
+
+--error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+--eval RENAME TABLE $FTS_FILE TO SOMETHING_ELSE
+
+--error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+--eval RENAME TABLE t2 TO t3, $FTS_FILE TO SOMETHING_ELSE2
+
+--error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+--eval TRUNCATE TABLE $FTS_FILE
+
+--error ER_NO_SUCH_TABLE,ER_NO_SUCH_TABLE
+--eval DROP TABLE $FTS_FILE
+
+--enable_query_log
+
+DROP TABLE t1;

sql/sql_base.cc

@@ -3566,6 +3566,12 @@ bool open_table(THD *thd, TABLE_LIST *table_list, Open_table_context *ot_ctx)
       goto err_lock;
     }
 
+    if (table_def && table_def->hidden() == dd::Abstract_table::HT_HIDDEN_SE)
+    {
+      my_error(ER_NO_SUCH_TABLE, MYF(0), table_list->db,
+               table_list->table_name);
+      DBUG_RETURN(true);
+    }
 
     /* make a new table */
     if (!(table= (TABLE*) my_malloc(key_memory_TABLE,
@@ -6196,8 +6202,36 @@ lock_table_names(THD *thd,
     dictionary to get hold of the tablespace name, and in order
     to do this, we must have acquired a lock on the table.
   */
-  return get_and_lock_tablespace_names(
-           thd, tables_start, tables_end, lock_wait_timeout, flags);
+  if (get_and_lock_tablespace_names(
+    thd, tables_start, tables_end, lock_wait_timeout, flags))
+    return true;
+
+  const dd::Table *table_def= nullptr;
+  for (table= tables_start; table && table != tables_end;
+       table= table->next_local)
+  {
+    if (table->table_name == NULL)
+      continue;
+
+    if (!thd->mdl_context.owns_equal_or_stronger_lock(MDL_key::TABLE, table->db,
+                                                      table->table_name,
+                                                      MDL_INTENTION_EXCLUSIVE))
+      continue;
+
+    dd::cache::Dictionary_client::Auto_releaser releaser(thd->dd_client());
+    if (thd->dd_client()->acquire(table->db,
+                                  table->table_name, &table_def))
+    {
+      return true;
+    }
+    if (table_def && table_def->hidden() == dd::Abstract_table::HT_HIDDEN_SE)
+    {
+      my_error(ER_NO_SUCH_TABLE, MYF(0),
+               table->db, table->table_name);
+      return true;
+    }
+  }
+  return false;
 }
 
 

sql/sql_rename.cc

@@ -181,7 +181,6 @@ bool mysql_rename_tables(THD *thd, TABLE_LIST *table_list)
   for (ren_table= table_list; ren_table; ren_table= ren_table->next_local)
     tdc_remove_table(thd, TDC_RT_REMOVE_ALL, ren_table->db,
                      ren_table->table_name, FALSE);
-
   bool error= false;
   bool int_commit_done= false;
   std::set<handlerton*> post_ddl_htons;

sql/sql_table.cc

@@ -2504,6 +2504,14 @@ drop_base_table(THD *thd, const Drop_tables_ctx &drop_ctx,
     return true;
   DBUG_ASSERT(table_def != nullptr);
 
+  if (table_def && table_def->hidden() == dd::Abstract_table::HT_HIDDEN_SE)
+  {
+    my_error(ER_NO_SUCH_TABLE, MYF(0), table->db,
+             table->table_name);
+    DBUG_ASSERT(true);
+    return true;
+  }
+
   handlerton *hton;
   if (dd::table_storage_engine(thd, table_def, &hton))
   {