WL#13926 Periodic synchronization with storage device for select into outfile/dumpfile controlled by system variables.

The patch implements periodic synchronization with storage device
for select into outfile/dumfile controlled by system variables.
    Based on the contribution provided by Facebook.

    Added system variables:

      select_into_buffer_size        Buffer size for SELECT INTO OUTFILE/DUMPFILE.
      select_into_disk_sync          Synchronize flushed buffer with disk for SELECT INTO OUTFILE/DUMPFILE.
      select_into_disk_sync_delay    The delay in milliseconds after each buffer sync
                                     for SELECT INTO OUTFILE/DUMPFILE. Requires select_into_sync_disk = ON.

    Added fields into IO_CACHE struct

      bool disk_sync{false};        // Synchronize flushed buffer with disk.
      uint disk_sync_delay{0};      // Delay after disk synchronization of the flushed buffer.
                                            // Requirew disk_sync = true.

    Function my_b_flush_io_cache() is modified so that
    it performs synchronization with storage device after buffer flushing
    if 'select_into_disk_sync' variable is set ON and optionally delay
    after synchronization if 'select_into_disk_sync_delay' variable
    is non-zero.

    Function query_result.cc, create_file() is modified to
    use 'select_into_buffer_size' value for the buffer size for
    'select into' command. Variables IO_CACHE::disk_sync,
    IO_CACHE::disc_sync_delay fields are set to
    the system variable values(select_into_disk_sync,
    select_into_disk_sync_delay).

Reviewed-by: Tor Didriksen <tor.didriksen@oracle.com>
Change-Id: I8e8c7031891a349b9c8c2dd42c8628c5ba568c8a

Author: Sergey Glukhov

include/my_sys.h

@@ -456,6 +456,11 @@ struct IO_CACHE /* Used when cacheing files */
   Stream_cipher *m_encryptor = nullptr;
   // This is a decryptor for decrypting the temporary file of the IO cache.
   Stream_cipher *m_decryptor = nullptr;
+  // Synchronize flushed buffer with disk.
+  bool disk_sync{false};
+  // Delay in milliseconds after disk synchronization of the flushed buffer.
+  // Requires disk_sync = true.
+  uint disk_sync_delay{0};
 };
 
 typedef int (*qsort2_cmp)(const void *, const void *, const void *);

mysql-test/include/outfile_fsync.inc

@@ -0,0 +1 @@
+eval select "Outfile OK" into outfile "$MYSQLTEST_VARDIR/tmp/outfile.test";

mysql-test/r/all_persisted_variables.result

@@ -38,17 +38,17 @@ include/assert.inc [Expect 500+ variables in the table. Due to open Bugs, we are
 
 # Test SET PERSIST
 
-include/assert.inc [Expect 403 persisted variables in the table.]
+include/assert.inc [Expect 406 persisted variables in the table.]
 
 ************************************************************
 * 3. Restart server, it must preserve the persisted variable
 *    settings. Verify persisted configuration.
 ************************************************************
 # restart
 
-include/assert.inc [Expect 403 persisted variables in persisted_variables table.]
-include/assert.inc [Expect 403 persisted variables shown as PERSISTED in variables_info table.]
-include/assert.inc [Expect 403 persisted variables with matching peristed and global values.]
+include/assert.inc [Expect 406 persisted variables in persisted_variables table.]
+include/assert.inc [Expect 406 persisted variables shown as PERSISTED in variables_info table.]
+include/assert.inc [Expect 406 persisted variables with matching peristed and global values.]
 
 ************************************************************
 * 4. Test RESET PERSIST IF EXISTS. Verify persisted variable

mysql-test/r/mysqld--help-notwin.result

@@ -1162,6 +1162,15 @@ The following options may be given as the first argument:
  --secure-file-priv=name 
  Limit LOAD DATA, SELECT ... OUTFILE, and LOAD_FILE() to
  files within specified directory
+ --select-into-buffer-size[=#] 
+ Buffer size for SELECT INTO OUTFILE/DUMPFILE.
+ --select-into-disk-sync 
+ Synchronize flushed buffer with disk for SELECT INTO
+ OUTFILE/DUMPFILE.
+ --select-into-disk-sync-delay[=#] 
+ The delay in milliseconds after each buffer sync for
+ SELECT INTO OUTFILE/DUMPFILE. Requires
+ select_into_sync_disk = ON.
  --server-id=#       Uniquely identifies the server instance in the community
  of replication partners
  --server-id-bits=#  Set number of significant bits in server-id
@@ -1732,6 +1741,9 @@ rpl-stop-slave-timeout 31536000
 safe-user-create FALSE
 schema-definition-cache 256
 secondary-engine-cost-threshold 100000
+select-into-buffer-size 131072
+select-into-disk-sync FALSE
+select-into-disk-sync-delay 0
 server-id 1
 server-id-bits 32
 session-track-gtids OFF

mysql-test/r/mysqld--help-win.result

@@ -1165,6 +1165,15 @@ The following options may be given as the first argument:
  --secure-file-priv=name 
  Limit LOAD DATA, SELECT ... OUTFILE, and LOAD_FILE() to
  files within specified directory
+ --select-into-buffer-size[=#] 
+ Buffer size for SELECT INTO OUTFILE/DUMPFILE.
+ --select-into-disk-sync 
+ Synchronize flushed buffer with disk for SELECT INTO
+ OUTFILE/DUMPFILE.
+ --select-into-disk-sync-delay[=#] 
+ The delay in milliseconds after each buffer sync for
+ SELECT INTO OUTFILE/DUMPFILE. Requires
+ select_into_sync_disk = ON.
  --server-id=#       Uniquely identifies the server instance in the community
  of replication partners
  --server-id-bits=#  Set number of significant bits in server-id
@@ -1744,6 +1753,9 @@ rpl-stop-slave-timeout 31536000
 safe-user-create FALSE
 schema-definition-cache 256
 secondary-engine-cost-threshold 100000
+select-into-buffer-size 131072
+select-into-disk-sync FALSE
+select-into-disk-sync-delay 0
 server-id 1
 server-id-bits 32
 session-track-gtids OFF

mysql-test/r/outfile_fsync_debug.result

@@ -0,0 +1,18 @@
+# restart
+SET SESSION select_into_buffer_size=262144;
+CREATE TABLE t1 (a TEXT, b TEXT) ENGINE=INNODB;
+CREATE TABLE t2 (a TEXT, b TEXT) ENGINE=INNODB;
+include/diff_tables.inc [test.t1, test.t2]
+ERROR HY000: Query execution was interrupted, maximum statement execution time exceeded
+include/assert_grep.inc [Found expected number of select_to_file]
+include/assert_grep.inc [Found expected number of select_to_file]
+include/assert_grep.inc [Found expected number of select_to_file]
+SET GLOBAL debug = '-d,print_select_into_flush_stats';
+SELECT /*+ SET_VAR(select_into_disk_sync_delay = 5000) 
+SET_VAR(select_into_disk_sync = ON)
+SET_VAR(select_into_buffer_size = 16384) */
+@@select_into_disk_sync_delay, @@select_into_disk_sync, @@select_into_buffer_size;
+@@select_into_disk_sync_delay	@@select_into_disk_sync	@@select_into_buffer_size
+5000	1	16384
+SET SESSION select_into_buffer_size=default;
+DROP TABLE t1, t2;

mysql-test/suite/sys_vars/r/all_vars.result

@@ -53,6 +53,12 @@ regexp_stack_limit
 regexp_time_limit
 regexp_time_limit
 resultset_metadata
+select_into_buffer_size
+select_into_buffer_size
+select_into_disk_sync
+select_into_disk_sync
+select_into_disk_sync_delay
+select_into_disk_sync_delay
 sql_require_primary_key
 sql_require_primary_key
 temptable_use_mmap

mysql-test/suite/sys_vars/r/select_into_buffer_size.result

@@ -0,0 +1,189 @@
+SET @start_global_value = @@global.select_into_buffer_size;
+SELECT @start_global_value;
+@start_global_value
+131072
+SET @start_session_value = @@session.select_into_buffer_size;
+SELECT @start_session_value;
+@start_session_value
+131072
+'#--------------------FN_DYNVARS_002_01-------------------------#'
+SET @@global.select_into_buffer_size = 1024;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '1024'
+SET @@global.select_into_buffer_size = DEFAULT;
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+131072
+SET @@session.select_into_buffer_size = 2048;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '2048'
+SET @@session.select_into_buffer_size = DEFAULT;
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+131072
+'#--------------------FN_DYNVARS_002_02-------------------------#'
+SET @@global.select_into_buffer_size = @start_global_value;
+SELECT @@global.select_into_buffer_size = 4096;
+@@global.select_into_buffer_size = 4096
+0
+SET @@session.select_into_buffer_size = @start_session_value;
+SELECT @@session.select_into_buffer_size = 2048;
+@@session.select_into_buffer_size = 2048
+0
+'#--------------------FN_DYNVARS_002_03-------------------------#'
+SET @@global.select_into_buffer_size = 16384;
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+16384
+SET @@global.select_into_buffer_size = 4096;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '4096'
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+8192
+SET @@global.select_into_buffer_size = 8192;
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+8192
+'#--------------------FN_DYNVARS_002_04-------------------------#'
+SET @@session.select_into_buffer_size = 4096;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '4096'
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+8192
+SET @@session.select_into_buffer_size = 8192;
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+8192
+SET @@session.select_into_buffer_size = 16384;
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+16384
+'#------------------FN_DYNVARS_002_05-----------------------#'
+SET @@global.select_into_buffer_size = -1;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '-1'
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+8192
+SET @@global.select_into_buffer_size = -1024;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '-1024'
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+8192
+SET @@global.select_into_buffer_size = 13;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '13'
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+8192
+SET @@global.select_into_buffer_size = ON;
+ERROR 42000: Incorrect argument type to variable 'select_into_buffer_size'
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+8192
+SET @@global.select_into_buffer_size = OFF;
+ERROR 42000: Incorrect argument type to variable 'select_into_buffer_size'
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+8192
+SET @@global.select_into_buffer_size = test;
+ERROR 42000: Incorrect argument type to variable 'select_into_buffer_size'
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+8192
+SET @@session.select_into_buffer_size = 23;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '23'
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+8192
+SET @@session.select_into_buffer_size = -2;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '-2'
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+8192
+SET @@session.select_into_buffer_size = 65550;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '65550'
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+65536
+SET @@session.select_into_buffer_size = ON;
+ERROR 42000: Incorrect argument type to variable 'select_into_buffer_size'
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+65536
+SET @@session.select_into_buffer_size = OFF;
+ERROR 42000: Incorrect argument type to variable 'select_into_buffer_size'
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+65536
+SET @@session.select_into_buffer_size = test;
+ERROR 42000: Incorrect argument type to variable 'select_into_buffer_size'
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+65536
+'#------------------FN_DYNVARS_002_06-----------------------#'
+SELECT @@global.select_into_buffer_size = VARIABLE_VALUE 
+FROM performance_schema.global_variables 
+WHERE VARIABLE_NAME='select_into_buffer_size';
+@@global.select_into_buffer_size = VARIABLE_VALUE
+1
+'#------------------FN_DYNVARS_002_07-----------------------#'
+SELECT @@session.select_into_buffer_size = VARIABLE_VALUE 
+FROM performance_schema.session_variables 
+WHERE VARIABLE_NAME='select_into_buffer_size';
+@@session.select_into_buffer_size = VARIABLE_VALUE
+1
+'#------------------FN_DYNVARS_002_08-----------------------#'
+SET @@global.select_into_buffer_size = TRUE;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '1'
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+8192
+SET @@global.select_into_buffer_size = FALSE;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '0'
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+8192
+'#---------------------FN_DYNVARS_001_09----------------------#'
+SET @@global.select_into_buffer_size = 16384;
+SET @@session.select_into_buffer_size = 8192;
+SELECT @@select_into_buffer_size = @@global.select_into_buffer_size;
+@@select_into_buffer_size = @@global.select_into_buffer_size
+0
+'#---------------------FN_DYNVARS_001_10----------------------#'
+SET @@select_into_buffer_size = 16384;
+SELECT @@select_into_buffer_size = @@local.select_into_buffer_size;
+@@select_into_buffer_size = @@local.select_into_buffer_size
+1
+SELECT @@local.select_into_buffer_size = @@session.select_into_buffer_size;
+@@local.select_into_buffer_size = @@session.select_into_buffer_size
+1
+'#---------------------FN_DYNVARS_001_11----------------------#'
+SET select_into_buffer_size = 1024;
+Warnings:
+Warning	1292	Truncated incorrect select_into_buffer_size value: '1024'
+SELECT @@select_into_buffer_size;
+@@select_into_buffer_size
+8192
+SELECT local.select_into_buffer_size;
+ERROR 42S02: Unknown table 'local' in field list
+SELECT session.select_into_buffer_size;
+ERROR 42S02: Unknown table 'session' in field list
+SELECT select_into_buffer_size = @@session.select_into_buffer_size;
+ERROR 42S22: Unknown column 'select_into_buffer_size' in 'field list'
+SET @@global.select_into_buffer_size = @start_global_value;
+SELECT @@global.select_into_buffer_size;
+@@global.select_into_buffer_size
+131072
+SET @@session.select_into_buffer_size = @start_session_value;
+SELECT @@session.select_into_buffer_size;
+@@session.select_into_buffer_size
+131072