BUG#33213841: MySQL crashes while executing RESET REPLICA ALL

When the replica SQL mode includes the mode 'PAD_CHAR_TO_FULL_LENGTH',
the channel name can be read from the repository with trailing spaces
what can lead to errors in operations that use that name to identify
the channel.

To solve this issue all CHAR columns in replication repository tables
will be converted to VARCHAR making the table behavior always the same
despite what the server SQL mode is.

Merge branch 'mysql-5.7' into mysql-8.0 with a different patch

ReviewBoard: 27008
ReviewBoard: 27047

Author: pedrolgomes

mysql-test/r/mysql_upgrade_slave_master_info.result

@@ -41,7 +41,7 @@ CREATE TABLE `mysql`.`slave_master_info` (
 `Number_of_lines` int(10) unsigned NOT NULL COMMENT 'Number of lines in the file.',
 `Master_log_name` text CHARACTER SET utf8 COLLATE utf8_bin NOT NULL COMMENT 'The name of the master binary log currently being read from the master.',
 `Master_log_pos` bigint(20) unsigned NOT NULL COMMENT 'The master log position of the last read event.',
-`Host` char(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '' COMMENT 'The host name of the master.',
+`Host` varchar(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '' COMMENT 'The host name of the source.',
 `User_name` text CHARACTER SET utf8 COLLATE utf8_bin COMMENT 'The user name used to connect to the master.',
 `User_password` text CHARACTER SET utf8 COLLATE utf8_bin COMMENT 'The password used to connect to the master.',
 `Port` int(10) unsigned NOT NULL COMMENT 'The network port used to connect to the master.',
@@ -113,7 +113,7 @@ DROP TABLE test.upgraded;
 TRUNCATE TABLE mysql.slave_master_info;
 INSERT INTO mysql.slave_master_info SELECT * FROM test.slave_master_info_backup;
 ALTER TABLE mysql.slave_master_info
-MODIFY Host CHAR(255) CHARACTER SET ASCII NULL COMMENT 'The host name of the master.',
+MODIFY Host VARCHAR(255) CHARACTER SET ASCII NULL COMMENT 'The host name of the source.',
 ALTER COLUMN Channel_name DROP DEFAULT;
 DROP TABLE test.slave_master_info_backup;
 DROP TABLE test.original;

mysql-test/r/mysqldump.result

@@ -5299,7 +5299,7 @@ CREATE TABLE IF NOT EXISTS `slave_master_info` (
   `Number_of_lines` int unsigned NOT NULL COMMENT 'Number of lines in the file.',
   `Master_log_name` text CHARACTER SET utf8 COLLATE utf8_bin NOT NULL COMMENT 'The name of the master binary log currently being read from the master.',
   `Master_log_pos` bigint unsigned NOT NULL COMMENT 'The master log position of the last read event.',
-  `Host` char(255) CHARACTER SET ascii COLLATE ascii_general_ci DEFAULT NULL COMMENT 'The host name of the master.',
+  `Host` varchar(255) CHARACTER SET ascii COLLATE ascii_general_ci DEFAULT NULL COMMENT 'The host name of the source.',
   `User_name` text CHARACTER SET utf8 COLLATE utf8_bin COMMENT 'The user name used to connect to the master.',
   `User_password` text CHARACTER SET utf8 COLLATE utf8_bin COMMENT 'The password used to connect to the master.',
   `Port` int unsigned NOT NULL COMMENT 'The network port used to connect to the master.',
@@ -5319,12 +5319,12 @@ CREATE TABLE IF NOT EXISTS `slave_master_info` (
   `Ssl_crl` text CHARACTER SET utf8 COLLATE utf8_bin COMMENT 'The file used for the Certificate Revocation List (CRL)',
   `Ssl_crlpath` text CHARACTER SET utf8 COLLATE utf8_bin COMMENT 'The path used for Certificate Revocation List (CRL) files',
   `Enabled_auto_position` tinyint(1) NOT NULL COMMENT 'Indicates whether GTIDs will be used to retrieve events from the master.',
-  `Channel_name` char(64) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL COMMENT 'The channel on which the slave is connected to a source. Used in Multisource Replication',
+  `Channel_name` varchar(64) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL COMMENT 'The channel on which the replica is connected to a source. Used in Multisource Replication',
   `Tls_version` text CHARACTER SET utf8 COLLATE utf8_bin COMMENT 'Tls version',
   `Public_key_path` text CHARACTER SET utf8 COLLATE utf8_bin COMMENT 'The file containing public key of master server.',
   `Get_public_key` tinyint(1) NOT NULL COMMENT 'Preference to get public key from master.',
   `Network_namespace` text CHARACTER SET utf8 COLLATE utf8_bin COMMENT 'Network namespace used for communication with the master server.',
-  `Master_compression_algorithm` char(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL COMMENT 'Compression algorithm supported for data transfer between master and slave.',
+  `Master_compression_algorithm` varchar(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL COMMENT 'Compression algorithm supported for data transfer between source and replica.',
   `Master_zstd_compression_level` int unsigned NOT NULL COMMENT 'Compression level associated with zstd compression algorithm.',
   `Tls_ciphersuites` text CHARACTER SET utf8 COLLATE utf8_bin COMMENT 'Ciphersuites used for TLS 1.3 communication with the master server.',
   `Source_connection_auto_failover` tinyint(1) NOT NULL DEFAULT '0' COMMENT 'Indicates whether the channel connection failover is enabled.',
@@ -5343,9 +5343,9 @@ CREATE TABLE IF NOT EXISTS `slave_relay_log_info` (
   `Sql_delay` int DEFAULT NULL COMMENT 'The number of seconds that the slave must lag behind the master.',
   `Number_of_workers` int unsigned DEFAULT NULL,
   `Id` int unsigned DEFAULT NULL COMMENT 'Internal Id that uniquely identifies this record.',
-  `Channel_name` char(64) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL COMMENT 'The channel on which the slave is connected to a source. Used in Multisource Replication',
-  `Privilege_checks_username` char(32) CHARACTER SET utf8 COLLATE utf8_bin DEFAULT NULL COMMENT 'Username part of PRIVILEGE_CHECKS_USER.',
-  `Privilege_checks_hostname` char(255) CHARACTER SET ascii COLLATE ascii_general_ci DEFAULT NULL COMMENT 'Hostname part of PRIVILEGE_CHECKS_USER.',
+  `Channel_name` varchar(64) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL COMMENT 'The channel on which the replica is connected to a source. Used in Multisource Replication',
+  `Privilege_checks_username` varchar(32) CHARACTER SET utf8 COLLATE utf8_bin DEFAULT NULL COMMENT 'Username part of PRIVILEGE_CHECKS_USER.',
+  `Privilege_checks_hostname` varchar(255) CHARACTER SET ascii COLLATE ascii_general_ci DEFAULT NULL COMMENT 'Hostname part of PRIVILEGE_CHECKS_USER.',
   `Require_row_format` tinyint(1) NOT NULL COMMENT 'Indicates whether the channel shall only accept row based events.',
   `Require_table_primary_key_check` enum('STREAM','ON','OFF') NOT NULL DEFAULT 'STREAM' COMMENT 'Indicates what is the channel policy regarding tables having primary keys on create and alter table queries',
   `Assign_gtids_to_anonymous_transactions_type` enum('OFF','LOCAL','UUID') NOT NULL DEFAULT 'OFF' COMMENT 'Indicates whether the channel will generate a new GTID for anonymous transactions. OFF means that anonymous transactions will remain anonymous. LOCAL means that anonymous transactions will be assigned a newly generated GTID based on server_uuid. UUID indicates that anonymous transactions will be assigned a newly generated GTID based on Assign_gtids_to_anonymous_transactions_value',

mysql-test/std_data/dd/sdi/innodb_sdi/mysql.json

@@ -37398,7 +37398,7 @@
             },
             {
                 "name": "Channel_name",
-                "type": 29,
+                "type": 16,
                 "is_nullable": false,
                 "is_zerofill": false,
                 "is_unsigned": false,
@@ -37421,22 +37421,22 @@
                 "default_value_utf8": "",
                 "default_option": "",
                 "update_option": "",
-                "comment": "The channel on which the slave is connected to a source. Used in Multisource Replication",
+                "comment": "The channel on which the replica is connected to a source. Used in Multisource Replication",
                 "generation_expression": "",
                 "generation_expression_utf8": "",
                 "options": "interval_count=0;",
                 "se_private_data": "table_id=X",
                 "engine_attribute": "",
                 "secondary_engine_attribute": "",
                 "column_key": 2,
-                "column_type_utf8": "char(64)",
+                "column_type_utf8": "varchar(64)",
                 "elements": [],
                 "collation_id": X,
                 "is_explicit_collation": true
             },
             {
                 "name": "Privilege_checks_username",
-                "type": 29,
+                "type": 16,
                 "is_nullable": true,
                 "is_zerofill": false,
                 "is_unsigned": false,
@@ -37467,14 +37467,14 @@
                 "engine_attribute": "",
                 "secondary_engine_attribute": "",
                 "column_key": 1,
-                "column_type_utf8": "char(32)",
+                "column_type_utf8": "varchar(32)",
                 "elements": [],
                 "collation_id": X,
                 "is_explicit_collation": true
             },
             {
                 "name": "Privilege_checks_hostname",
-                "type": 29,
+                "type": 16,
                 "is_nullable": true,
                 "is_zerofill": false,
                 "is_unsigned": false,
@@ -37505,7 +37505,7 @@
                 "engine_attribute": "",
                 "secondary_engine_attribute": "",
                 "column_key": 1,
-                "column_type_utf8": "char(255)",
+                "column_type_utf8": "varchar(255)",
                 "elements": [],
                 "collation_id": X,
                 "is_explicit_collation": true
@@ -38064,7 +38064,7 @@
             },
             {
                 "name": "Host",
-                "type": 29,
+                "type": 16,
                 "is_nullable": true,
                 "is_zerofill": false,
                 "is_unsigned": false,
@@ -38087,15 +38087,15 @@
                 "default_value_utf8": "",
                 "default_option": "",
                 "update_option": "",
-                "comment": "The host name of the master.",
+                "comment": "The host name of the source.",
                 "generation_expression": "",
                 "generation_expression_utf8": "",
                 "options": "interval_count=0;",
                 "se_private_data": "table_id=X",
                 "engine_attribute": "",
                 "secondary_engine_attribute": "",
                 "column_key": 1,
-                "column_type_utf8": "char(255)",
+                "column_type_utf8": "varchar(255)",
                 "elements": [],
                 "collation_id": X,
                 "is_explicit_collation": true
@@ -38824,7 +38824,7 @@
             },
             {
                 "name": "Channel_name",
-                "type": 29,
+                "type": 16,
                 "is_nullable": false,
                 "is_zerofill": false,
                 "is_unsigned": false,
@@ -38847,15 +38847,15 @@
                 "default_value_utf8": "",
                 "default_option": "",
                 "update_option": "",
-                "comment": "The channel on which the slave is connected to a source. Used in Multisource Replication",
+                "comment": "The channel on which the replica is connected to a source. Used in Multisource Replication",
                 "generation_expression": "",
                 "generation_expression_utf8": "",
                 "options": "interval_count=0;",
                 "se_private_data": "table_id=X",
                 "engine_attribute": "",
                 "secondary_engine_attribute": "",
                 "column_key": 2,
-                "column_type_utf8": "char(64)",
+                "column_type_utf8": "varchar(64)",
                 "elements": [],
                 "collation_id": X,
                 "is_explicit_collation": true
@@ -39014,7 +39014,7 @@
             },
             {
                 "name": "Master_compression_algorithm",
-                "type": 29,
+                "type": 16,
                 "is_nullable": false,
                 "is_zerofill": false,
                 "is_unsigned": false,
@@ -39037,15 +39037,15 @@
                 "default_value_utf8": "",
                 "default_option": "",
                 "update_option": "",
-                "comment": "Compression algorithm supported for data transfer between master and slave.",
+                "comment": "Compression algorithm supported for data transfer between source and replica.",
                 "generation_expression": "",
                 "generation_expression_utf8": "",
                 "options": "interval_count=0;",
                 "se_private_data": "table_id=X",
                 "engine_attribute": "",
                 "secondary_engine_attribute": "",
                 "column_key": 1,
-                "column_type_utf8": "char(64)",
+                "column_type_utf8": "varchar(64)",
                 "elements": [],
                 "collation_id": X,
                 "is_explicit_collation": true
@@ -40046,7 +40046,7 @@
             },
             {
                 "name": "Channel_name",
-                "type": 29,
+                "type": 16,
                 "is_nullable": false,
                 "is_zerofill": false,
                 "is_unsigned": false,
@@ -40069,15 +40069,15 @@
                 "default_value_utf8": "",
                 "default_option": "",
                 "update_option": "",
-                "comment": "The channel on which the slave is connected to a source. Used in Multisource Replication",
+                "comment": "The channel on which the replica is connected to a source. Used in Multisource Replication",
                 "generation_expression": "",
                 "generation_expression_utf8": "",
                 "options": "interval_count=0;",
                 "se_private_data": "table_id=X",
                 "engine_attribute": "",
                 "secondary_engine_attribute": "",
                 "column_key": 2,
-                "column_type_utf8": "char(64)",
+                "column_type_utf8": "varchar(64)",
                 "elements": [],
                 "collation_id": X,
                 "is_explicit_collation": true