Bug#37394850 Remove unused function recover_innodb_upon_upgrade

Post WL#15924 cleanup, method recover_innodb_upon_upgrade()
is no longer used. This patch removes this unused method.

Change-Id: Id53b4635391004bc0b6df18dd21a28396a5e47c8

Author: RahulSisondia

share/messages_to_error_log.txt

@@ -105,7 +105,7 @@ ER_RPL_GTID_TABLE_CANNOT_OPEN
 ER_SYSTEM_SCHEMA_NOT_FOUND
   eng "System schema directory does not exist."
 
-ER_DD_INIT_UPGRADE_FAILED
+OBSOLETE_ER_DD_INIT_UPGRADE_FAILED
   eng "Error in initializing dictionary, upgrade will do a cleanup and exit"
 
 ER_VIEW_UNKNOWN_CHARSET_OR_COLLATION

sql/dd/impl/bootstrap/bootstrapper.cc

@@ -968,30 +968,6 @@ bool restart_dictionary(THD *thd) {
   return false;
 }
 
-// Initialize dictionary in case of server restart.
-void recover_innodb_upon_upgrade(THD *thd) {
-  Dictionary_impl *d = dd::Dictionary_impl::instance();
-  store_predefined_tablespace_metadata(thd);
-  // RAII to handle error in execution of CREATE TABLE.
-  Key_length_error_handler key_error_handler;
-  /*
-    Ignore ER_TOO_LONG_KEY for dictionary tables during restart.
-    Do not print the error in error log as we are creating only the
-    cached objects and not physical tables.
-TODO: Workaround due to bug#20629014. Remove when the bug is fixed.
-   */
-  thd->push_internal_handler(&key_error_handler);
-  if (create_dd_schema(thd) || initialize_dd_properties(thd) ||
-      create_tables(thd, nullptr) ||
-      DDSE_dict_recover(thd, DICT_RECOVERY_RESTART_SERVER,
-                        d->get_actual_dd_version(thd))) {
-    // Error is not be handled in this case as we are on cleanup code path.
-    LogErr(WARNING_LEVEL, ER_DD_INIT_UPGRADE_FAILED);
-  }
-  thd->pop_internal_handler();
-  return;
-}
-
 bool setup_dd_objects_and_collations(THD *thd) {
   // Continue with server startup.
   bootstrap::DD_bootstrap_ctx::instance().set_stage(

sql/dd/impl/bootstrap/bootstrapper.h

@@ -233,16 +233,6 @@ bool store_plugin_IS_table_metadata(THD *thd);
 */
 bool setup_dd_objects_and_collations(THD *thd);
 
-/**
-  This function is used in case of crash during upgrade.
-  It tries to initialize dictionary and calls DDSE_dict_recover.
-  InnoDB should do the recovery and empty undo log. Upgrade
-  process will do the cleanup and exit.
-
-  @param thd    Thread context.
-*/
-void recover_innodb_upon_upgrade(THD *thd);
-
 /**
   Initialize InnoDB for
   - creating new data directory : InnoDB creates system tablespace and