Bug#37471922: Auto-fix clang-tidy warnings [15/n] [noclose]

Generate fixes for a number of warnings that clang-tidy can fix automatically.
This commit fixes the warning 'readability-qualified-auto'.

Change example:
 - auto descendentref = down_cast<Descendent *>(baseref);
 + auto *descendentref = down_cast<Descendent *>(baseref);

Change-Id: I4b329c2b6a9271b4b21588916396d483a1b87c64

Author: MRajcic

client/mysqltest.cc

@@ -2983,7 +2983,7 @@ static void var_set_escape(struct st_command *command, VAR *dst) {
     if (std::find(begin, end, c) != end) dst_len++;
   // Allocate space for escaped string
   alloc_var(dst, dst_len);
-  auto dst_char = dst->str_val;
+  auto *dst_char = dst->str_val;
   // Compute escaped string
   for (char c : src) {
     if (std::find(begin, end, c) != end) *dst_char++ = '\\';

client/pattern_matcher.cc

@@ -81,7 +81,7 @@ bool Pattern_matcher::is_matching(const std::string &text,
   DBUG_TRACE;
 
   // traverse all patterns, return true on first match
-  for (auto &pattern : m_patterns) {
+  for (const auto &pattern : m_patterns) {
     if (info->coll->wildcmp(info, text.c_str(), text.c_str() + text.length(),
                             pattern.c_str(), pattern.c_str() + pattern.length(),
                             WILD_ESCAPE, WILD_ONE, WILD_MANY) == 0) {

components/libminchassis/dynamic_loader.cc

@@ -1171,7 +1171,7 @@ bool mysql_dynamic_loader_imp::unload_do_lock_provided_services(
 
     if (pre_unload_notification.is_valid()) {
       std::vector<const char *> services;
-      for (auto &one : components_to_unload) {
+      for (const auto &one : components_to_unload) {
         for (const mysql_service_ref_t *service :
              one->get_provided_services()) {
           services.push_back(service->name);
@@ -1402,7 +1402,7 @@ bool mysql_dynamic_loader_imp::unload_do_unload_components(
        mysql_component pointers. */
     for (auto list = mysql_dynamic_loader_imp::urns_with_gen_list.begin();
          list != mysql_dynamic_loader_imp::urns_with_gen_list.end(); ++list) {
-      auto comp_ele = (*component_it).second.get();
+      auto *comp_ele = (*component_it).second.get();
       auto v_element =
           find_if((*list).begin(), (*list).end(),
                   [comp_ele](mysql_component *ptr) { return ptr == comp_ele; });

components/mysqlbackup/backup_page_tracker.cc

@@ -127,7 +127,7 @@ mysql_service_status_t Backup_page_tracker::register_udfs() {
   // Initialize the UDF list
   initialize_udf_list();
 
-  for (auto udf : m_udf_list) {
+  for (auto *udf : m_udf_list) {
     if (udf->m_is_registered) {
       std::string msg{udf->m_name + " is already registered."};
       LogErr(ERROR_LEVEL, ER_MYSQLBACKUP_MSG, msg.c_str());
@@ -163,7 +163,7 @@ mysql_service_status_t Backup_page_tracker::register_udfs() {
 mysql_service_status_t Backup_page_tracker::unregister_udfs() {
   mysql_service_status_t fail_status{0};
 
-  for (auto udf : m_udf_list) {
+  for (auto *udf : m_udf_list) {
     int was_present;
     if (mysql_service_udf_registration->udf_unregister(udf->m_name.c_str(),
                                                        &was_present) &&

components/test/event_tracking_test/event_tracking_test.cc

@@ -159,7 +159,7 @@ int main(int argc, char **argv) {
     deinit_registry();
   });
 
-  auto dynamic_loader = get_dynamic_loader();
+  auto *dynamic_loader = get_dynamic_loader();
 
   if (!dynamic_loader) {
     std::cerr << "Could not get handle of dynamic loader" << std::endl;

components/test/keyring_encryption_test/components.cc

@@ -122,8 +122,8 @@ Keyring_encryption_test::Keyring_encryption_test(
 bool Keyring_encryption_test::test_aes() {
   if (!ok_) return false;
 
-  const auto writer = aes_service_.writer();
-  const auto aes = aes_service_.aes();
+  const auto *const writer = aes_service_.writer();
+  const auto *const aes = aes_service_.aes();
 
   const std::string aes_key_1("AES_test_key_1");
   if (writer->store("aes_key_1", "keyring_aes_test",

components/test/statement_services/test_execute_prepared_statement.cc

@@ -105,7 +105,7 @@ static auto test_execute_prepared_statement(UDF_INIT *, UDF_ARGS *arguments,
                                             unsigned char *error) -> char * {
   *error = 1;
 
-  auto statement = my_h_statement{nullptr};
+  auto *statement = my_h_statement{nullptr};
   auto query =
       mysql_cstring_with_length{arguments->args[0], strlen(arguments->args[0])};
 
@@ -220,7 +220,7 @@ static auto test_execute_prepared_statement(UDF_INIT *, UDF_ARGS *arguments,
        arg_index++) {
     switch (arguments->arg_type[arg_index]) {
       case STRING_RESULT: {
-        auto value = arguments->args[arg_index];
+        auto *value = arguments->args[arg_index];
         if (SERVICE_PLACEHOLDER(mysql_stmt_bind)
                 ->bind_param(statement, param_index, false,
                              MYSQL_SP_ARG_TYPE_VARCHAR, false, value,
@@ -353,7 +353,7 @@ static auto test_execute_prepared_statement(UDF_INIT *, UDF_ARGS *arguments,
   }
 #endif
 
-  if (auto exec_result = execute_statement(statement, error, result, length);
+  if (auto *exec_result = execute_statement(statement, error, result, length);
       exec_result != nullptr) {
     return exec_result;
   }

components/test/statement_services/test_execute_regular_statement.cc

@@ -90,7 +90,7 @@ static auto test_execute_regular_statement(UDF_INIT *, UDF_ARGS *arguments,
                                            unsigned char *error) -> char * {
   *error = 1;
 
-  auto statement = my_h_statement{nullptr};
+  auto *statement = my_h_statement{nullptr};
   auto query =
       mysql_cstring_with_length{arguments->args[0], strlen(arguments->args[0])};
   if (SERVICE_PLACEHOLDER(mysql_stmt_factory)->init(&statement) != 0) return {};

components/test/statement_services/utils.cc

@@ -68,10 +68,10 @@ auto parse_headers(uint64_t num_fields, my_h_statement statement,
                    unsigned char *error) -> std::vector<std::string> {
   *error = 1;
   auto header_row = std::vector<std::string>{};
-  auto field = my_h_field{nullptr};
-  auto field_name = static_cast<char *>(nullptr);
-  auto charset_name = static_cast<char *>(nullptr);
-  auto collation_name = static_cast<char *>(nullptr);
+  auto *field = my_h_field{nullptr};
+  auto *field_name = static_cast<char *>(nullptr);
+  auto *charset_name = static_cast<char *>(nullptr);
+  auto *collation_name = static_cast<char *>(nullptr);
   for (auto j = size_t{}; j < num_fields; j++) {
     if (SERVICE_PLACEHOLDER(mysql_stmt_resultset_metadata)
             ->fetch_field(statement, j, &field) != 0)
@@ -94,7 +94,7 @@ auto parse_headers(uint64_t num_fields, my_h_statement statement,
 
 auto get_field_type(my_h_statement statement, size_t index,
                     unsigned char *error) -> uint64_t {
-  auto field = my_h_field{nullptr};
+  auto *field = my_h_field{nullptr};
   if (SERVICE_PLACEHOLDER(mysql_stmt_resultset_metadata)
           ->fetch_field(statement, index, &field) != 0) {
     *error = 1;
@@ -150,7 +150,7 @@ auto parse_value_at_index(uint64_t field_type, my_h_row row, size_t index)
 }
 
 auto fetch_statement_row(my_h_statement statement) -> std::optional<my_h_row> {
-  auto row = static_cast<my_h_row>(nullptr);
+  auto *row = static_cast<my_h_row>(nullptr);
   if (SERVICE_PLACEHOLDER(mysql_stmt_result)->fetch(statement, &row) != 0)
     return {};
   return row;

components/test/test_mysql_signal_handler.cc

@@ -65,7 +65,8 @@ static auto test_fatal_signal_callback(int signum,
     -> void {
   assert(signum == SIGSEGV);
   if (signum != SIGSEGV) return;
-  auto message = "Signal from the test_mysql_signal_handler component.\n";
+  const auto *message =
+      "Signal from the test_mysql_signal_handler component.\n";
   safe_write_stderr(message, strlen(message));
 }