Bug#37471922: Auto-fix clang-tidy warnings [57/n] [noclose]

Generate fixes for a number of warnings that clang-tidy can fix automatically.
This commit fixes the warning 'modernize-use-emplace'.

Change example:
 - registrations.push_back(Registration(callbacks, handle));
 + registrations.emplace_back(callbacks, handle);

Change-Id: I682ffa32530f08b0e4f25cc16cba9fd6b5517477

Author: MRajcic

client/check/mysqlcheck.cc

@@ -533,7 +533,7 @@ int main(int argc, char **argv) {
   // Sun Studio does not work with range constructor from char** to string.
   vector<string> conv;
   conv.reserve(argc);
-  for (int i = 0; i < argc; i++) conv.push_back(argv[i]);
+  for (int i = 0; i < argc; i++) conv.emplace_back(argv[i]);
 
   mysql_check(sock, what_to_do, opt_alldbs, opt_check_only_changed,
               opt_extended, opt_databases, opt_fast, opt_medium_check,

client/check/mysqlcheck_core.cc

@@ -172,7 +172,7 @@ static int process_all_tables_in_db(const string &database) {
     /* Skip views if we don't perform renaming. */
     if ((num_columns == 2) && (strcmp(row[1], "VIEW") == 0)) continue;
 
-    table_names.push_back(row[0]);
+    table_names.emplace_back(row[0]);
   }
   mysql_free_result(res);
 
@@ -294,7 +294,7 @@ static void print_result() {
           strcmp(row[3], "OK") != 0) {
         if (table_rebuild) {
           if (prev_alter[0])
-            alter_table_cmds.push_back(prev_alter);
+            alter_table_cmds.emplace_back(prev_alter);
           else
             tables4rebuild.push_back(escape_db_table_name(prev, dot_pos));
         } else {
@@ -346,7 +346,7 @@ static void print_result() {
   if (found_error && opt_auto_repair && what_to_do != DO_REPAIR) {
     if (table_rebuild) {
       if (prev_alter[0])
-        alter_table_cmds.push_back(prev_alter);
+        alter_table_cmds.emplace_back(prev_alter);
       else
         tables4rebuild.push_back(escape_db_table_name(prev, dot_pos));
     } else {

components/test/perfschema/test_pfs_notification.cc

@@ -484,7 +484,7 @@ bool test_pfs_notification() {
     if (handle == 0) {
       print_log("register_notification() failed");
     } else {
-      registrations.push_back(Registration(callbacks, handle));
+      registrations.emplace_back(callbacks, handle);
       ss << "register_notification " << handle;
       print_log(ss.str());
     }

components/test/test_mysql_thd_store_service.cc

@@ -41,14 +41,14 @@ namespace test_mysql_thd_store_service {
 class Test_mysql_thd_data final {
  public:
   Test_mysql_thd_data() {
-    vector_.push_back("Quick ");
-    vector_.push_back("Brown ");
-    vector_.push_back("Fox ");
-    vector_.push_back("Jumped ");
-    vector_.push_back("Over ");
-    vector_.push_back("The ");
-    vector_.push_back("Lazy ");
-    vector_.push_back("Dog.");
+    vector_.emplace_back("Quick ");
+    vector_.emplace_back("Brown ");
+    vector_.emplace_back("Fox ");
+    vector_.emplace_back("Jumped ");
+    vector_.emplace_back("Over ");
+    vector_.emplace_back("The ");
+    vector_.emplace_back("Lazy ");
+    vector_.emplace_back("Dog.");
   }
 
   bool sanity(const std::string &expected) {

plugin/group_replication/libmysqlgcs/src/bindings/xcom/gcs_message_stages.cc

@@ -263,7 +263,7 @@ std::pair<bool, Gcs_packet> Gcs_message_pipeline::create_packet(
 
   for (auto const &stage_code : stages_to_apply) {
     Gcs_message_stage &stage = *retrieve_stage(stage_code);
-    dynamic_headers.push_back(Gcs_dynamic_header(stage_code, 0));
+    dynamic_headers.emplace_back(stage_code, 0);
     stage_headers.push_back(stage.get_stage_header());
   }
 

plugin/group_replication/libmysqlgcs/src/bindings/xcom/gcs_xcom_communication_interface.cc

@@ -217,8 +217,7 @@ void Gcs_xcom_communication::buffer_incoming_packet(
 
   MYSQL_GCS_LOG_TRACE("Buffering packet cargo=%u", packet.get_cargo_type());
 
-  m_buffered_packets.push_back(
-      std::make_pair(std::move(packet), std::move(xcom_nodes)));
+  m_buffered_packets.emplace_back(std::move(packet), std::move(xcom_nodes));
 }
 
 void Gcs_xcom_communication::deliver_buffered_packets() {

plugin/group_replication/libmysqlgcs/src/bindings/xcom/gcs_xcom_networking.cc

@@ -331,7 +331,7 @@ bool resolve_all_ip_addr_from_hostname(
 
     if (!inet_ntop(sa->sa_family, in_addr, cip, cip_len)) goto end;
 
-    ips.push_back(std::make_pair(sa->sa_family, std::string(cip)));
+    ips.emplace_back(sa->sa_family, std::string(cip));
 
     addrinfo_list = addrinfo_list->ai_next;
   }

plugin/group_replication/src/sql_service/sql_resultset.cc

@@ -127,9 +127,7 @@ void Sql_resultset::clear() {
   m_killed = false;
 }
 
-void Sql_resultset::new_row() {
-  result_value.push_back(std::vector<Field_value *>());
-}
+void Sql_resultset::new_row() { result_value.emplace_back(); }
 
 void Sql_resultset::new_field(Field_value *val) {
   result_value[num_rows].push_back(val);

plugin/test_service_sql_api/test_sql_stmt.cc

@@ -317,7 +317,7 @@ static int handle_start_column_metadata(void *pctx, uint num_cols, uint,
   DBUG_PRINT("info", ("resultcs->csname: %s", resultcs->csname));
   DBUG_PRINT("info", ("resultcs->m_coll_name: %s", resultcs->m_coll_name));
 
-  ctx->tables.push_back(Table(num_cols, resultcs));
+  ctx->tables.emplace_back(num_cols, resultcs);
   ctx->current_col = 0;
 
   return false;
@@ -340,10 +340,10 @@ static int handle_send_column_metadata(void *pctx, struct st_send_field *field,
   DBUG_PRINT("info", ("field->decimals: %d", (int)field->decimals));
   DBUG_PRINT("info", ("field->type: %d", (int)field->type));
 
-  ctx->tables.back().columns.push_back(
-      Column(field->db_name, field->table_name, field->org_table_name,
-             field->col_name, field->org_col_name, field->length,
-             field->charsetnr, field->flags, field->decimals, field->type));
+  ctx->tables.back().columns.emplace_back(
+      field->db_name, field->table_name, field->org_table_name, field->col_name,
+      field->org_col_name, field->length, field->charsetnr, field->flags,
+      field->decimals, field->type);
   ctx->current_col++;
   return false;
 }
@@ -406,7 +406,7 @@ static int handle_store_null(void *pctx) {
   DBUG_TRACE;
   const uint col = ctx->current_col;
   ctx->current_col++;
-  ctx->tables.back().columns[col].row_values.push_back("[NULL]");
+  ctx->tables.back().columns[col].row_values.emplace_back("[NULL]");
 
   return false;
 }
@@ -420,8 +420,7 @@ static int handle_store_integer(void *pctx, longlong value) {
 
   const size_t len = snprintf(buffer, sizeof(buffer), "%lld", value);
 
-  ctx->tables.back().columns[col].row_values.push_back(
-      std::string(buffer, len));
+  ctx->tables.back().columns[col].row_values.emplace_back(buffer, len);
 
   return false;
 }
@@ -436,8 +435,7 @@ static int handle_store_longlong(void *pctx, longlong value, uint is_unsigned) {
   const size_t len =
       snprintf(buffer, sizeof(buffer), is_unsigned ? "%llu" : "%lld", value);
 
-  ctx->tables.back().columns[col].row_values.push_back(
-      std::string(buffer, len));
+  ctx->tables.back().columns[col].row_values.emplace_back(buffer, len);
 
   return false;
 }
@@ -458,8 +456,7 @@ static int handle_store_decimal(void *pctx, const decimal_t *value) {
 
   int len = SIZEOF_SQL_STR_VALUE;
   test_decimal_as_string(buffer, value, &len);
-  ctx->tables.back().columns[col].row_values.push_back(
-      std::string(buffer, len));
+  ctx->tables.back().columns[col].row_values.emplace_back(buffer, len);
 
   return false;
 }
@@ -472,8 +469,7 @@ static int handle_store_double(void *pctx, double value, uint32) {
   ctx->current_col++;
 
   const size_t len = snprintf(buffer, sizeof(buffer), "%3.7g", value);
-  ctx->tables.back().columns[col].row_values.push_back(
-      std::string(buffer, len));
+  ctx->tables.back().columns[col].row_values.emplace_back(buffer, len);
 
   return false;
 }
@@ -489,8 +485,7 @@ static int handle_store_date(void *pctx, const MYSQL_TIME *value) {
       snprintf(buffer, sizeof(buffer), "%s%4d-%02d-%02d", value->neg ? "-" : "",
                value->year, value->month, value->day);
 
-  ctx->tables.back().columns[col].row_values.push_back(
-      std::string(buffer, len));
+  ctx->tables.back().columns[col].row_values.emplace_back(buffer, len);
 
   return false;
 }
@@ -506,8 +501,7 @@ static int handle_store_time(void *pctx, const MYSQL_TIME *value, uint) {
       buffer, sizeof(buffer), "%s%02d:%02d:%02d", value->neg ? "-" : "",
       value->day ? (value->day * 24 + value->hour) : value->hour, value->minute,
       value->second);
-  ctx->tables.back().columns[col].row_values.push_back(
-      std::string(buffer, len));
+  ctx->tables.back().columns[col].row_values.emplace_back(buffer, len);
   return false;
 }
 
@@ -523,8 +517,7 @@ static int handle_store_datetime(void *pctx, const MYSQL_TIME *value, uint) {
                value->neg ? "-" : "", value->year, value->month, value->day,
                value->hour, value->minute, value->second);
 
-  ctx->tables.back().columns[col].row_values.push_back(
-      std::string(buffer, len));
+  ctx->tables.back().columns[col].row_values.emplace_back(buffer, len);
 
   return false;
 }
@@ -536,8 +529,7 @@ static int handle_store_string(void *pctx, const char *const value,
   const uint col = ctx->current_col;
   ctx->current_col++;
 
-  ctx->tables.back().columns[col].row_values.push_back(
-      std::string(value, length));
+  ctx->tables.back().columns[col].row_values.emplace_back(value, length);
 
   return false;
 }

plugin/x/src/io/xpl_listener_tcp.cc

@@ -67,11 +67,11 @@ class Tcp_creator {
 
     if (BIND_ALL_ADDRESSES == bind_address) {
       bind_addresses.clear();
-      bind_addresses.push_back(BIND_IPv4_ADDRESS);
+      bind_addresses.emplace_back(BIND_IPv4_ADDRESS);
 
       if (is_ipv6_avaiable()) {
         log_info(ER_XPLUGIN_IPv6_AVAILABLE);
-        bind_addresses.push_back(BIND_IPv6_ADDRESS);
+        bind_addresses.emplace_back(BIND_IPv6_ADDRESS);
       }
     }
 

router/src/router/src/common/log_filter.cc

@@ -43,8 +43,8 @@ std::string LogFilter::filter(std::string statement) const {
 
 void LogFilter::add_pattern(const std::string &pattern,
                             const std::string &replacement) {
-  patterns_.push_back(std::make_pair(
-      std::regex(pattern, std::regex_constants::icase), replacement));
+  patterns_.emplace_back(std::regex(pattern, std::regex_constants::icase),
+                         replacement);
 }
 
 void SQLLogFilter::add_default_sql_patterns() {