Replace print with logger output for the GROUP MONITOR and own GM logger

Change-Id: I62c93dacad11d07ce1b910620c4470f8ef3e334e

Author: ahorcom

mysqloperator/controller/group_monitor.py

@@ -10,6 +10,7 @@
 
 from mysqloperator.controller.shellutils import RetryLoop
 from . import shellutils
+from logging import Logger, getLogger
 import threading
 import time
 import select
@@ -36,6 +37,7 @@ def __init__(self, cluster: InnoDBCluster,
         self.last_view_id = None
 
         self.handler = handler
+        self.logger: Logger = getLogger(f"CM_{self.cluster.name}")
 
     @property
     def name(self) -> str:
@@ -48,18 +50,18 @@ def namespace(self) -> str:
     def ensure_connected(self) -> Optional['mysqlx.Session']:
         # TODO run a ping every X seconds
         if not self.session and (not self.last_connect_attempt or time.time() - self.last_connect_attempt > k_connect_retry_interval):
-            print(f"GroupMonitor: Trying to connect to a member of cluster {self.cluster.namespace}/{self.cluster.name}")
+            self.logger.info(f"Trying to connect to a member of cluster {self.cluster.namespace}/{self.cluster.name}")
             self.last_connect_attempt = time.time()
             self.session = None
             self.connect_to_primary()
 
             # force a refresh after we connect so we don't miss anything
             # that happened while we were out
             if self.session:
-                print(f"GroupMonitor: Connect member of {self.cluster.namespace}/{self.cluster.name} OK {self.session}")
+                self.logger.info(f"Connection to member of {self.cluster.namespace}/{self.cluster.name} OK {self.session}")
                 self.on_view_change(None)
             else:
-                print(f"GroupMonitor: Connect to member of {self.cluster.namespace}/{self.cluster.name} failed")
+                self.logger.error(f"Connection to member of {self.cluster.namespace}/{self.cluster.name} FAILED")
 
         return self.session
 
@@ -68,9 +70,9 @@ def connect_to_primary(self) -> None:
             session, is_primary = self.find_primary()
             if not is_primary:
                 if session:
-                    print(f"GroupMonitor: Could not connect to PRIMARY of cluster {self.cluster.namespace}/{self.cluster.name}")
+                    self.logger.error(f"Could not connect to PRIMARY of cluster {self.cluster.namespace}/{self.cluster.name}")
                 else:
-                    print(f"GroupMonitor: Could not connect to PRIMARY nor SECONDARY of cluster {self.cluster.namespace}/{self.cluster.name}")
+                    self.logger.error(f"Could not connect to neither PRIMARY nor SECONDARY of cluster {self.cluster.namespace}/{self.cluster.name}")
 
             if session:
                 try:
@@ -127,7 +129,7 @@ def try_connect(self, pod) -> Optional['mysqlx.Session']:
         try:
             session = mysqlx.get_session(pod.xendpoint_co)
         except mysqlsh.Error as e:
-            print(f"GroupMonitor: Error connecting to {pod.xendpoint}: {e}")
+            self.logger.error(f"ERROR CONNECTING TO {pod.xendpoint}: {e}")
             return None
 
         return session
@@ -140,14 +142,13 @@ def handle_notice(self) -> None:
                 notice = self.session._fetch_notice()
                 if not notice:
                     break
-                print(f"GOT NOTICE {notice}")
+                self.logger.info(f"GOT NOTICE {notice}")
                 self.on_view_change(notice.get("view_id"))
                 if not self.session:
                     break
 
             except mysqlsh.Error as e:
-                print(
-                    f"GroupMonitor: Error fetching notice: dest={self.target} error={e}")
+                self.logger.error(f"ERROR FETCHING NOTICE: dest={self.target} error={e}")
                 self.session.close()
                 self.session = None
                 break
@@ -170,8 +171,7 @@ def on_view_change(self, view_id: Optional[str]) -> None:
 
         # force reconnection if the PRIMARY changed or we're not connected to the PRIMARY
         if self.target_not_primary or force_reconnect:
-            print(
-                f"GroupMonitor: PRIMARY changed for {self.cluster.namespace}/{self.cluster.name}")
+            self.logger.info(f"PRIMARY changed for {self.cluster.namespace}/{self.cluster.name}")
             if self.session:
                 self.session.close()
                 self.session = None
@@ -185,6 +185,8 @@ def __init__(self):
         self.clusters : List[MonitoredCluster] = []
         self.stopped = False
 
+        self.logger: Logger = getLogger("GROUP_MONITOR")
+
     def monitor_cluster(self, cluster: InnoDBCluster,
                         handler: Callable[[InnoDBCluster, list[tuple], bool], None],
                         logger: Logger) -> None:
@@ -193,16 +195,17 @@ def monitor_cluster(self, cluster: InnoDBCluster,
                 return
 
         # We could get called here before the Secret is ready
-        account = RetryLoop(logger).call(cluster.get_admin_account)
+        account = RetryLoop(self.logger).call(cluster.get_admin_account)
 
         target = MonitoredCluster(cluster, account, handler)
         self.clusters.append(target)
-        print(f"Added monitor for {cluster.namespace}/{cluster.name}")
+        self.logger.info(f"ADDED A MONITOR FOR {cluster.namespace}/{cluster.name}")
 
     def remove_cluster(self, cluster: InnoDBCluster) -> None:
         for c in self.clusters:
             if c.name == cluster.name and c.namespace == cluster.namespace:
                 self.clusters.remove(c)
+                self.logger.info(f"REMOVED THE MONITOR OF CLUSTER {cluster.namespace}/{cluster.name}")
                 break
 
     def run(self) -> None: