Skip to content

Commit f1c9ad8

Browse files
committed
WL#16310: Fix install location of debug components on Windows
1 parent 4c8283f commit f1c9ad8

File tree

4 files changed

+33
-11
lines changed

4 files changed

+33
-11
lines changed

CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -545,9 +545,9 @@ install(TARGETS connector
545545

546546
install(TARGETS connector
547547
CONFIGURATIONS Debug
548-
ARCHIVE DESTINATION "${INSTALL_LIB_DIR_STATIC}/debug" COMPONENT XDevAPIDev
549-
RUNTIME DESTINATION "${INSTALL_LIB_DIR}/debug" COMPONENT XDevAPIDll
550-
LIBRARY DESTINATION "${INSTALL_LIB_DIR}/debug" COMPONENT XDevAPIDll
548+
ARCHIVE DESTINATION "${INSTALL_LIB_DIR_STATIC_DEBUG}" COMPONENT XDevAPIDev
549+
RUNTIME DESTINATION "${INSTALL_LIB_DIR_DEBUG}" COMPONENT XDevAPIDll
550+
LIBRARY DESTINATION "${INSTALL_LIB_DIR_DEBUG}" COMPONENT XDevAPIDll
551551
)
552552

553553
if(MSVC AND NOT BUILD_STATIC)
@@ -560,7 +560,7 @@ if(MSVC AND NOT BUILD_STATIC)
560560

561561
install(FILES $<TARGET_PDB_FILE:connector>
562562
CONFIGURATIONS Debug
563-
DESTINATION "${INSTALL_LIB_DIR}/debug"
563+
DESTINATION "${INSTALL_LIB_DIR_DEBUG}"
564564
COMPONENT Debuginfo
565565
)
566566

install_layout.cmake

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,24 @@ if(NOT INSTALL_LIB_DIR)
111111
set(INSTALL_LIB_DIR ${CMAKE_INSTALL_LIBDIR})
112112
endif()
113113

114+
if(NOT INSTALL_LIB_DIR_DEBUG)
115+
set(INSTALL_LIB_DIR_DEBUG "${INSTALL_LIB_DIR}/debug")
116+
endif()
117+
114118
if(NOT INSTALL_LIB_DIR_STATIC)
115119
set(INSTALL_LIB_DIR_STATIC "${INSTALL_LIB_DIR}")
116120
if(VS)
117121
set(INSTALL_LIB_DIR_STATIC "${INSTALL_LIB_DIR_STATIC}/${VS}")
118122
endif()
119123
endif()
120124

125+
if(NOT INSTALL_LIB_DIR_STATIC_DEBUG)
126+
set(INSTALL_LIB_DIR_STATIC_DEBUG "${INSTALL_LIB_DIR_DEBUG}")
127+
if(VS)
128+
set(INSTALL_LIB_DIR_STATIC_DEBUG "${INSTALL_LIB_DIR_STATIC_DEBUG}/${VS}")
129+
endif()
130+
endif()
131+
121132
if(NOT INSTALL_INCLUDE_DIR)
122133
set(INSTALL_INCLUDE_DIR ${CMAKE_INSTALL_INCLUDEDIR})
123134
endif()
@@ -141,8 +152,19 @@ set(INSTALL_LIB_DIR "${INSTALL_LIB_DIR}"
141152
CACHE INTERNAL "Library install location (relative to install root)"
142153
)
143154

155+
set(INSTALL_LIB_DIR_DEBUG "${INSTALL_LIB_DIR_DEBUG}"
156+
CACHE INTERNAL
157+
"Library install location for debug builds (relative to install root)"
158+
)
159+
144160
set(INSTALL_LIB_DIR_STATIC "${INSTALL_LIB_DIR_STATIC}"
145-
CACHE INTERNAL "Install location for static libraries (relative to install root)"
161+
CACHE INTERNAL
162+
"Install location for static libraries (relative to install root)"
163+
)
164+
165+
set(INSTALL_LIB_DIR_STATIC_DEBUG "${INSTALL_LIB_DIR_STATIC_DEBUG}"
166+
CACHE INTERNAL
167+
"Install location for static libraries for debug builds (relative to install root)"
146168
)
147169

148170
#

jdbc/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -336,9 +336,9 @@ install(TARGETS connector-jdbc
336336

337337
install(TARGETS connector-jdbc
338338
CONFIGURATIONS Debug
339-
ARCHIVE DESTINATION "${INSTALL_LIB_DIR_STATIC}/debug" COMPONENT JDBCDev
340-
RUNTIME DESTINATION "${INSTALL_LIB_DIR}/debug" COMPONENT JDBCDll
341-
LIBRARY DESTINATION "${INSTALL_LIB_DIR}/debug" COMPONENT JDBCDll
339+
ARCHIVE DESTINATION "${INSTALL_LIB_DIR_STATIC_DEBUG}" COMPONENT JDBCDev
340+
RUNTIME DESTINATION "${INSTALL_LIB_DIR_DEBUG}" COMPONENT JDBCDll
341+
LIBRARY DESTINATION "${INSTALL_LIB_DIR_DEBUG}" COMPONENT JDBCDll
342342
)
343343

344344

@@ -352,7 +352,7 @@ if(MSVC AND NOT BUILD_STATIC)
352352

353353
install(FILES $<TARGET_PDB_FILE:connector-jdbc>
354354
CONFIGURATIONS Debug
355-
DESTINATION "${INSTALL_LIB_DIR}/debug"
355+
DESTINATION "${INSTALL_LIB_DIR_DEBUG}"
356356
COMPONENT Debuginfo
357357
)
358358

mysql-concpp-config.cmake.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ function(add_connector_target which tgt base_name)
530530
unset(lib_path_debug CACHE)
531531
find_library(lib_path_debug
532532
NAMES ${base_name}
533-
PATHS ${MYSQL_CONCPP_RUNTIME_LIBRARY_DIR}/${vs_suffix}/debug
533+
PATHS ${MYSQL_CONCPP_RUNTIME_LIBRARY_DIR}/debug/${vs_suffix}
534534
NO_DEFAULT_PATH
535535
NO_CACHE
536536
)
@@ -557,7 +557,7 @@ function(add_connector_target which tgt base_name)
557557
if(WIN32)
558558

559559
set(lib_path_debug
560-
"${MYSQL_CONCPP_RUNTIME_LIBRARY_DIR}/${vs_suffix}/debug/${base_name}.lib"
560+
"${MYSQL_CONCPP_RUNTIME_LIBRARY_DIR}/debug/${vs_suffix}/${base_name}.lib"
561561
)
562562

563563
endif()

0 commit comments

Comments
 (0)