WL#11226: Clear all compile warnings

Author: rsomla1

CMakeLists.txt

@@ -335,7 +335,7 @@ endif()
 add_compile_options(${WERROR})
 
 
-if (CMAKE_COMPILER_IS_GNUCC AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 12.0)
+if (GCC AND GCC VERSION_GREATER 11)
   # Silence a warning produced by a regression in GCC 12.0 and newer
   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106199
   # Note: The stringop-overflow warnings are shown also during linking phase
@@ -422,7 +422,8 @@ if(MAINTAINER_MODE)
     # (and this is the case for MSVC 2015).
     # See: http://en.cppreference.com/w/cpp/language/copy_assignment
 
-    add_compile_options(/W4 /wd4512 /wd4127)
+    set_warnings_level(4)
+    add_compile_options(/wd4512 /wd4127)
 
   elseif(SUNPRO)
   else()

cdk/CMakeLists.txt

@@ -150,7 +150,7 @@ IF(MSVC)
 
   # TODO: move to /Wall when code base is ready for this
 
-  add_compile_options(/W4)
+  set_warnings_level(4)
 
   # Note: We disable warnings related to C++11 language because we want this
   # to be pure C++ code.

cdk/cmake/DepFindProtobuf.cmake

@@ -115,7 +115,7 @@ function(mysqlx_protobuf_generate_cpp SRCS HDRS)
   ELSEIF(MSVC)
     set_source_files_properties(${srcs}
       APPEND_STRING PROPERTY COMPILE_FLAGS
-      "/W1 /wd4018 /wd4996 /wd4244 /wd4267"
+      "/wd4018 /wd4996 /wd4244 /wd4267"
     )
   ENDIF()
 

cdk/cmake/compiler/MSVC.cmake

@@ -89,6 +89,16 @@ function(set_visibility)
 endfunction()
 
 
+function(set_warnings_level N)
+
+  # Note: The /Wn flag must be set only once, otherwise msvc shows warnings
+
+  string(REGEX REPLACE "/W[123456789]" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W${N}")
+
+endfunction()
+
+
 function(set_msvcrt TYPE)
 
   if(TYPE MATCHES "^(STATIC|Static|static)$")

cdk/cmake/gtest.cmake

@@ -32,9 +32,6 @@
 # Set up gtest for use by targets in given folder and its sub-folders.
 #
 MACRO(SETUP_GTEST)
-  IF (WITH_GTEST)
-    INCLUDE_DIRECTORIES(${GTEST_INCLUDE_DIRS})
-  ENDIF (WITH_GTEST)
 ENDMACRO(SETUP_GTEST)
 
 
@@ -135,6 +132,14 @@ MESSAGE("gtest_main location: ${gtest_main_location}")
 add_library(gtest STATIC IMPORTED)
 add_library(gtest_main STATIC IMPORTED)
 
+target_include_directories(gtest INTERFACE ${GTEST_INCLUDE_DIRS})
+
+# See: https://stackoverflow.com/questions/42847103/stdtr1-with-visual-studio-2017
+
+target_compile_definitions(gtest INTERFACE
+  -DGTEST_LANG_CXX11=1
+)
+
 set_target_properties(gtest PROPERTIES
   IMPORTED_LINK_INTERFACE_LANGUAGES "CXX"
   IMPORTED_LOCATION "${gtest_location}"

cdk/cmake/testing.cmake

@@ -144,6 +144,7 @@ IF(WITH_TESTS)
   set_global(test_tests ${test_tests})
 
   add_library(${TEST} OBJECT ${ARGN})
+  target_link_libraries(${TEST} gtest)
   set_target_properties(${TEST} PROPERTIES FOLDER "Tests")
 
   target_include_directories(${TEST} PRIVATE ${test_includes})
@@ -153,21 +154,18 @@ IF(WITH_TESTS)
   if (MSVC)
 
     target_compile_definitions(${TEST} PRIVATE
+      -D_CRT_SECURE_NO_WARNINGS
       -D_SCL_SECURE_NO_WARNINGS
-      -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
     )
 
     target_compile_options(${TEST} PRIVATE
-      /W3
       /wd4244
       /wd4267
       /wd4701
       /wd4018
       /wd4456  # declaration of hides previous local declaration
     )
 
-    target_compile_options(${TEST} PUBLIC /std:c++14)
-
     if(STATIC_TESTS_MSVCRT)
       target_compile_options(${TEST} PRIVATE
         $<$<CONFIG:Debug>:/MTd>
@@ -295,10 +293,7 @@ IF(WITH_TESTS)
 
   if (MSVC)
 
-    target_compile_definitions(${target_run_unit_tests} PRIVATE
-      -D_SCL_SECURE_NO_WARNINGS
-      -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
-    )
+    set_warnings_level(3)
 
     target_compile_options(${target_run_unit_tests} PRIVATE
       /wd4244

cdk/extra/protobuf/CMakeLists.txt

@@ -94,8 +94,18 @@ endif()
 
 set_visibility(hidden)
 
-if(NOT TOOLSET_MSVC AND NOT APPLE)
-  add_compile_options(-Wno-stringop-overflow -Wno-stringop-overread)
+if(GCC AND GCC VERSION_GREATER 11)
+  # See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106199
+  add_compile_options(-Wno-stringop-overflow)
+  add_compile_options(-Wno-stringop-overread)
+endif()
+
+if(NOT MSVC OR CLANG)
+  add_compile_options(-Wno-unused-const-variable)
+endif()
+
+if(WIN32)
+  add_compile_definitions(_CRT_SECURE_NO_WARNINGS _SCL_SECURE_NO_WARNINGS)
 endif()
 
 if(APPLE)

cdk/extra/zlib/CMakeLists.txt

@@ -7,12 +7,33 @@ set(CMAKE_ALLOW_LOOSE_LOOP_CONSTRUCTS ON)
 set(VERSION "1.3.1")
 
 project(zlib VERSION ${VERSION} LANGUAGES C)
+include(../setup.cmake)
+include(platform)
+
+enable_pic()
 
-option(ZLIB_BUILD_EXAMPLES "Enable Zlib Examples" ON)
 if(WERROR)
   add_compile_options(${WERROR})
 endif()
 
+if(WIN32)
+
+  add_compile_definitions(_CRT_SECURE_NO_WARNINGS _SCL_SECURE_NO_WARNINGS)
+
+  # warning triggered by one of the sources:
+  # The POSIX name for this item is deprecated. Instead, use the ISO C and C++
+  # conformant name: _open. See online help for details.
+
+  if(CLANG)
+    add_compile_options(-Wno-deprecated-declarations)
+  else()
+    add_compile_options(/wd4996)
+  endif()
+
+endif()
+
+option(ZLIB_BUILD_EXAMPLES "Enable Zlib Examples" OFF)
+
 IF(DISABLE_THESE_LINES)
 set(INSTALL_BIN_DIR "${CMAKE_INSTALL_PREFIX}/bin" CACHE PATH "Installation directory for executables")
 set(INSTALL_LIB_DIR "${CMAKE_INSTALL_PREFIX}/lib" CACHE PATH "Installation directory for libraries")
@@ -151,8 +172,6 @@ file(READ ${CMAKE_CURRENT_SOURCE_DIR}/zlib.h _zlib_h_contents)
 string(REGEX REPLACE ".*#define[ \t]+ZLIB_VERSION[ \t]+\"([-0-9A-Za-z.]+)\".*"
     "\\1" ZLIB_FULL_VERSION ${_zlib_h_contents})
 
-add_compile_options(-fPIC)
-
 add_library(zlib STATIC ${ZLIB_SRCS} ${ZLIB_PUBLIC_HDRS} ${ZLIB_PRIVATE_HDRS})
 
 target_include_directories(zlib PUBLIC

cdk/extra/zstd/CMakeLists.txt

@@ -19,6 +19,12 @@ if(WERROR)
   add_compile_options(${WERROR})
 endif()
 
+if(WIN32 AND CLANG)
+  # This warning shows only when building with clang on Win (clang 18):
+  # lib\compress\huf_compress.c(519,16): error : unused function 'HUF_isSorted'
+  add_compile_options(-Wno-unused-function)
+endif()
+
 
 SET(ZSTD_LIB_DIR
   "${PROJECT_SOURCE_DIR}/lib")

cdk/mysqlx/CMakeLists.txt

@@ -31,14 +31,6 @@ ADD_DEFINITIONS(-DWIN32_LEAN_AND_MEAN -DNOGDI)
 ADD_DEFINITIONS(-DNOMINMAX)
 ADD_DEFINITIONS(-DSIZEOF_LONG=${SIZEOF_LONG} -DSIZEOF_LONG_LONG=${SIZEOF_LONG_LONG})
 
-# TODO: Fix compile warnings in auth_mysql41.cc
-
-if(MSVC)
-  set_property(SOURCE auth_hash.cc
-    PROPERTY COMPILE_FLAGS "/W3"
-  )
-endif()
-
 file(GLOB HEADERS *.h)
 
 ADD_LIBRARY(cdk_mysqlx STATIC

common/tests/CMakeLists.txt

@@ -36,14 +36,6 @@ set_property(
   PROPERTY COMPILE_DEFINITIONS ""
 )
 
-if(WIN32)
-  add_definitions(
-    -D_CRT_SECURE_NO_WARNINGS
-    -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
-  )
-
-endif()
-
 #Add cdk includes because we are using their source tests
 add_test_includes(${PROJECT_SOURCE_DIR}/cdk/include)
 add_test_includes(${PROJECT_SOURCE_DIR}/cdk/extra/rapidjson/include)

devapi/tests/CMakeLists.txt

@@ -38,13 +38,6 @@ set_property(
   PROPERTY COMPILE_DEFINITIONS ""
 )
 
-if(WIN32)
-  add_definitions(
-    -D_CRT_SECURE_NO_WARNINGS
-    -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
-  )
-
-endif()
 
 #
 # If linking with connector statically, define macro that indicates this

include/mysqlx/common_constants.h

@@ -31,7 +31,7 @@
 #ifndef MYSQL_COMMON_CONSTANTS_H
 #define MYSQL_COMMON_CONSTANTS_H
 
-#include "version_info.h"
+#include <version_info.h>
 
 #define DEFAULT_MYSQL_PORT  3306
 #define DEFAULT_MYSQLX_PORT 33060

include/mysqlx/devapi/document.h

@@ -172,6 +172,8 @@ DLL_WARNINGS_POP
   virtual Iterator begin();
   virtual Iterator end();
 
+  virtual ~DbDoc() {}
+
   friend Impl;
   friend DocResult;
   friend Value;
@@ -360,6 +362,7 @@ class Value
     CATCH_AND_WRAP
   }
 
+  virtual ~Value() {}
 
 public:
 

include/mysqlx/devapi/result.h

@@ -484,6 +484,9 @@ class Column
 
 public:
 
+  virtual ~Column()
+  {}
+
   friend RowResult;
   struct INTERNAL Access;
   friend Access;

jdbc/cppconn/callback.h

@@ -133,6 +133,8 @@ class WebAuthn_Callback
     ActionRequested(msg);
   }
 
+  virtual ~WebAuthn_Callback() {}
+
 };
 
 
@@ -188,6 +190,8 @@ class Fido_Callback
     FidoActionRequested(msg);
   }
 
+  virtual ~Fido_Callback() {}
+
   friend class mysql::MySQL_Connection;
   friend class mysql::MySQL_Driver;
 };

jdbc/extra/otel/CMakeLists.txt

@@ -19,6 +19,14 @@ if(NOT (WIN32 OR APPLE OR CMAKE_SYSTEM_NAME MATCHES "SunOS"))
   if(WIN32)
     # Note: warning C4996 is triggered by OTel headers (as of version 1.10.0)
     target_compile_definitions(otel_api INTERFACE _SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING)
+
+  else()
+
+    # Note: warning triggered by OTel headers reported by clang 18:
+    # builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead
+
+    target_compile_options(otel_api INTERFACE -Wno-deprecated-builtins)
+
   endif()
 
 endif()

testing/CMakeLists.txt

@@ -49,25 +49,13 @@ endif()
 add_library(test_harness STATIC test_harness.cc)
 set_target_properties(test_harness PROPERTIES FOLDER "Tests")
 
+target_link_libraries(test_harness PUBLIC gtest)
+
 add_test_libraries(test_harness connector)
 add_test_includes(${CMAKE_CURRENT_SOURCE_DIR})
 
 
-if(MSVC)
-
-  set(TEST_COMPILE_FLAGS
-    -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
-    -D_CRT_SECURE_NO_WARNINGS
-    -D_SCL_SECURE_NO_WARNINGS
-  )
-
-  target_compile_definitions(test_harness PUBLIC
-    -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
-  )
-
-  target_compile_options(test_harness PUBLIC /std:c++14)
-
-else()
+if(NOT MSVC)
 
   set(TEST_COMPILE_FLAGS
     -Wno-sign-compare

xapi/tests/CMakeLists.txt

@@ -36,12 +36,6 @@ set_property(
   PROPERTY COMPILE_DEFINITIONS ""
 )
 
-IF(WIN32)
-  add_definitions(
-    -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING
-  )
-ENDIF()
-
 if(BUILD_STATIC)
   add_definitions(-DSTATIC_CONCPP)
 endif()

xapi/tests/xapi-t.cc

@@ -67,13 +67,15 @@ void check_compress(mysqlx_session_t *sess)
 
   buf_len = 65536;
   memset(buf, 0, buf_len);
-  EXPECT_NE(nullptr, row = mysqlx_row_fetch_one(res));
+  row = mysqlx_row_fetch_one(res);
+  EXPECT_FALSE(nullptr == row);
   EXPECT_EQ(RESULT_OK, mysqlx_get_bytes(row, 0, 0, buf, &buf_len));
   test_row("Test ", buf);
 
   buf_len = 65536;
   memset(buf, 0, buf_len);
-  EXPECT_NE(nullptr, row = mysqlx_row_fetch_one(res));
+  row = mysqlx_row_fetch_one(res);
+  EXPECT_FALSE(nullptr == row);
   EXPECT_EQ(RESULT_OK, mysqlx_get_bytes(row, 0, 0, buf, &buf_len));
   test_row("0123 ", buf);
 
@@ -2552,7 +2554,6 @@ TEST_F(xapi, dns_srv)
   //Specifying a port number with DNS SRV lookup is not allowed.
 
   {
-
     EXPECT_EQ(nullptr, mysqlx_get_client_from_url("mysqlx+srv://root@_mysqlx._tcp.localhost:33060",
       nullptr, &error));
     std::cout << "Expected Error: " << mysqlx_error_message(error) << std::endl;
@@ -2949,7 +2950,7 @@ TEST_F(xapi, tls_ver_ciphers)
     error = NULL;
     sess = mysqlx_get_session_from_options(opt, &error);
     mysqlx_free(error);
-    EXPECT_NE(NULL, sess);
+    EXPECT_FALSE(NULL == sess);
     mysqlx_session_close(sess);
 
 

xapi/tests/xapi_crud-t.cc

@@ -754,7 +754,7 @@ TEST_F(xapi, basic)
     const char *col_schema = mysqlx_column_get_schema(res, i);
     const char *col_cat = mysqlx_column_get_catalog(res, i);
 
-    EXPECT_NE(nullptr, col_cat);
+    EXPECT_FALSE(nullptr == col_cat);
 
     printf("\n Column # %d", i + 1);
     printf("\n * name: %s, orig name: %s, table: %s, orig table: %s, schema: %s, catalog: %s",