Skip to content

Commit 0881538

Browse files
committed
Bug#37179475 MSI installer should not install cmake configuration script in "Typical" profile
1 parent 47cf0e9 commit 0881538

File tree

2 files changed

+25
-24
lines changed

2 files changed

+25
-24
lines changed

buildinfo.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ function(generate_cmake_config)
4242
)
4343

4444
install(
45-
FILES
45+
FILES
4646
"${CMAKE_BINARY_DIR}/mysql-concpp${suffix}.cmake"
4747
DESTINATION .
48-
COMPONENT Readme
48+
COMPONENT DevCommon
4949
)
5050

5151
endforeach()

packaging/WiX/connector-cpp.wxs.in

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,26 @@
115115
<!-- License -->
116116
<WixVariable Id="WixUILicenseRtf" Value="@LICENSE_RTF@" />
117117

118-
<!-- Installation root-->
118+
<!--
119+
Register installed connector in the CMake system package registry.
120+
See https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#system-package-registry
121+
-->
122+
123+
<Component
124+
Id="CMAKE_PACKAGE_REGISTRY"
125+
Guid="7548d925-f065-482f-aea5-295500955198"
126+
Directory="INSTALLDIR"
127+
>
119128

129+
<RegistryValue
130+
Root="HKLM"
131+
Key="Software\Kitware\CMake\Packages\mysql-concpp"
132+
Type="string"
133+
Name="mysql-msi-installation"
134+
Value="[INSTALLDIR]"
135+
/>
136+
137+
</Component>
120138

121139
<!-- WIX_FEATURES -->
122140
<Feature Id="XDEVAPI" Title="New X DevAPI connector" Description="New X DevAPI connector" ConfigurableDirectory="INSTALLDIR" Level="1">
@@ -125,8 +143,10 @@
125143
<ComponentGroupRef Id="componentgroup.OpenSSLDll" />
126144
</Feature>
127145
<Feature Id="XDevAPIDev" Title="Development Components" Description="Connector C++ headers, static libraries and import libraries" ConfigurableDirectory="INSTALLDIR" Level="4">
146+
<ComponentGroupRef Id="componentgroup.DevCommon" />
128147
<ComponentGroupRef Id="componentgroup.XDevAPIDev" />
129148
<ComponentGroupRef Id="componentgroup.OpenSSLDev" />
149+
<ComponentRef Id="CMAKE_PACKAGE_REGISTRY" />
130150
</Feature>
131151
</Feature>
132152

@@ -136,8 +156,10 @@
136156
<ComponentGroupRef Id="componentgroup.OpenSSLDll" />
137157
</Feature>
138158
<Feature Id="JDBCDev" Title="Development Components" Description="Installs legacy JDBC API connector dev files" ConfigurableDirectory="INSTALLDIR" Level="4">
159+
<ComponentGroupRef Id="componentgroup.DevCommon" />
139160
<ComponentGroupRef Id="componentgroup.JDBCDev" />
140161
<ComponentGroupRef Id="componentgroup.OpenSSLDev" />
162+
<ComponentRef Id="CMAKE_PACKAGE_REGISTRY" />
141163
</Feature>
142164
</Feature>
143165

@@ -147,27 +169,6 @@
147169
<ComponentGroupRef Id="componentgroup.Readme" />
148170
</Feature>
149171

150-
<!--
151-
Register installed connector in the CMake system package registry.
152-
See https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#system-package-registry
153-
-->
154-
155-
<Component
156-
Id="CMAKE_PACKAGE_REGISTRY"
157-
Guid="7548d925-f065-482f-aea5-295500955198"
158-
Directory="INSTALLDIR"
159-
>
160-
161-
<RegistryValue
162-
Root="HKLM"
163-
Key="Software\Kitware\CMake\Packages\mysql-concpp"
164-
Type="string"
165-
Name="mysql-msi-installation"
166-
Value="[INSTALLDIR]"
167-
/>
168-
169-
</Component>
170-
171172
</Feature>
172173

173174

0 commit comments

Comments
 (0)