--fix : eslint & coverage 100% & return -1 if not found

Author: TheSTL

src/_Searching_/JumpSearch/JumpSearch.test.js

@@ -1,20 +1,30 @@
-const { jumpSearch, jumpSearchRecursive } = require('.');
+const { jumpSearch } = require('.');
 
-describe('Jump Search', () => {
-    const array = [1, 2, 3, 4, 5, 6, 7, 8];
-    describe('When element to find is at 1st position ', () => {
-        it('Jump search', () => {
-          expect(jumpSearch(array, 1)).toEqual(0);
-        });
-      });
-    describe('When element to find is at last position ', () => {
-        it('Jump search', () => {
-          expect(jumpSearch(array, 7)).toEqual(6);
-        });
-      });
-    describe('When element to find is at random position ', () => {
-        it('Jump search', () => {
-          expect(jumpSearch(array, 3)).toEqual(2);
-        });
-      });
-});
+describe('Jump Search', () => {
+  const array = [1, 2, 3, 4, 5, 6, 7, 8, 20];
+  describe('When element to find is at 1st position ', () => {
+    it('Jump search', () => {
+      expect(jumpSearch(array, 1)).toEqual(0);
+    });
+  });
+  describe('When element to find is at last position ', () => {
+    it('Jump search', () => {
+      expect(jumpSearch(array, 20)).toEqual(8);
+    });
+  });
+  describe('When element to find is at random position ', () => {
+    it('Jump search', () => {
+      expect(jumpSearch(array, 3)).toEqual(2);
+      expect(jumpSearch(array, 5)).toEqual(4);
+      expect(jumpSearch(array, 6)).toEqual(5);
+      expect(jumpSearch(array, 8)).toEqual(7);
+    });
+  });
+  describe('When element is not in array ', () => {
+    it('Jump search', () => {
+      expect(jumpSearch(array, 15)).toEqual(-1);
+      expect(jumpSearch(array, 25)).toEqual(-1);
+      expect(jumpSearch(array, 9)).toEqual(-1);
+    });
+  });
+});

src/_Searching_/JumpSearch/index.js

@@ -1,38 +1,32 @@
 /**
  * Note: Array must be sorted for jump search
- * Complexity: 
+ * Complexity:
  * Worst case time complexity: O(√N)
  * Average case time complexity: O(√N)
  * Best case time complexity: O(1)
  * Space complexity: O(1)
 */
 function jumpSearch(arr, key) {
-    const n = arr.length;
-    const jump = Math.floor(Math.sqrt(n));
-    let step = jump;
+  const n = arr.length;
+  const jump = Math.floor(Math.sqrt(n));
+  let step = jump;
+  let prev = 0;
 
-    let prev = 0;
-    
-    while(arr[Math.min(step, n) - 1] < key) {
-        prev = step;
-        step += jump;
-        if (prev >= n) 
-            return null; 
-    }
+  while (arr[Math.min(step, n) - 1] < key) {
+    prev = step;
+    step += jump;
+    if (prev >= n) { return -1; }
+  }
+
+  while (arr[prev] < key && prev < Math.min(step, n)) {
+    prev += 1;
+  }
 
-    while(arr[prev] < key) {
-        prev++;
+  if (arr[prev] === key) { return prev; }
 
-        if (prev == Math.min(step, n))
-            return null;
-    }
-    
-    if (arr[prev] == key) 
-        return prev; 
+  return -1;
+}
 
-    return null;
-  }
-  
-  module.exports = {
-    jumpSearch,
-  };
+module.exports = {
+  jumpSearch,
+};