Better function type visualization #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @tonievalue Thank you for the PR with a proper description and clear commit messages. Overall, good job! I think it would look better to set the width of the horizontal separator line to the page width, like on the current wiki.
|
Fernando-A-Rocha
approved these changes
Apr 30, 2025
Collaborator
Fernando-A-Rocha
left a comment
Fernando-A-Rocha
left a comment
There was a problem hiding this comment.
Well done. Thanks for having used CSS variables. Good practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better visualization of function type, in style of current MTA wiki. Visualization comes in form of discreet badge in page header, which replaces previous small mention in page content.
Selected approach isn't the cleanest implementation, but for sure is the cheapest one. Proper approach will require creating custom layout that will mimic the Starlight one, which potentially can cause problems when upgrading Starlight to newer versions.
Presentation, how badges look on page:
