Skip to content

Commit 3359982

Browse files
authored
Merge pull request #33 from ttyz/fix-nil-passphrase
Fix a bug, that caused the app to crash if ssh passphrase is not set.
2 parents 586e860 + 4034050 commit 3359982

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

pass/Controllers/SSHKeySettingTableViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class SSHKeySettingTableViewController: UITableViewController {
1818

1919
override func viewDidLoad() {
2020
super.viewDidLoad()
21-
passphraseTextField.text = Utils.getPasswordFromKeychain(name: "gitRepositorySSHPrivateKeyPassphrase")!
21+
passphraseTextField.text = Utils.getPasswordFromKeychain(name: "gitRepositorySSHPrivateKeyPassphrase") ?? ""
2222
privateKeyURLTextField.text = Defaults[.gitRepositorySSHPrivateKeyURL]?.absoluteString
2323
publicKeyURLTextField.text = Defaults[.gitRepositorySSHPublicKeyURL]?.absoluteString
2424
var doneBarButtonItem: UIBarButtonItem?

pass/Controllers/SettingsTableViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ class SettingsTableViewController: UITableViewController {
116116
gitCredential = GitCredential(
117117
credential: GitCredential.Credential.ssh(
118118
userName: username,
119-
password: Utils.getPasswordFromKeychain(name: "gitRepositorySSHPrivateKeyPassphrase")!,
119+
password: Utils.getPasswordFromKeychain(name: "gitRepositorySSHPrivateKeyPassphrase") ?? "",
120120
publicKeyFile: Globals.sshPublicKeyURL,
121121
privateKeyFile: Globals.sshPrivateKeyURL,
122122
passwordNotSetCallback: self.requestSshKeyPassword

pass/Models/PasswordStore.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ class PasswordStore {
142142
gitCredential = GitCredential(
143143
credential: GitCredential.Credential.ssh(
144144
userName: Defaults[.gitRepositoryUsername]!,
145-
password: Utils.getPasswordFromKeychain(name: "gitRepositorySSHPrivateKeyPassphrase")!,
145+
password: Utils.getPasswordFromKeychain(name: "gitRepositorySSHPrivateKeyPassphrase") ?? "",
146146
publicKeyFile: Globals.sshPublicKeyURL,
147147
privateKeyFile: Globals.sshPrivateKeyURL,
148148
passwordNotSetCallback: nil

0 commit comments

Comments
 (0)