Update V8 to 6.6.346.27

Author: tonyfreeman

Package.swift

@@ -46,7 +46,7 @@ let package = Package(
             dependencies: ["CV8", "Platform", "JavaScript"]),
         .target(
             name: "V8",
-            dependencies: ["CV8Platform", "V8API", "JavaScript"]),
+            dependencies: ["CV8Platform", "V8API", "Platform", "JavaScript"]),
         .target(
             name: "JavaScript",
             dependencies: []),

Sources/CV8/c_v8.cpp

@@ -236,15 +236,17 @@ extern "C" {
         HandleScope handle_scope(isolate);
 
         auto object = value->Get(isolate)->ToObject();
+        auto context = isolate->GetEnteredContext();
         auto key = String::NewFromUtf8(isolate, keyPtr);
-        auto result = object->GetRealNamedProperty(key);
+
+        auto result = object->GetRealNamedProperty(context, key);
 
         if (result.IsEmpty()) {
             if (exception != nullptr) {
                 *exception = new Global<Value>(isolate, trycatch.Exception());
             }
             return nullptr;
         }
-        return new Global<Value>(isolate, result);
+        return new Global<Value>(isolate, result.ToLocalChecked());
     }
 }

Sources/CV8Platform/c_v8_platform.cpp

@@ -9,29 +9,17 @@
  *                                                                            *
  ******************************************************************************/
 
-#include <stdlib.h> // malloc, free
-#include <string.h> // memset, memcpy
+#include "c_v8_platform.h"
+
 #include <libplatform/libplatform.h>
 #include <v8.h>
-#include "c_v8_platform.h"
 
 using namespace v8;
 
-class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
-public:
-    virtual void *Allocate(size_t length){
-        void *data = AllocateUninitialized(length);
-        return data == NULL ? data : memset(data, 0, length);
-    }
-    virtual void *AllocateUninitialized(size_t length) { return malloc(length); }
-    virtual void Free(void *data, size_t) { free(data); }
-};
-
 extern "C" {
-    ArrayBufferAllocator bufferAllocator;
-
-    void* initialize() {
-        V8::InitializeICU();
+    void* initialize(const char *exec_path) {
+        V8::InitializeICUDefaultLocation(exec_path);
+        v8::V8::InitializeExternalStartupData(exec_path);
         auto platform = platform::CreateDefaultPlatform();
         V8::InitializePlatform(platform);
         V8::Initialize();
@@ -46,7 +34,8 @@ extern "C" {
 
     void* createIsolate() {
         Isolate::CreateParams create_params;
-        create_params.array_buffer_allocator = &bufferAllocator;
+        create_params.array_buffer_allocator =
+            v8::ArrayBuffer::Allocator::NewDefaultAllocator();
         return Isolate::New(create_params);
     }
 

Sources/CV8Platform/include/c_v8_platform.h

@@ -20,7 +20,7 @@ extern "C" {
 #endif
 
     // global
-    void * _Nonnull initialize();
+    void * _Nonnull initialize(const char * _Nonnull exec_path);
     void dispose(void * _Nonnull platform);
     // isolater
     void * _Nonnull createIsolate();

Sources/V8/JSRuntime.swift

@@ -11,6 +11,7 @@
 
 import CV8Platform
 import JavaScript
+import Platform
 
 @_exported import V8API
 
@@ -22,11 +23,14 @@ public class JSRuntime {
         return JSRuntime()
     }()
 
+    // The whole V8API & V8 split is caused
+    // by difference in the initialization
+    // between standalone v8 and node.js,
+    // so this way we can reuse the api
     public required init() {
-        // The whole V8API & V8 split is caused
-        // by difference in this initialization
-        // between standalone v8 and node.js
-        self.platform = initialize()
+        // used to load snapshot_blob, natives_blob, icudtl.dat
+        let libsPath = Environment["NODE_PATH"] ?? "/usr/local/lib/"
+        self.platform = initialize(libsPath)
         self.isolate = createIsolate()
     }