CLOUDP-83092: Add release task for init containers #433
Conversation
…ithub.com:mongodb/mongodb-kubernetes-operator into CLOUDP-83092_add_release_task_for_init_containers
| "tools_distro": "rhel70-x86_64", | ||
| "agent_distro": "rhel7_x86_64", |
There was a problem hiding this comment.
the values of these fields were in the opposite distro!
rodrigovalin
left a comment
rodrigovalin
left a comment
There was a problem hiding this comment.
I have one comment on that ensure_skip_tag function whose return value seems a bit odd.
scripts/dev/dev_config.py
Outdated
| return self._config["agent_image_ubi"] | ||
| return self._config["agent_image_ubuntu"] | ||
|
|
||
| def ensure_skip_tag(self, tag: str) -> bool: |
There was a problem hiding this comment.
Looks like this return value is not being used anywhere, and it is not evident what it is suppoed to mean. Maybe remove it?
There was a problem hiding this comment.
it was intended to return true if the value was modified - but you're right we don't actually need this! Will remove
|
|
||
| # shellcheck disable=SC2154 | ||
| python3 pipeline.py --image-name "${image_name}" | ||
| if [ -n "${release}" ]; then |
There was a problem hiding this comment.
Can we move this logic to the python script instead? Always do
python3 pipeline.py --image-name "${image_name}" --release "${release:-}"And in the python script check for the value of the --release option (which should default to false)
There was a problem hiding this comment.
yes that's a lot cleaner!
pipeline.py
Outdated
| def _parse_args() -> argparse.Namespace: | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("--image-name", type=str) | ||
| parser.add_argument("--release", action="store_true") |
There was a problem hiding this comment.
type bool, default is False? Will be easier to call from shell script
All Submissions:
To be reviewed after: #432This PR adds a release task for the version upgrade post start hook and readiness probe.