Skip to content

PHPORM-418 Test with PHP 8.5 and reduce test matrix #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GromNaN merged 7 commits into from
Dec 8, 2025
Merged

PHPORM-418 Test with PHP 8.5 and reduce test matrix #3459

GromNaN merged 7 commits into from
Dec 8, 2025
+61 −53

Conversation

@GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 3, 2025 •
edited
Loading

Fix PHPORM-418

  • Add PHP 8.5 to the tests
  • Reduce test matrix for less resource consumption while keeping a coverage for every MongoDB server, driver, PHP and Laravel versions.
  • Don't run tests in duplicate for feature/* branches, they must be used to PR version branches.

@GromNaN GromNaN requested a review from a team as a code owner December 3, 2025 16:12
@GromNaN GromNaN requested review from alcaeus and Copilot and removed request for Copilot December 3, 2025 16:12
@github-actions github-actions bot added the github label Dec 3, 2025
@github-advanced-security
Copy link

github-advanced-security bot commented Dec 3, 2025

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@GromNaN
Copy link
Member Author

GromNaN commented Dec 3, 2025

Tests failing on Atlas. I have to digg if something change in the atlas local docker image.

@GromNaN GromNaN changed the title Test with PHP 8.5 and reduce test matrix PHPORM-418 Test with PHP 8.5 and reduce test matrix Dec 4, 2025
@GromNaN
Copy link
Member Author

GromNaN commented Dec 5, 2025

Waiting for #3460

Copilot AI review requested due to automatic review settings December 5, 2025 16:50
@GromNaN GromNaN requested a review from a team as a code owner December 5, 2025 16:50
@GromNaN GromNaN requested a review from lindseymoore December 5, 2025 16:50
@github-actions github-actions bot added the docs label Dec 5, 2025
@GromNaN GromNaN changed the base branch from 5.x to 5.5 December 5, 2025 16:50
@GromNaN GromNaN removed request for a team and lindseymoore December 5, 2025 16:50
@GromNaN GromNaN removed the docs label Dec 5, 2025
Copilot AI reviewed Dec 5, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

alcaeus
alcaeus approved these changes Dec 8, 2025
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion to always use the latest PHP version for extra matrix builds.

.github/workflows/build-ci.yml Outdated
- php: "8.1"
mongodb: "8.0"
# Test all server versions
- php: "8.4"
Copy link
Member

@alcaeus alcaeus Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use PHP 8.5 (i.e. always the latest PHP version) for these tests?

Copy link
Member Author

@GromNaN GromNaN Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not easy to decide which versions to test in the matrix. Should we use the lowest PHP version to ensure there is no invalid syntax? Or should we use the highest version to ensure there is no depreciation?

We don't have any code path specific to a particular PHP version. We should probably use PHP 8.2.

paulinevos and others added 6 commits December 8, 2025 15:07
@paulinevos @GromNaN
Improve change log categories (mongodb#3442)
7190155 
So that anything labeled `feature` is added to the Features category and docs changes are listed as a separate category
@dependabot @GromNaN
Bump actions/labeler from 5 to 6 (mongodb#3445)
7b2a0ff 
Bumps [actions/labeler](https://github.com/actions/labeler) from 5 to 6.
- [Release notes](https://github.com/actions/labeler/releases)
- [Commits](actions/labeler@v5...v6)

---
updated-dependencies:
- dependency-name: actions/labeler
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@GromNaN
Remove explicit dependency to symfony/http-kernel as it's not used di…
ee70dbf 
…rectly (mongodb#3446)
@dependabot @GromNaN
Bump mongodb-labs/drivers-github-tools from 2 to 3 (mongodb#3452)
c09acc5 
Bumps [mongodb-labs/drivers-github-tools](https://github.com/mongodb-labs/drivers-github-tools) from 2 to 3.
- [Release notes](https://github.com/mongodb-labs/drivers-github-tools/releases)
- [Commits](mongodb-labs/drivers-github-tools@v2...v3)

---
updated-dependencies:
- dependency-name: mongodb-labs/drivers-github-tools
  dependency-version: '3'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @GromNaN
Bump github/codeql-action from 3 to 4 (mongodb#3455)
d75509b 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v3...v4)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@GromNaN
Test with PHP 8.5 and reduce test matrix
ccc0d62
@GromNaN GromNaN merged commit 8edd6a2 into mongodb:5.5 Dec 8, 2025
30 checks passed
@GromNaN GromNaN deleted the PHPORM-418 branch December 8, 2025 17:29
@mongodb-php-bot mongodb-php-bot mentioned this pull request Dec 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@alcaeus alcaeus alcaeus approved these changes

Assignees

No one assigned

Labels

github

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GromNaN @alcaeus @paulinevos