Skip to content
This repository was archived by the owner on Sep 23, 2024. It is now read-only.

Commit 678e16b

Browse files
committed
[#6] Windows only prebuilt support
Squashed commit of the following: commit b8a3759 Author: Lucas Hrabovsky <hrabovsky.lucas@gmail.com> Date: Tue Apr 21 14:06:57 2015 -0400 [#6] Update explanation on prebuilt binaries commit 56f7602 Author: Lucas Hrabovsky <hrabovsky.lucas@gmail.com> Date: Tue Apr 21 13:43:20 2015 -0400 debugging commit 62d00aa Author: Lucas Hrabovsky <hrabovsky.lucas@gmail.com> Date: Tue Apr 21 13:07:31 2015 -0400 forgot to remove appveyor pretest commit 02b4e95 Author: Lucas Hrabovsky <hrabovsky.lucas@gmail.com> Date: Tue Apr 21 12:58:34 2015 -0400 [#6] simplify windows testing commit ea524a9 Author: Lucas Hrabovsky <hrabovsky.lucas@gmail.com> Date: Tue Apr 21 12:46:57 2015 -0400 [#6] Scripts for appveyor commit a2e71a0 Author: Lucas Hrabovsky <hrabovsky.lucas@gmail.com> Date: Tue Apr 21 12:43:09 2015 -0400 [#6] reorg to only prebuild windows
1 parent 107a4d0 commit 678e16b

File tree

7 files changed

+39
-29
lines changed

7 files changed

+39
-29
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,5 @@ npm-debug.log
4242
builderror.log
4343

4444
bson.sublime-project
45-
bson.sublime-workspace
45+
bson.sublime-workspace
46+
.vagrant/

.npmignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
.travis.yml
22
appveyor.yml
3-
build
43
test.bat
54
build/
65
test/
6+
.vagrant/

README.md

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33
[![linux build status](https://secure.travis-ci.org/imlucas/bson-ext.png)](http://travis-ci.org/imlucas/bson-ext)
44
[![windows build status](https://ci.appveyor.com/api/projects/status/github/imlucas/bson-ext)](https://ci.appveyor.com/project/imlucas/bson-ext)
55

6-
This module contains the C++ BSON parser only and is not meant to be used in
7-
isolation from the [bson](http://npm.im/bson) NPM module. It lives in
8-
it's own module so it can be an optional dependency for the
9-
[bson](http://npm.im/bson) module.
10-
6+
This module contains the BSON [native addon](https://nodejs.org/api/addons.html)
7+
only and is not meant to be used in isolation from the [bson](http://npm.im/bson)
8+
NPM module. It lives in it's own module so it can be an optional
9+
dependency for the [bson](http://npm.im/bson) module.
1110

1211
## Testing
1312

@@ -17,9 +16,21 @@ npm test
1716

1817
## Prebuilt Binaries
1918

20-
bson-ext uses [node-pre-gyp](http://npm.im/node-pre-gyp) to publish and install
21-
prebuilt binaries. This means you don't need the full toolchain installed
22-
and configured correctly to use this module.
19+
Have you ever seen this message in your console?
20+
21+
```
22+
js-bson: Failed to load c++ bson extension, using pure JS version
23+
```
24+
25+
We are experimenting with [node-pre-gyp](http://npm.im/node-pre-gyp) to publish
26+
and install prebuilt binaries. This means you don't need the full toolchain installed
27+
and configured correctly to use this module and you'll never have to see this
28+
message again. Currently, prebuilt binaries will only be used for Windows,
29+
as it is the most problematic platform for this issue. This will also allow us
30+
more time to evaluate the costs and benefits of prebuilt support on OSX and Linux.
31+
32+
If you are interested in prebuilt binary support on OSX or Linux, please
33+
[join the discussion on this issue](https://github.com/christkv/bson-ext/issues/6)!
2334

2435
## License
2536

appveyor.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@ environment:
66

77
test_script:
88
- ps: Install-Product node 0.10 x86
9-
- .\test.bat
9+
- .\test\scripts\test
1010
- ps: Install-Product node 0.10 x64
11-
- .\test.bat
11+
- .\test\scripts\test
1212
- ps: Install-Product node 0.12 x86
13-
- .\test.bat
13+
- .\test\scripts\test
1414
- ps: Install-Product node 0.12 x64
15-
- .\test.bat
15+
- .\test\scripts\test
1616
- ps: Install-Product node 1 x86
17-
- .\test.bat
17+
- .\test\scripts\test
1818
- ps: Install-Product node 1 x64
19-
- .\test.bat
19+
- .\test\scripts\test
2020

2121
build: OFF

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
"node-pre-gyp"
2626
],
2727
"devDependencies": {
28-
"aws-sdk": "~2.1.20",
2928
"nodeunit": "~0.9.0"
3029
},
3130
"main": "./index",
@@ -37,8 +36,7 @@
3736
},
3837
"scripts": {
3938
"install": "node-pre-gyp install --fallback-to-build",
40-
"test": "nodeunit ./test/node",
41-
"posttest": "node-pre-gyp publish-maybe"
39+
"test": "nodeunit ./test/node"
4240
},
4341
"licenses": [
4442
{

test.bat

Lines changed: 0 additions & 10 deletions
This file was deleted.

test/scripts/test.cmd

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
SET GYP_MSVS_VERSION=2013
2+
SET PATH=%PATH%;%APPDATA%\npm
3+
SET PATH=%PATH%;C:\Program Files (x86)\Git\bin
4+
SET PATH=%PATH%;C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\bin
5+
call node -p "process.versions"
6+
call npm install -g https://github.com/mongodb-js/node-pre-gyp/archive/v0.6.5-appveyor.tar.gz https://github.com/mongodb-js/node-gyp/archive/v1.04-appveyor.tar.gz
7+
call npm install --build-from-source
8+
call npm test || echo ERROR && exit /b
9+
call npm install -g aws-sdk
10+
call node-pre-gyp publish-maybe

0 commit comments

Comments
 (0)