Skip to content

Commit 9e72fe5

Browse files
ericsnowcurrentlymliezun
authored andcommitted
pythongh-117398: Add datetime Module State (pythongh-119810)
I was able to make use of the existing datetime_state struct, but there was one tricky thing I had to sort out. We mostly aren't converting to heap types, so we can't use things like PyType_GetModuleByDef() to look up the module state. The solution I came up with is somewhat novel, but I consider it straightforward. Also, it shouldn't have much impact on performance. In summary, this main changes here are: * I've added some macros to help hide how various objects relate to module state * as a solution to the module state lookup problem, I've stored the last loaded module on the current interpreter's internal dict (actually a weakref) * if the static type method is used after the module has been deleted, it is reloaded * to avoid extra work when loading the module, we directly copy the objects (new refs only) from the old module state into the new state if the old module hasn't been deleted yet * during module init we set various objects on the static types' __dict__s; to simplify things, we only do that the first time; once those static types have a separate __dict__ per interpreter, we'll do it every time * we now clear the module state when the module is destroyed (before, we were leaking everything in _datetime_global_state)
1 parent cb8a398 commit 9e72fe5

5 files changed

+376
-162
lines changed

Diff for: Include/internal/pycore_global_objects_fini_generated.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: Include/internal/pycore_global_strings.h

+1
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,7 @@ struct _Py_global_strings {
318318
STRUCT_FOR_ID(c_call)
319319
STRUCT_FOR_ID(c_exception)
320320
STRUCT_FOR_ID(c_return)
321+
STRUCT_FOR_ID(cached_datetime_module)
321322
STRUCT_FOR_ID(cached_statements)
322323
STRUCT_FOR_ID(cadata)
323324
STRUCT_FOR_ID(cafile)

Diff for: Include/internal/pycore_runtime_init_generated.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: Include/internal/pycore_unicodeobject_generated.h

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)