Make sure cleanup runs before the tests #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeferguson
approved these changes
Jun 22, 2022
Contributor
|
It seems this PR causes cyclic dependency when we set add_code_coverage(
NAME ${PROJECT_NAME}_coverage_report
DEPENDENCIES tests
)https://github.com/mikeferguson/code_coverage#usage You can check the build issue with |
This was referenced Jun 13, 2023
Closed
knorth55
added a commit
to knorth55/code_coverage
that referenced
this pull request
Jun 13, 2023
This reverts commit 52ccd15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #35 for me.
teststarget, the cleanup is always executed before tests are run.