When implements interface in typescript adds import before element

[mjbvz]

From @inferius on October 11, 2018 8:6

Hi, implements interface in typescript auto adds import with absolute path before element of class.

• VSCode Version: 1.28.0
• OS Version: Windows 10

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes

Copied from original issue: microsoft/vscode#60606

[mjbvz]

Please try upgrading your workspace to use typescript@next by following these instructions. Do you still see this error after upgrading?

[mjbvz]

From @inferius on October 12, 2018 7:28

Yes, i still see this error after upgrading.

[mjbvz]

Thanks for testing. Can you please share your tsconfig and a basic description of your project structure

[mjbvz]

From @DanTup on October 23, 2018 9:3

@mjbvz I see this too. I've pushed a branch with a repro here:

https://github.com/Dart-Code/Dart-Code/tree/vscode-60606-repro

Clone the vscode-60606-repro branch, open src/pub/pub_task_provider.ts and then use the quick-fix to implement the interface. I changed it to typescript@latest and see the same issue.

(using * as vs in the import correctly puts vs. prefixes instead of import calls).

[MeirionHughes]

Any update on this? just seems to have been kicked into the long grass.

[weswigham]

We'd probably take PRs to fix it ❤️

[mjbates7]

Still occurring - running insiders 1.38.0 build. Any updates or thoughts? It's generating code like this: (angular)

[weswigham]

That code is technically equivalent to the version where an import statement is used, just not as pretty - hence why this hasn't been the highest priority for us, and why I said we'd take a PR to fix it~ ❤️

[keotl]

I opened a PR which forces private aliases for implemented interface types. However, pointers would be appreciated for adding automatic importation.

[weswigham]

You'd want to query for the same type nodes that we do today (complete with import types), but then traverse the node tree looking for instances of ImportTypeNodes, and transform them into a normal type reference by replacing the import(...) part with a generated name, and then adding an import * as generatedName from "..." statement. Then you can get smarter, like using named imports rather than namespace, and merging with existing import statements where possible.

[keotl]

I pushed a new version with automatic imports.

This would be ready for review/testing.

[JulianLang]

So, what's the status here?

[avol-io]

any news?

[andrewbranch]

This was fixed by #36615 which is included in TypeScript 3.8.

Unfortunately, #34995, the issue I was assigned, was never marked as a duplicate of this one, and so I was never aware of the existence of this issue or the great work by @keotl at #33126. Sadly this happens from time to time in a repo with thousands of issues, but my apologies for the mixup nonetheless, particularly to @keotl.