Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkJs should imply allowJs #16738

Closed
graingert opened this issue Jun 26, 2017 · 5 comments
Closed

checkJs should imply allowJs #16738

graingert opened this issue Jun 26, 2017 · 5 comments
Labels
In Discussion Not yet reached consensus Suggestion An idea for TypeScript

Comments

@graingert
Copy link

TypeScript Version: 2.3.4

Code

function someJs() {}

Expected behavior:
typechecks ok with --checkJs

Actual behavior:
TS18003: No inputs were found in config file
@graingert graingert changed the title checkJs imply allowJs checkJs should imply allowJs Jun 26, 2017
@graingert
Copy link
Author

also setting checkJs true and allowJs false should fail to run

@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript In Discussion Not yet reached consensus labels Jun 27, 2017
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 2.5 milestone Jun 27, 2017
@mhegazy mhegazy removed this from the TypeScript 2.6 milestone Aug 31, 2017
@egamma egamma mentioned this issue Jan 27, 2018
Closed
@nickserv
Copy link
Contributor

I agree, I was about to make an issue for this myself. checkJs is invalid without allowJs, and other compilerOptions are implied, so I think it would be more consistent and convenient to imply this as well.

@glen-84
Copy link

glen-84 commented Dec 19, 2020

Fixed in #40275.

@RA80533
Copy link

RA80533 commented Mar 4, 2021

/cc @mhegazy

@graingert
Copy link
Author

Nice! Thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In Discussion Not yet reached consensus Suggestion An idea for TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@glen-84 @graingert @nickserv @DanielRosenwasser @RyanCavanaugh @mhegazy @RA80533