array-type: [ default: array, generic: array ]

Author: a-tarasyuk

.eslintrc.json

@@ -16,7 +16,7 @@
     ],
     "rules": {
         "@typescript-eslint/adjacent-overload-signatures": "error",
-        "@typescript-eslint/array-type": ["error", { "default": "array", "readonly": "generic" }],
+        "@typescript-eslint/array-type": "error",
         "camelcase": "off",
         "@typescript-eslint/camelcase": ["error", { "properties": "never", "allow": ["^[A-Za-z][a-zA-Za-z]+_[A-Za-z]+$"] }],
         "@typescript-eslint/class-name-casing": "error",

scripts/failed-tests.d.ts

@@ -8,7 +8,7 @@ declare class FailedTestsReporter extends Mocha.reporters.Base {
     reporterOptions: FailedTestsReporter.ReporterOptions;
     reporter?: Mocha.reporters.Base;
     constructor(runner: Mocha.Runner, options?: { reporterOptions?: FailedTestsReporter.ReporterOptions });
-    static writeFailures(file: string, passes: ReadonlyArray<Mocha.Test>, failures: ReadonlyArray<Mocha.Test>, keepFailed: boolean, done: (err?: NodeJS.ErrnoException) => void): void;
+    static writeFailures(file: string, passes: readonly Mocha.Test[], failures: readonly Mocha.Test[], keepFailed: boolean, done: (err?: NodeJS.ErrnoException) => void): void;
     done(failures: number, fn?: (failures: number) => void): void;
 }
 

scripts/types/ambient.d.ts

@@ -19,7 +19,7 @@ declare module "vinyl" {
         cwd: string;
         base: string;
         path: string;
-        readonly history: ReadonlyArray<string>;
+        readonly history: readonly string[];
         contents: T;
         relative: string;
         dirname: string;
@@ -45,7 +45,7 @@ declare module "vinyl" {
             cwd?: string;
             base?: string;
             path?: string;
-            history?: ReadonlyArray<string>;
+            history?: readonly string[];
             stat?: import("fs").Stats;
             contents?: T;
             sourceMap?: import("./sourcemaps").RawSourceMap | string;

src/compiler/builder.ts

@@ -69,11 +69,11 @@ namespace ts {
         /**
          * Cache of all files excluding default library file for the current program
          */
-        allFilesExcludingDefaultLibraryFile?: ReadonlyArray<SourceFile>;
+        allFilesExcludingDefaultLibraryFile?: readonly SourceFile[];
         /**
          * Cache of all the file names
          */
-        allFileNames?: ReadonlyArray<string>;
+        allFileNames?: readonly string[];
     }
 
     export function cloneMapOrUndefined<T>(map: ReadonlyMap<T> | undefined) {
@@ -286,7 +286,7 @@ namespace ts.BuilderState {
     /**
      * Gets the files affected by the path from the program
      */
-    export function getFilesAffectedBy(state: BuilderState, programOfThisState: Program, path: Path, cancellationToken: CancellationToken | undefined, computeHash: ComputeHash, cacheToUpdateSignature?: Map<string>, exportedModulesMapCache?: ComputingExportedModulesMap): ReadonlyArray<SourceFile> {
+    export function getFilesAffectedBy(state: BuilderState, programOfThisState: Program, path: Path, cancellationToken: CancellationToken | undefined, computeHash: ComputeHash, cacheToUpdateSignature?: Map<string>, exportedModulesMapCache?: ComputingExportedModulesMap): readonly SourceFile[] {
         // Since the operation could be cancelled, the signatures are always stored in the cache
         // They will be committed once it is safe to use them
         // eg when calling this api from tsserver, if there is no cancellation of the operation
@@ -407,7 +407,7 @@ namespace ts.BuilderState {
     /**
      * Get all the dependencies of the sourceFile
      */
-    export function getAllDependencies(state: BuilderState, programOfThisState: Program, sourceFile: SourceFile): ReadonlyArray<string> {
+    export function getAllDependencies(state: BuilderState, programOfThisState: Program, sourceFile: SourceFile): readonly string[] {
         const compilerOptions = programOfThisState.getCompilerOptions();
         // With --out or --outFile all outputs go into single file, all files depend on each other
         if (compilerOptions.outFile || compilerOptions.out) {
@@ -445,7 +445,7 @@ namespace ts.BuilderState {
     /**
      * Gets the names of all files from the program
      */
-    function getAllFileNames(state: BuilderState, programOfThisState: Program): ReadonlyArray<string> {
+    function getAllFileNames(state: BuilderState, programOfThisState: Program): readonly string[] {
         if (!state.allFileNames) {
             const sourceFiles = programOfThisState.getSourceFiles();
             state.allFileNames = sourceFiles === emptyArray ? emptyArray : sourceFiles.map(file => file.fileName);
@@ -496,7 +496,7 @@ namespace ts.BuilderState {
     /**
      * Gets all files of the program excluding the default library file
      */
-    function getAllFilesExcludingDefaultLibraryFile(state: BuilderState, programOfThisState: Program, firstSourceFile: SourceFile): ReadonlyArray<SourceFile> {
+    function getAllFilesExcludingDefaultLibraryFile(state: BuilderState, programOfThisState: Program, firstSourceFile: SourceFile): readonly SourceFile[] {
         // Use cached result
         if (state.allFilesExcludingDefaultLibraryFile) {
             return state.allFilesExcludingDefaultLibraryFile;