Skip to content

Commit 411bc18

Browse files
committed
rename sort text helper
1 parent 6ebe361 commit 411bc18

6 files changed

+14
-14
lines changed

src/harness/fourslashInterfaceImpl.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -975,7 +975,7 @@ namespace FourSlashInterface {
975975
return `${presetSortText}\0${symbolDisplayName}\0` as SortText;
976976
},
977977

978-
AddIsSnippetSuffix(sortText: SortText): SortText {
978+
SortBelow(sortText: SortText): SortText {
979979
return sortText + "1" as SortText;
980980
},
981981
};

src/services/completions.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ namespace ts.Completions {
2828
return `${presetSortText}\0${symbolDisplayName}\0` as SortText;
2929
},
3030

31-
AddIsSnippetSuffix(sortText: SortText): SortText {
31+
SortBelow(sortText: SortText): SortText {
3232
return sortText + "1" as SortText;
3333
},
3434
};
@@ -780,7 +780,7 @@ namespace ts.Completions {
780780
}
781781
({ insertText, isSnippet, importAdder, sourceDisplay } = entry);
782782
source = CompletionSource.ObjectLiteralMethodSnippet;
783-
sortText = SortText.AddIsSnippetSuffix(sortText);
783+
sortText = SortText.SortBelow(sortText);
784784
if (importAdder.hasFixes()) {
785785
hasAction = true;
786786
}

tests/cases/fourslash/completionsObjectLiteralMethod1.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ verify.completions({
4747
},
4848
{
4949
name: "bar",
50-
sortText: completion.SortText.AddIsSnippetSuffix(
50+
sortText: completion.SortText.SortBelow(
5151
completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "bar")),
5252
source: completion.CompletionSource.ObjectLiteralMethodSnippet,
5353
insertText: "bar(x: number): void {\n},",
@@ -69,7 +69,7 @@ verify.completions({
6969
},
7070
{
7171
name: "bar",
72-
sortText: completion.SortText.AddIsSnippetSuffix(
72+
sortText: completion.SortText.SortBelow(
7373
completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "bar")),
7474
source: completion.CompletionSource.ObjectLiteralMethodSnippet,
7575
insertText: "bar(x: number): void {\n},",
@@ -81,7 +81,7 @@ verify.completions({
8181
},
8282
{
8383
name: "foo",
84-
sortText: completion.SortText.AddIsSnippetSuffix(
84+
sortText: completion.SortText.SortBelow(
8585
completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "foo")),
8686
source: completion.CompletionSource.ObjectLiteralMethodSnippet,
8787
insertText: "foo(x: string): string {\n},",
@@ -119,7 +119,7 @@ verify.completions({
119119
},
120120
{
121121
name: "\"space bar\"",
122-
sortText: completion.SortText.AddIsSnippetSuffix(
122+
sortText: completion.SortText.SortBelow(
123123
completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "\"space bar\"")),
124124
source: completion.CompletionSource.ObjectLiteralMethodSnippet,
125125
insertText: "\"space bar\"(): string {\n},",
@@ -141,7 +141,7 @@ verify.completions({
141141
},
142142
{
143143
name: "bar",
144-
sortText: completion.SortText.AddIsSnippetSuffix(
144+
sortText: completion.SortText.SortBelow(
145145
completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "bar")),
146146
source: completion.CompletionSource.ObjectLiteralMethodSnippet,
147147
isSnippet: true,

tests/cases/fourslash/completionsObjectLiteralMethod2.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ verify.completions({
3333
},
3434
{
3535
name: "foo",
36-
sortText: completion.SortText.AddIsSnippetSuffix(
36+
sortText: completion.SortText.SortBelow(
3737
completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "foo")),
3838
source: completion.CompletionSource.ObjectLiteralMethodSnippet,
3939
insertText: "foo(f: IFoo): void {\n},",

tests/cases/fourslash/completionsObjectLiteralMethod3.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ verify.completions({
4747
},
4848
{
4949
name: "M",
50-
sortText: completion.SortText.AddIsSnippetSuffix(
50+
sortText: completion.SortText.SortBelow(
5151
completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "M")),
5252
source: completion.CompletionSource.ObjectLiteralMethodSnippet,
5353
insertText: "M(x: number): void {\n},",
@@ -101,7 +101,7 @@ verify.completions({
101101
},
102102
{
103103
name: "M",
104-
sortText: completion.SortText.AddIsSnippetSuffix(
104+
sortText: completion.SortText.SortBelow(
105105
completion.SortText.ObjectLiteralProperty(completion.SortText.OptionalMember, "M")),
106106
source: completion.CompletionSource.ObjectLiteralMethodSnippet,
107107
insertText: "M(x: number): void {\n},",
@@ -113,7 +113,7 @@ verify.completions({
113113
},
114114
{
115115
name: "N",
116-
sortText: completion.SortText.AddIsSnippetSuffix(
116+
sortText: completion.SortText.SortBelow(
117117
completion.SortText.ObjectLiteralProperty(completion.SortText.LocationPriority, "N")),
118118
source: completion.CompletionSource.ObjectLiteralMethodSnippet,
119119
insertText: "N(x: string): void {\n},",
@@ -125,7 +125,7 @@ verify.completions({
125125
},
126126
{
127127
name: "O",
128-
sortText: completion.SortText.AddIsSnippetSuffix(
128+
sortText: completion.SortText.SortBelow(
129129
completion.SortText.ObjectLiteralProperty(completion.SortText.OptionalMember, "O")),
130130
source: completion.CompletionSource.ObjectLiteralMethodSnippet,
131131
insertText: "O(): void {\n},",

tests/cases/fourslash/fourslash.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -853,7 +853,7 @@ declare namespace completion {
853853

854854
Deprecated(sortText: SortText): SortText,
855855
ObjectLiteralProperty(presetSortText: SortText, symbolDisplayName: string): SortText,
856-
AddIsSnippetSuffix(sortText: SortText): SortText,
856+
SortBelow(sortText: SortText): SortText,
857857
};
858858

859859
export const enum CompletionSource {

0 commit comments

Comments
 (0)