Test focusLocation with ranges

zkat · zkat · commit 054ce2d57264 · 2024-05-21T14:46:32.000-07:00
diff --git a/src/harness/fourslashImpl.ts b/src/harness/fourslashImpl.ts
@@ -4512,16 +4512,42 @@ export class TestState {
     }
 
     public baselineMapCode(
-        { fileName, pos }: Range,
+        ranges: Range[],
         changesFilename: string,
     ): void {
         const changes = this.getFileContent(changesFilename);
-        const beforeContents = this.getFileContent(fileName);
-        const before = beforeContents.slice(0, pos) + "[||]" + beforeContents.slice(pos);
+        let fileName: string | undefined;
+        const focusLocations = ranges.map(({ fileName: fn, pos, end }) => {
+            if (!fileName) {
+                fileName = fn;
+            }
+            return [{ start: pos, length: end - pos }];
+        });
+        if (!fileName) {
+            throw new Error("No ranges passed in, or something went wrong.");
+        }
+        let before = this.getFileContent(fileName);
+        focusLocations.sort((a, b) => a[0].start - b[0].start);
+        for (const subLoc of focusLocations) {
+            for (const { start, length } of subLoc) {
+                let offset = 0;
+                for (const sl2 of focusLocations) {
+                    for (const { start: s2, length: l2 } of sl2) {
+                        if (s2 < start) {
+                            offset += 4;
+                            if ((s2 + l2) > start) {
+                                offset -= 2;
+                            }
+                        }
+                    }
+                }
+                before = before.slice(0, start + offset) + "[|" + before.slice(start + offset, start + offset + length) + "|]" + before.slice(start + offset + length);
+            }
+        }
         const edits = this.languageService.mapCode(
             fileName,
             [changes],
-            [[{ start: pos, length: 1 }]],
+            focusLocations,
             this.formatCodeSettings,
             {},
         );
diff --git a/src/harness/fourslashInterfaceImpl.ts b/src/harness/fourslashInterfaceImpl.ts
@@ -240,8 +240,8 @@ export class VerifyNegatable {
         this.state.uncommentSelection(newFileContent);
     }
 
-    public baselineMapCode(range: FourSlash.Range, changesFilename: string): void {
-        this.state.baselineMapCode(range, changesFilename);
+    public baselineMapCode(ranges: FourSlash.Range[], changesFilename: string): void {
+        this.state.baselineMapCode(ranges, changesFilename);
     }
 }
 
diff --git a/tests/baselines/reference/mapCodeReplaceUsingRange.mapCode.ts b/tests/baselines/reference/mapCodeReplaceUsingRange.mapCode.ts
@@ -0,0 +1,22 @@
+// === mapCode ===
+
+// === ORIGINAL ===
+[|function foo() {
+    return 1;
+}[||]
+function bar() {
+    return [|2;|]
+}|]
+
+// === INCOMING CHANGES ===
+function foo() {
+    return 3;
+}
+
+// === MAPPED ===
+function foo() {
+    return 3;
+}
+function bar() {
+    return 2;
+}
diff --git a/tests/cases/fourslash/fourslash.ts b/tests/cases/fourslash/fourslash.ts
@@ -466,7 +466,7 @@ declare namespace FourSlashInterface {
                 copiedFrom?: { file: string, range: { pos: number, end: number }[] };
             }
         }): void;
-        baselineMapCode(range: Range, changesFilename?: string): void;
+        baselineMapCode(ranges: Range[], changesFilename?: string): void;
     }
     class edit {
         caretPosition(): Marker;
diff --git a/tests/cases/fourslash/mapCodeClassInvalidClassMember.ts b/tests/cases/fourslash/mapCodeClassInvalidClassMember.ts
@@ -10,4 +10,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeFocusLocationReplacement.ts b/tests/cases/fourslash/mapCodeFocusLocationReplacement.ts
@@ -35,4 +35,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeMethodInsertion.ts b/tests/cases/fourslash/mapCodeMethodInsertion.ts
@@ -20,4 +20,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeMethodReplacement.ts b/tests/cases/fourslash/mapCodeMethodReplacement.ts
@@ -20,4 +20,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeMixedClassDeclaration.ts b/tests/cases/fourslash/mapCodeMixedClassDeclaration.ts
@@ -22,4 +22,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedClassIfInsertion.ts b/tests/cases/fourslash/mapCodeNestedClassIfInsertion.ts
@@ -22,4 +22,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedClassIfReplacement.ts b/tests/cases/fourslash/mapCodeNestedClassIfReplacement.ts
@@ -22,4 +22,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedForInsertion.ts b/tests/cases/fourslash/mapCodeNestedForInsertion.ts
@@ -18,4 +18,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedForOfInsertion.ts b/tests/cases/fourslash/mapCodeNestedForOfInsertion.ts
@@ -16,4 +16,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedForOfReplacement.ts b/tests/cases/fourslash/mapCodeNestedForOfReplacement.ts
@@ -16,4 +16,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedForReplacement.ts b/tests/cases/fourslash/mapCodeNestedForReplacement.ts
@@ -16,4 +16,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedIfInsertion.ts b/tests/cases/fourslash/mapCodeNestedIfInsertion.ts
@@ -18,4 +18,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedIfReplace.ts b/tests/cases/fourslash/mapCodeNestedIfReplace.ts
@@ -18,4 +18,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedLabeledInsertion.ts b/tests/cases/fourslash/mapCodeNestedLabeledInsertion.ts
@@ -20,4 +20,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedLabeledReplace.ts b/tests/cases/fourslash/mapCodeNestedLabeledReplace.ts
@@ -20,4 +20,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedWhileInsertion.ts b/tests/cases/fourslash/mapCodeNestedWhileInsertion.ts
@@ -18,4 +18,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeNestedWhileReplace.ts b/tests/cases/fourslash/mapCodeNestedWhileReplace.ts
@@ -18,4 +18,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeRangeReplacement.ts b/tests/cases/fourslash/mapCodeRangeReplacement.ts
@@ -29,4 +29,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeReplaceUsingRange.ts b/tests/cases/fourslash/mapCodeReplaceUsingRange.ts
@@ -0,0 +1,17 @@
+///<reference path="fourslash.ts"/>
+
+// @Filename: /incomingChanges.ts
+//// function foo() {
+////     return 3;
+//// }
+////
+// @Filename: /index.ts
+//// [|function foo() {
+////     return 1;
+//// }[||]
+//// function bar() {
+////     return [|2;|]
+//// }|]
+////
+
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeToplevelInsert.ts b/tests/cases/fourslash/mapCodeToplevelInsert.ts
@@ -13,4 +13,4 @@
 ////     return 2;
 //// }
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeToplevelInsertNoClass.ts b/tests/cases/fourslash/mapCodeToplevelInsertNoClass.ts
@@ -13,4 +13,4 @@
 ////     return 2;
 //// }
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");
diff --git a/tests/cases/fourslash/mapCodeToplevelReplace.ts b/tests/cases/fourslash/mapCodeToplevelReplace.ts
@@ -14,4 +14,4 @@
 //// }
 ////
 
-verify.baselineMapCode(test.ranges()[0], "/incomingChanges.ts");
+verify.baselineMapCode(test.ranges(), "/incomingChanges.ts");

Original file line number	Diff line number	Diff line change
`@@ -240,8 +240,8 @@ export class VerifyNegatable {`
`240`	`240`	`this.state.uncommentSelection(newFileContent);`
`241`	`241`	`}`
`242`	`242`
`243`		`- public baselineMapCode(range: FourSlash.Range, changesFilename: string): void {`
`244`		`- this.state.baselineMapCode(range, changesFilename);`
	`243`	`+ public baselineMapCode(ranges: FourSlash.Range[], changesFilename: string): void {`
	`244`	`+ this.state.baselineMapCode(ranges, changesFilename);`
`245`	`245`	`}`
`246`	`246`	`}`
`247`	`247`
Original file line number	Diff line number	Diff line change
`@@ -466,7 +466,7 @@ declare namespace FourSlashInterface {`
`466`	`466`	`copiedFrom?: { file: string, range: { pos: number, end: number }[] };`
`467`	`467`	`}`
`468`	`468`	`}): void;`
`469`		`- baselineMapCode(range: Range, changesFilename?: string): void;`
	`469`	`+ baselineMapCode(ranges: Range[], changesFilename?: string): void;`
`470`	`470`	`}`
`471`	`471`	`class edit {`
`472`	`472`	`caretPosition(): Marker;`