feat: support type completion over js files

Author: idiotWu

Preferences.sublime-settings

@@ -1,5 +1,6 @@
 {
     "typescript_auto_format": false,
     "enable_typescript_language_service": true,
+    "enable_language_service_for_javascript": true,
     "enable_inline_error_tips": false
 }

typescript/libs/editor_client.py

@@ -39,6 +39,7 @@ def __init__(self):
         self.ts_auto_format_enabled = True
         self.ts_auto_indent_enabled = True
         self.auto_match_enabled = True
+        self.enable_language_service_for_js = True
 
     def initialize(self):
         """
@@ -65,6 +66,9 @@ def initialize(self):
         self.worker_client = WorkerClient(proc_file)
         self.service = ServiceProxy(self.worker_client, self.node_client)
 
+        settings.add_on_change("enable_language_service_for_javascript", self.load_language_service_setting_for_js)
+        self.load_language_service_setting_for_js()
+
         # load formatting settings and set callbacks for setting changes
         for setting_name in [
             'tab_size',
@@ -79,6 +83,10 @@ def initialize(self):
 
         self.initialized = True
 
+    def load_language_service_setting_for_js(self):
+        settings = sublime.load_settings('Preferences.sublime-settings')
+        self.enable_language_service_for_js = settings.get("enable_language_service_for_javascript", True)
+
     def load_format_settings(self):
         settings = sublime.load_settings('Preferences.sublime-settings')
         self.tab_size = settings.get('tab_size', 4)

typescript/libs/view_helpers.py

@@ -41,7 +41,7 @@ def get_info(view, open_if_not_cached=True):
     """Find the file info on the server that matches the given view"""
     if not get_language_service_enabled():
         return
-    
+
     if not cli.initialized:
         cli.initialize()
 
@@ -106,15 +106,18 @@ def is_typescript(view):
     except:
         return False
 
-    return (view.match_selector(location, 'source.ts') or
-            view.match_selector(location, 'source.tsx'))
+    is_ts_file = view.match_selector(location, 'source.ts, source.tsx')
+    is_js_file = cli.enable_language_service_for_js \
+        and view.match_selector(location, 'source.js, source.jsx')
+
+    return is_ts_file or is_js_file
 
 
 def is_special_view(view):
     """Determine if the current view is a special view.
 
     Special views are mostly referring to panels. They are different from normal views
-    in that they cannot be the active_view of their windows, therefore their ids 
+    in that they cannot be the active_view of their windows, therefore their ids
     shouldn't be equal to the current view id.
     """
     return view is not None and view.window() and view.id() != view.window().active_view().id()
@@ -265,7 +268,7 @@ def reload_required(view):
 def check_update_view(view):
     """Check if the buffer in the view needs to be reloaded
 
-    If we have changes to the view not accounted for by change messages, 
+    If we have changes to the view not accounted for by change messages,
     send the whole buffer through a temporary file
     """
     if is_typescript(view):
@@ -276,7 +279,7 @@ def check_update_view(view):
 
 def send_replace_changes_for_regions(view, regions, insert_string):
     """
-    Given a list of regions and a (possibly zero-length) string to insert, 
+    Given a list of regions and a (possibly zero-length) string to insert,
     send the appropriate change information to the server.
     """
     if not is_typescript(view):