Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element.textContent should not be nullable #1939

Open
mohd-akram opened this issue Mar 15, 2025 · 0 comments · May be fixed by #1942
Open

Element.textContent should not be nullable #1939

mohd-akram opened this issue Mar 15, 2025 · 0 comments · May be fixed by #1942

Comments

@mohd-akram
Copy link

textContent is inherited from Node, but in an Element context it is never null. It can be added to Element as string instead of string | null to eliminate unnecessary null checks.
@alex-kinokon alex-kinokon linked a pull request Mar 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make most textContent not nullable alex-kinokon/TypeScript-DOM-lib-generator
1 participant
@mohd-akram