Added new test to PHPunit testsuite

changed linefeed detection

Author: VeryStrongFingers

phpunit.xml.dist

@@ -14,6 +14,9 @@
         <testsuite name="Github Actions printer for PHPUnit Test Suite">
             <directory suffix=".phpt">./test/</directory>
         </testsuite>
+        <testsuite name="Github Actions printer for PHPUnit Test Suite">
+            <directory suffix=".php">./test/Unit/</directory>
+        </testsuite>
     </testsuites>
     <filter>
         <whitelist>

src/Functions/helpers.php

@@ -76,7 +76,10 @@ static function ($l) {
 
     // Some messages might contain paths. Let's convert thost to relative paths too
     $message = relativePath($message);
-    $message = preg_replace('/%0A$/', '', $message);
+    $lineFeedPosition = strpos($message, '%0A');
+    if (is_int($lineFeedPosition) === true) {
+        $message = substr($message, 0, $lineFeedPosition);
+    }
 
     $path = relativePath($path);
     $file = "file={$path}";

test/Unit/HelperFunctionTest.php

@@ -0,0 +1,64 @@
+<?php
+
+use mheap\GithubActionsReporter\Printer6;
+use mheap\GithubActionsReporter\Printer7;
+use mheap\GithubActionsReporter\Printer8;
+use mheap\GithubActionsReporter\Printer9;
+use PHPUnit\Framework\TestCase;
+
+use function mheap\GithubActionsReporter\Functions\determinePrinter;
+
+class HelperFunctionTest extends TestCase
+{
+    public function getInputsForVersionSelection()
+    {
+        yield 'invalid version' => [
+            'version' => 'aaa',
+            'expected' => null
+        ];
+
+        yield 'minor version 9.4' => [
+            'version' => '9.4',
+            'expected' => Printer9::class
+        ];
+
+        yield 'major version 9' => [
+            'version' => '9.0',
+            'expected' => Printer9::class
+        ];
+
+        yield 'minor version 9.1' => [
+            'version' => '9.1',
+            'expected' => Printer9::class
+        ];
+
+        yield 'minor version 8.2' => [
+            'version' => '8.2',
+            'expected' => Printer8::class
+        ];
+
+        yield 'patch version 7.0.1' => [
+            'version' => '7.0.1',
+            'expected' => Printer7::class
+        ];
+
+        yield 'minor version 6.5' => [
+            'version' => '6.5',
+            'expected' => Printer6::class
+        ];
+
+        yield 'minor version 5' => [
+            'version' => '5.0',
+            'expected' => null
+        ];
+    }
+    /**
+     * @dataProvider getInputsForVersionSelection()
+     */
+    public function testVersionSelector($version, $expected): void
+    {
+        $result = determinePrinter($version);
+
+        self::assertSame($expected, $result);
+    }
+}

test/_files/HelperFunctionTest.php

@@ -1,64 +0,0 @@
-<?php
-
-use mheap\GithubActionsReporter\Printer6;
-use mheap\GithubActionsReporter\Printer7;
-use mheap\GithubActionsReporter\Printer8;
-use mheap\GithubActionsReporter\Printer9;
-use PHPUnit\Framework\TestCase;
-
-use function mheap\GithubActionsReporter\Functions\determinePrinter;
-
-class HelperFunctionTest extends TestCase
-{
-    public function getInputsForVersionSelection()
-    {
-        yield 'invalid version' => [
-            'version' => 'aaa',
-            'expected' => null
-        ];
-
-        yield 'minor version 9.4' => [
-            'version' => '9.4',
-            'expected' => Printer9::class
-        ];
-
-        yield 'major version 9' => [
-            'version' => '9.0',
-            'expected' => Printer9::class
-        ];
-
-        yield 'minor version 9.1' => [
-            'version' => '9.1',
-            'expected' => Printer9::class
-        ];
-
-        yield 'minor version 8.2' => [
-            'version' => '8.2',
-            'expected' => Printer8::class
-        ];
-
-        yield 'patch version 7.0.1' => [
-            'version' => '7.0.1',
-            'expected' => Printer7::class
-        ];
-
-        yield 'minor version 6.5' => [
-            'version' => '6.5',
-            'expected' => Printer6::class
-        ];
-
-        yield 'minor version 5' => [
-            'version' => '5.0',
-            'expected' => null
-        ];
-    }
-    /**
-     * @dataProvider getInputsForVersionSelection()
-     */
-    public function testVersionSelector($version, $expected): void
-    {
-        $result = determinePrinter($version);
-
-        self::assertSame($expected, $result);
-    }
-}