Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: old-multi-activity
Choose a base ref
...
head repository: melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 162 files changed
  • 5 contributors

Commits on Aug 21, 2019

  1. Single activity approach (#30)

    * CircleCI config fixes
    
    * Implicit deeplinking via navController navigate
    
    * Removed jacoco.exec files. Closes # 32
    melihaksoy committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    2a90aba View commit details
    Browse the repository at this point in the history
  2. Update README.md (#33)

    Fixed CircleCI badge
    melihaksoy authored Aug 21, 2019
    Configuration menu
    Copy the full SHA
    ffe846a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. Update android.yml

    melihaksoy authored Aug 28, 2019
    Configuration menu
    Copy the full SHA
    934a50a View commit details
    Browse the repository at this point in the history
  2. Update android.yml

    Updated github workflow
    melihaksoy committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    aafd76f View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2019

  1. Update README.md

    melihaksoy authored Aug 29, 2019
    Configuration menu
    Copy the full SHA
    9c6d71f View commit details
    Browse the repository at this point in the history
  2. Update README.md

    melihaksoy committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    5a10edc View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Feature/styling (#36)

    * Working with material styles
    
    * Replaced deprecated ViewModelProviders.of and applied base styles with material components
    
    * Various code style fixes and styles.xml improvements
    melihaksoy authored Sep 13, 2019
    Configuration menu
    Copy the full SHA
    99a2abf View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. Update android.yml

    melihaksoy authored Sep 20, 2019
    Configuration menu
    Copy the full SHA
    c3dba5e View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. Updated fastlane version (#39)

    Signed-off-by: Melih Aksoy <aksoy.melihcan@gmail.com>
    melihaksoy authored Sep 23, 2019
    Configuration menu
    Copy the full SHA
    9aa7a5b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2019

  1. #34 Change use of deprecated NetworkInfo enhancement (#38)

    * replace NetworkInto with the ConnectivityManager. Since this network validation is being done at repository level, I've had to add the network dependency on it's own AndroidManifest.
    
    * moved network_state_permission from repository manifest to app's manifest.
    removed wildcard imports.
    now, network_info it's been provided and not the connectivity_manager
    victorvicari authored and melihaksoy committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    8344e7f View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2019

  1. Feature/core repository separation (#44)

    * Fixed wrong package name. Fixes #43 
    
    * Updated package name. Fixes #41 
    
    * Ignoring not-used warning - this graph is included in main graph
    
    * Separated repository from core. Fixes #42 
    
    * Removing adapter from recyclerView when view is destroyed to prevent leak. Fixes #40 
    
    * Updated new module graph
    
    Signed-off-by: Melih Aksoy <aksoy.melihcan@gmail.com>
    melihaksoy authored Sep 26, 2019
    Configuration menu
    Copy the full SHA
    83e3940 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. WIP: feature/abstractions (#45)

    * Abstraction layer backup
    
    * Removed DataEntity, was unnecessary for now
    
    * Separated network, persistence, entities and interaction, closes #29
    
    * Renamed binding
    
    * Removed build files, example tests
    
    Removed build files, example tests
    
    * Fixed build files were not being ignored all around app
    
    * Updated CI ymls
    
    * Small changes
    
    * Fixed legacy repository package names
    
    * Fixed CQ findings
    
    * Updated Fastlane
    
    * Packaging changes and version upgrades
    
    * Removed core from interactors
    
    * Version bumps
    
    * Added new module graph
    melihaksoy authored Oct 30, 2019
    Configuration menu
    Copy the full SHA
    8802262 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Fixing crash due to initialization order in detail inj

    Melih Aksoy committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    a6fec53 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Fixes & early adoptation to AS 4.0

    Melih Aksoy committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    a68dac7 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2020

  1. Removed test case of detail

    Melih Aksoy authored and Melih Aksoy committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    ac89207 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Updated workflow commands & gems

    Melih Aksoy authored and Melih Aksoy committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    bd1bc9c View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Configuration menu
    Copy the full SHA
    927c5c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef05fa7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    75f2654 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Version updates

    melihaksoy committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    1bcde28 View commit details
    Browse the repository at this point in the history
Loading