Skip to content

Commit eefc378

Browse files
committed
nit
1 parent f749de4 commit eefc378

File tree

3 files changed

+23
-1
lines changed

3 files changed

+23
-1
lines changed

src/client.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1376,6 +1376,8 @@ mod tests {
13761376

13771377
let new_index = client.get_index(&to).await?;
13781378
assert_eq!(new_index.uid, to);
1379+
// Optional: old uid should no longer resolve
1380+
assert!(client.get_raw_index(&from).await.is_err());
13791381

13801382
new_index
13811383
.delete()

src/indexes.rs

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1839,6 +1839,11 @@ impl<'a, Http: HttpClient> IndexUpdater<'a, Http> {
18391839
self
18401840
}
18411841

1842+
/// Alias for `with_uid` with clearer intent.
1843+
pub fn with_new_uid(&mut self, new_uid: impl AsRef<str>) -> &mut IndexUpdater<'a, Http> {
1844+
self.with_uid(new_uid)
1845+
}
1846+
18421847
/// Execute the update of an [Index] using the [`IndexUpdater`].
18431848
///
18441849
/// # Example
@@ -2257,13 +2262,25 @@ mod tests {
22572262
let new_index = client.get_index(&to).await?;
22582263
assert_eq!(new_index.uid, to);
22592264

2265+
// Old index should no longer exist
2266+
let old_index = client.get_index(&from).await;
2267+
assert!(old_index.is_err(), "old uid still resolves after rename");
2268+
22602269
// cleanup
22612270
new_index
22622271
.delete()
22632272
.await?
22642273
.wait_for_completion(&client, None, None)
22652274
.await?;
22662275

2276+
// defensive cleanup if rename semantics change
2277+
if let Ok(idx) = client.get_index(&from).await {
2278+
idx.delete()
2279+
.await?
2280+
.wait_for_completion(&client, None, None)
2281+
.await?;
2282+
}
2283+
22672284
Ok(())
22682285
}
22692286

src/search.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ pub struct SearchResults<T> {
128128
alias = "query_vector",
129129
alias = "queryEmbedding",
130130
alias = "query_embedding",
131+
alias = "vector",
131132
skip_serializing_if = "Option::is_none"
132133
)]
133134
pub query_vector: Option<Vec<f32>>,
@@ -2041,7 +2042,9 @@ pub(crate) mod tests {
20412042

20422043
let results: SearchResults<Document> = index.execute_query(&query).await?;
20432044

2044-
if results.query_vector.is_none() {
2045+
if std::env::var("MSDK_DEBUG_RAW_SEARCH").ok().as_deref() == Some("1")
2046+
&& results.query_vector.is_none()
2047+
{
20452048
use crate::request::Method;
20462049
let url = format!("{}/indexes/{}/search", index.client.get_host(), index.uid);
20472050
let raw: serde_json::Value = index

0 commit comments

Comments
 (0)