-
Notifications
You must be signed in to change notification settings - Fork 8
Added Additional Pin Definitions for sx1276 Radio #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Additional Pin Definitions for sx1276 Radio #128
Conversation
Hello! Anyone able to review this? @terrillmoore |
Hi @kent-williams -- sorry, it's been very busy here. I've asked @chwon64 to review. We are planning a new release shortly. I'll also take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as long as we change comments in variant.cpp
. 4551 is a puzzle; it doesn't make sense to define RADIO_TCXO on that platform, as TCXO is always on and can't be controlled. This will make things a bit ugly if @kent-williams needs to support all from a single source, but perhaps he can just ignore the 4551 in his code. We ought to consider deprecating, then obsoleting, 4551 support, as it was only used internally at MCCI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Would still love to see this get merged if possible! |
@terrillmoore @chwon64 Can we merge this please? |
Thanks @kent-williams ! |
This PR adds additional pin definitions for the sx1276 radio in the Murata CMWX1ZZABZ-078 module.
I am using the Semtech drivers directly, and not using the MCCI LoRaWAN implementations, so having these definitions helps my pin readability considerably!
-Kent