Skip to content

Conversation

kent-williams
Copy link

This PR adds additional pin definitions for the sx1276 radio in the Murata CMWX1ZZABZ-078 module.

I am using the Semtech drivers directly, and not using the MCCI LoRaWAN implementations, so having these definitions helps my pin readability considerably!

-Kent

@kent-williams
Copy link
Author

Hello! Anyone able to review this? @terrillmoore
Thanks!

@terrillmoore
Copy link
Member

Hi @kent-williams -- sorry, it's been very busy here. I've asked @chwon64 to review. We are planning a new release shortly. I'll also take a look.

@terrillmoore terrillmoore self-requested a review October 1, 2019 12:05
Copy link
Member

@terrillmoore terrillmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as we change comments in variant.cpp. 4551 is a puzzle; it doesn't make sense to define RADIO_TCXO on that platform, as TCXO is always on and can't be controlled. This will make things a bit ugly if @kent-williams needs to support all from a single source, but perhaps he can just ignore the 4551 in his code. We ought to consider deprecating, then obsoleting, 4551 support, as it was only used internally at MCCI.

Copy link
Member

@terrillmoore terrillmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kent-williams
Copy link
Author

Would still love to see this get merged if possible!

@kent-williams
Copy link
Author

kent-williams commented Oct 21, 2019

@terrillmoore @chwon64 Can we merge this please?

@terrillmoore terrillmoore merged commit c653872 into mcci-catena:master Oct 22, 2019
@terrillmoore
Copy link
Member

Thanks @kent-williams !

@kent-williams kent-williams deleted the kent-williams/add-sx1276-pin-defs branch October 22, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants