Don't fail if alt attribute not present

Author: Marcin Szczepanski

src/gallery.js

@@ -35,8 +35,8 @@
 				item.className = "inactive";
 			}
 			var label = item.querySelector("label");
-			if (!label) {
-				var img = item.querySelector("img");
+			var img = item.querySelector("img");
+			if (!label && img.attributes.alt) {
 				label = document.createElement("label");
 				label.innerHTML = img.attributes.alt.value;
 				item.appendChild(label);

tests/test.gallery.js

@@ -5,20 +5,17 @@ describe('Gallery', function () {
 
 	describe('#start', function () {
 		var itemElem1, itemElem2, items, galleryElem;
-		var MockItem = function (hasLabel) {
+		var MockItem = function (hasLabel, attributes) {
 			this.hasLabel = hasLabel;
+			this.attributes = attributes;
 			return this;
 		};
 		MockItem.prototype.querySelector = function (selector) {
 			if (selector === "label") {
 				return this.hasLabel;
 			} else if (selector === "img") {
 				return {
-					attributes: {
-						alt: {
-							value: "ALT"
-						}
-					}
+					attributes: this.attributes
 				};
 			}
 		};
@@ -27,8 +24,8 @@ describe('Gallery', function () {
 
 		beforeEach(function () {
 			/* Mock Item elements */
-			itemElem1 = new MockItem(true);			
-			itemElem2 = new MockItem(false);
+			itemElem1 = new MockItem(true, {});			
+			itemElem2 = new MockItem(false, {alt: { value: "ALT"}});
 			items = [itemElem1, itemElem2];
 			/* Mock DOM Gallery element */
 			galleryElem = {
@@ -77,6 +74,13 @@ describe('Gallery', function () {
 			appendChildSpy1.restore();
 			appendChildSpy2.restore();
 		});
+		it("doesn't fail if items doesn't have an alt attribute", function () {
+			delete itemElem2.attributes.alt;
+			var appendChildSpy2 = sinon.spy(itemElem2, "appendChild");
+			Gallery.start(galleryElem);
+			expect(appendChildSpy2.called).to.be.false;
+			appendChildSpy2.restore();
+		});
 	});
 	describe('#step', function () {
 		var items;