Skip to content

Commit 5f62960

Browse files
committed
Miscellaneous minor stuff:
* scripts/minimaws: Set option strict for JavaScript code. * util/mfpresolve.h: Be explicit about turning nullptr into a pointer to data. * cpu/drcbearm64.cpp: Reduced number of temporary registers used for AND with some operand combinations.
1 parent d7d7a4c commit 5f62960

File tree

6 files changed

+16
-8
lines changed

6 files changed

+16
-8
lines changed

scripts/minimaws/lib/assets/common.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// license:BSD-3-Clause
22
// copyright-holders:Vas Crabb
3+
'use strict';
34

45
function make_collapsible(heading, section)
56
{

scripts/minimaws/lib/assets/digest.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// license:BSD-3-Clause
22
// copyright-holders:Vas Crabb
3+
'use strict';
34

45
function Crc32Digester()
56
{

scripts/minimaws/lib/assets/machine.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// license:BSD-3-Clause
22
// copyright-holders:Vas Crabb
3+
'use strict';
34

45
var slot_info = Object.create(null);
56
var bios_sets = Object.create(null);

scripts/minimaws/lib/assets/romident.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// license:BSD-3-Clause
22
// copyright-holders:Vas Crabb
3+
'use strict';
34

45
var matched_names = new Array();
56
var unmatched_names = new Array();

src/devices/cpu/drcbearm64.cpp

+6-6
Original file line numberDiff line numberDiff line change
@@ -4042,36 +4042,36 @@ void drcbe_arm64::op_and(a64::Assembler &a, const uml::instruction &inst)
40424042
}
40434043
else if (src1p.is_immediate() && is_valid_immediate_mask(src1p.immediate(), inst.size()))
40444044
{
4045-
const a64::Gp src2 = src2p.select_register(TEMP_REG1, inst.size());
4045+
const a64::Gp src2 = src2p.select_register(dst, inst.size());
40464046
mov_reg_param(a, inst.size(), src2, src2p);
40474047

40484048
a.emit(opcode, dst, src2, src1p.immediate());
40494049
}
40504050
else if (src2p.is_immediate() && is_valid_immediate_mask(src2p.immediate(), inst.size()))
40514051
{
4052-
const a64::Gp src1 = src1p.select_register(TEMP_REG1, inst.size());
4052+
const a64::Gp src1 = src1p.select_register(dst, inst.size());
40534053
mov_reg_param(a, inst.size(), src1, src1p);
40544054

40554055
a.emit(opcode, dst, src1, src2p.immediate());
40564056
}
40574057
else if ((inst.size() == 8) && src1p.is_immediate() && is_valid_immediate_mask(src1p.immediate(), 4) && (!inst.flags() || !BIT(src1p.immediate(), 31)))
40584058
{
4059-
const a64::Gp src2 = src2p.select_register(TEMP_REG1, inst.size());
4059+
const a64::Gp src2 = src2p.select_register(dst, inst.size());
40604060
mov_reg_param(a, inst.size(), src2, src2p);
40614061

40624062
a.emit(opcode, dst.w(), src2.w(), src1p.immediate());
40634063
}
40644064
else if ((inst.size() == 8) && src2p.is_immediate() && is_valid_immediate_mask(src2p.immediate(), 4) && (!inst.flags() || !BIT(src2p.immediate(), 31)))
40654065
{
4066-
const a64::Gp src1 = src1p.select_register(TEMP_REG1, inst.size());
4066+
const a64::Gp src1 = src1p.select_register(dst, inst.size());
40674067
mov_reg_param(a, inst.size(), src1, src1p);
40684068

40694069
a.emit(opcode, dst.w(), src1.w(), src2p.immediate());
40704070
}
40714071
else
40724072
{
4073-
const a64::Gp src1 = src1p.select_register(TEMP_REG1, inst.size());
4074-
const a64::Gp src2 = src2p.select_register(TEMP_REG2, inst.size());
4073+
const a64::Gp src1 = src1p.select_register(dst, inst.size());
4074+
const a64::Gp src2 = src2p.select_register(TEMP_REG1, inst.size());
40754075
mov_reg_param(a, inst.size(), src1, src1p);
40764076
mov_reg_param(a, inst.size(), src2, src2p);
40774077

src/lib/util/mfpresolve.h

+6-2
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ inline std::pair<std::uintptr_t, std::uintptr_t> resolve_member_function(Ret (T:
7575
}
7676
else
7777
{
78-
return std::make_pair(std::uintptr_t(static_cast<void (*)()>(nullptr)), std::uintptr_t(nullptr));
78+
return std::make_pair(
79+
std::uintptr_t(static_cast<void (*)()>(nullptr)),
80+
std::uintptr_t(static_cast<void *>(nullptr)));
7981
}
8082
}
8183

@@ -96,7 +98,9 @@ inline std::pair<std::uintptr_t, std::uintptr_t> resolve_member_function(Ret (T:
9698
}
9799
else
98100
{
99-
return std::make_pair(std::uintptr_t(static_cast<void (*)()>(nullptr)), std::uintptr_t(nullptr));
101+
return std::make_pair(
102+
std::uintptr_t(static_cast<void (*)()>(nullptr)),
103+
std::uintptr_t(static_cast<void *>(nullptr)));
100104
}
101105
}
102106

0 commit comments

Comments
 (0)