-
Notifications
You must be signed in to change notification settings - Fork 70
Removing the unused phpseclib/phpseclib composer package in TwoFactorAuth
#308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the unused phpseclib/phpseclib composer package in TwoFactorAuth
#308
Conversation
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
Hi @nathanjosiah, could you confirm that this package is still used within TwoFactorAuth? Unfortunately, I couldn't find any usages so far. Please let me know if we're safe to get rid of this dependency. Thank you. |
|
@magento run WebAPI Tests, Functional Tests CE |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
d46c4ad to
159c113
Compare
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
phpseclib/phpseclib composer package in TwoFactorAuthphpseclib/phpseclib composer package in TwoFactorAuth
|
@magento import code to https://github.com/magento-commerce/security-package |
|
@magento import code to https://github.com/magento-commerce/security-package |
|
@magento import code to magento-commerce/security-package |
|
@magento import pr to magento-commerce/security-package |
Description (*)
This PR aims to remove the unused
phpseclib/phpseclibcomposer package.Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
N/A
Questions or comments
Contribution checklist (*)