Skip to content

Conversation

@eduard13
Copy link

@eduard13 eduard13 commented Sep 13, 2021

Description (*)

This PR aims to remove the unused phpseclib/phpseclib composer package.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@eduard13
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13
Copy link
Author

Hi @nathanjosiah, could you confirm that this package is still used within TwoFactorAuth? Unfortunately, I couldn't find any usages so far. Please let me know if we're safe to get rid of this dependency.

Thank you.

@eduard13
Copy link
Author

@magento run WebAPI Tests, Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13
Copy link
Author

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13 eduard13 changed the title Upgrading phpseclib/phpseclib composer package in TwoFactorAuth Removing the unused phpseclib/phpseclib composer package in TwoFactorAuth Sep 14, 2021
@nathanjosiah
Copy link
Contributor

@nathanjosiah
Copy link
Contributor

@nathanjosiah
Copy link
Contributor

@magento import code to magento-commerce/security-package

@mmansoor-magento
Copy link
Contributor

@magento import pr to magento-commerce/security-package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants