-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Can we add another region column with ISO_3166-2 codes #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @joh-klein, you can read more about labels here http://devdocs.magento.com/guides/v1.0/contributor-guide/CONTRIBUTING.html#labels. This label means that issue should be reviewed and accepted by our Product Team. |
Thanks! I just found it myself and deleted my original comment for rtfm reasons :) |
@piotrekkaminski Piotr--would you be the right owner here? |
@pboisvert actually @antboiko as it is i18n issue. I've created internal issue MAGETWO-52665 to track this request. |
Thank you for your submission. We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues. Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here). We are closing this GitHub ticket and have moved your request to the new forum. |
Fix modularity of InventoryShipping module
The current region codes for Germany seem not to be widely known (a quick Google search didn't reveal a source for them). And some others seem to be impractical but most importantly will probably hinder exchanging addresses with other systems.
I could provide a PR with the current data for regions from Wikipedia for these 13 countries (US, CA, DE, AT, CH, ES, FR, RO, FI, EE, LV, LT, BR). Right now I lean towards adding another column for backwards compatibility.
Quick link to relevant source code:
https://github.com/magento/magento2/blob/develop/app/code/Magento/Directory/Setup/InstallData.php#L300
The text was updated successfully, but these errors were encountered: