Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Does Not Reflect Catalog Rule Discounts #39745

Closed
3 of 5 tasks
tuyennn opened this issue Mar 18, 2025 · 6 comments
Closed
3 of 5 tasks

GraphQL Does Not Reflect Catalog Rule Discounts #39745

tuyennn opened this issue Mar 18, 2025 · 6 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@tuyennn
Copy link
Member

tuyennn commented Mar 18, 2025

Preconditions and environment

  • Magento version: 2.3.x to 2.4.x

Steps to reproduce

  1. A product match a catalog rule
  2. Below is the indexed price of a sample product: sku: FOO
customer_group_id price final_price min_price max_price
0 275.000000 247.000000 247.000000 247.000000
1 275.000000 247.000000 247.000000 247.000000
2 275.000000 247.000000 247.000000 247.000000
  1. Query with a graphql
{
  products(
    filter: { sku: { eq: "FOO" } }
    pageSize: 1
    currentPage: 1
  ) {
    total_count
    page_info {
      page_size
      current_page
    }
    items {
      id
      name
      sku
      price_range {
        minimum_price {
          regular_price {
            value
            currency
          }
          final_price {
            value
            currency
          }
          discount {
            amount_off
            percent_off
          }
        }
        maximum_price {
          regular_price {
            value
            currency
          }
          final_price {
            value
            currency
          }
          discount {
            amount_off
            percent_off
          }
        }
      }
    }
  }
}
  1. Observe the response with NOT logged in customer
  2. Observe the response with LOGGED in customer and compare to step 4th

Expected result

Response of the price_range from graphql for both scenarios

{
    "data": {
        "products": {
            "total_count": 1,
            "page_info": {
                "page_size": 1,
                "current_page": 1
            },
            "items": [
                {
                    "id": 1,
                    "name": "FOO",
                    "sku": "FOO",
                    "price_range": {
                        "minimum_price": {
                            "regular_price": {
                                "value": 275,
                                "currency": "USD"
                            },
                            "final_price": {
                                "value": 247,
                                "currency": "USD"
                            },
                            "discount": {
                                "amount_off": 28,
                                "percent_off": 10.18
                            }
                        },
                        "maximum_price": {
                            "regular_price": {
                                "value": 275,
                                "currency": "USD"
                            },
                            "final_price": {
                                "value": 247,
                                "currency": "USD"
                            },
                            "discount": {
                                "amount_off": 28,
                                "percent_off": 10.18
                            }
                        }
                    }
                }
            ]
        }
    }
}

Actual result

Response for guest customer is ok, but for the logged in customer the response was wrong and doesn't reflect the catalog rule:

{
    "data": {
        "products": {
            "total_count": 1,
            "page_info": {
                "page_size": 1,
                "current_page": 1
            },
            "items": [
                {
                    "id": 1,
                    "name": "FOO",
                    "sku": "FOO",
                    "price_range": {
                        "minimum_price": {
                            "regular_price": {
                                "value": 275,
                                "currency": "USD"
                            },
                            "final_price": {
                                "value": 275,
                                "currency": "USD"
                            },
                            "discount": {
                                "amount_off": 0,
                                "percent_off": 0
                            }
                        },
                        "maximum_price": {
                            "regular_price": {
                                "value": 275,
                                "currency": "USD"
                            },
                            "final_price": {
                                "value": 275,
                                "currency": "USD"
                            },
                            "discount": {
                                "amount_off": 0,
                                "percent_off": 0
                            }
                        }
                    }
                }
            ]
        }
    }
}

Additional information

Well as the investigation, from vendor/magento/module-catalog-rule/etc/webapi_rest/*.xml was not reflected on graphql level should be etc/graphql

<?xml version="1.0"?>
<!--
/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
    <type name="Magento\Catalog\Model\Product">
        <plugin name="apply_catalog_rules_after_product_save_and_reindex" type="Magento\CatalogRule\Plugin\Indexer\Product\Save\ApplyRulesAfterReindex"/>
    </type>
</config>

Also vendor/magento/module-catalog-rule/etc/events.xml, below content should be applied on graphql level.

<?xml version="1.0"?>
    <!--
    /**
     * Copyright © Magento, Inc. All rights reserved.
     * See COPYING.txt for license details.
     */
    -->
    <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
        <event name="catalog_product_get_final_price">
            <observer name="catalogrule" instance="Magento\CatalogRule\Observer\ProcessFrontFinalPriceObserver" />
        </event>
        <event name="prepare_catalog_product_collection_prices">
            <observer name="catalogrule" instance="Magento\CatalogRule\Observer\PrepareCatalogProductCollectionPricesObserver" />
        </event>
    </config>

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Mar 18, 2025

Hi @tuyennn. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo self-assigned this Mar 18, 2025
Copy link

m2-assistant bot commented Mar 18, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Mar 18, 2025
@engcom-Bravo
Copy link
Contributor

Hi @tuyennn,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

Response for Guest Customer

Image

Response for LOGGED in customer

Image

Both are reflecting catalog rule discounts.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Mar 19, 2025
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Mar 19, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Mar 19, 2025
@tuyennn
Copy link
Member Author

tuyennn commented Mar 20, 2025

Something wrong with the cache or graphql cache, while triggering save product, the issue is no longer reproducible

@engcom-Bravo
Copy link
Contributor

Hi @tuyennn,

Thanks for your quick update.

Since the issue is no more reproducible we are closing this issue.Please feel free to reopen the issue if the issue still persists.

Thanks.

@tuyennn
Copy link
Member Author

tuyennn commented Mar 20, 2025

@engcom-Bravo I believe it was still there but I'm also unable to prove it a valid issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

2 participants