Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change constant IMAGE_FILE_NAME_PATTERN to public visible, for more flexibility #39733

Open
magefast opened this issue Mar 12, 2025 · 5 comments
Labels
Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@magefast
Copy link

private const IMAGE_FILE_NAME_PATTERN = '#\.(jpg|jpeg|gif|png)$# i';

Copy link

m2-assistant bot commented Mar 12, 2025

Hi @magefast. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-November engcom-November self-assigned this Mar 13, 2025
Copy link

m2-assistant bot commented Mar 13, 2025

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hello @magefast

Could you please provide the necessary details to reproduce the issue?

Kindly include the following information:

  • Description of the issue
  • Steps to Reproduce
  • Expected Results
  • Actual Results

This will help us investigate and resolve the problem effectively.

Thank You!

@engcom-November engcom-November added the Issue: needs update Additional information is require, waiting for response label Mar 14, 2025
@magefast
Copy link
Author

@engcom-November
for example

If ad custom module - can not override private const IMAGE_FILE_NAME_PATTERN
maybe better way - return const IMAGE_FILE_NAME_PATTERN with public method, that can normally change with plugins.

For example - need add custom type of image file upload

@engcom-November
Copy link
Contributor

Hello @magefast

Thank you for your report and collaboration.

Upon review, we have identified that this requires developer attention. Therefore, we are moving it to Triage Dev Experience for further action.

Thank you!

@engcom-November engcom-November added Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it and removed Issue: needs update Additional information is require, waiting for response labels Mar 17, 2025
@engcom-November engcom-November removed their assignment Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

No branches or pull requests

2 participants