[Issue] [PHPDOC] Fix bad phpdoc for Magento\Framework\Message\ManagerInterface #39593
Open
3 of 5 tasks
Labels
Priority: P3
May be fixed according to the position in the backlog.
Triage: Dev.Experience
Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
This issue is automatically created based on existing pull request: #39153: [PHPDOC] Fix bad phpdoc for Magento\Framework\Message\ManagerInterface
Description (*)
This PR fix the bad phpdoc for
\Magento\Framework\Message\ManagerInterface
and remove all duplicate phpdoc in\Magento\Framework\Message\Manager
(use inheritdoc syntaxe).Actually all
add*Message
functions (addErrorMessage, addSuccess, addWarningMessage, ...) accept astring
value in$message
variable.This PR allows to pass either a
\Magento\Framework\Phrase
or astring
.Here is an example where the type
\Magento\Framework\Phrase
is used :magento2/app/code/Magento/Checkout/Controller/Cart/Delete.php
Line 38 in 0cfe4a3
For example, with PHPSTAN is very complicated to setup the project with level 5 or higher :(
Related Pull Requests
None
Fixed Issues (if relevant)
None
Manual testing scenarios (*)
Setup PHPSTAN with level 5 or higher and run check.
Contribution checklist (*)
The text was updated successfully, but these errors were encountered: